fix: Allows multiple protocols on one port #741

Merged
decentral1se merged 2 commits from p4u1/abra:patch-docker-yolo into main 2026-02-13 09:29:02 +00:00
Owner
Docs PR: https://git.coopcloud.tech/toolshed/docs.coopcloud.tech/pulls/297
p4u1 added 1 commit 2025-12-30 14:14:41 +00:00
fix: Allows multiple protocols on one port
Some checks failed
continuous-integration/drone/pr Build is failing
3e98d8797f
p4u1 force-pushed patch-docker-yolo from 3e98d8797f to 0dc98051e7 2026-02-02 13:05:04 +00:00 Compare
Author
Owner

@decentral1se @ammaratef45 I added an integration test. What do you think? Shall we merge this? I can also clean up the test by not using my forkof the test recipe for it

@decentral1se @ammaratef45 I added an integration test. What do you think? Shall we merge this? I can also clean up the test by not using my forkof the test recipe for it
Owner

@p4u1 I'm into it but I fear this might cause even more chaos with #728. I struggled to upgrade the dependencies recently due to docker upstream maintenance chaos 😬 Is there any way to create this patch somehow "locally" that it can be applied to the vendored modules? Otherwise, this creates a circle where we need to update your fork, then update our deps 👁️ Curious how you think we can manage this.

@p4u1 I'm into it but I fear this might cause even more chaos with https://git.coopcloud.tech/toolshed/abra/pulls/728. I struggled to upgrade the dependencies recently due to docker upstream maintenance chaos 😬 Is there any way to create this patch somehow "locally" that it can be applied to the vendored modules? Otherwise, this creates a circle where we need to update your fork, then update our deps 👁️ Curious how you think we can manage this.
Author
Owner

@decentral1se I would also prefer a local gut patch but unfortunately this is not possible in go as far as I know.
I could move my fork to the toolshed org. Would that make it better?

@decentral1se I would also prefer a local gut patch but unfortunately this is not possible in go as far as I know. I could move my fork to the toolshed org. Would that make it better?
p4u1 added 1 commit 2026-02-13 09:07:51 +00:00
p4u1 force-pushed patch-docker-yolo from 3bcc08f99a to 0effca1dd5 2026-02-13 09:08:07 +00:00 Compare
p4u1 changed title from WIP fix: Allows multiple protocols on one port to fix: Allows multiple protocols on one port 2026-02-13 09:15:02 +00:00
Author
Owner

@decentral1se @ammaratef45 This is ready to go from my side. I added a docs pr to document the docker/cli fork

@decentral1se @ammaratef45 This is ready to go from my side. I added a docs pr to document the docker/cli fork
decentral1se approved these changes 2026-02-13 09:27:45 +00:00
decentral1se left a comment
Owner

I'm scared at the dependency puzzle maintenance acrobatics this can bring but let's do ittttt... thanks for the work @p4u1! all good on my side to merge it in then...

I'm scared at the dependency puzzle maintenance acrobatics this can bring but let's do ittttt... thanks for the work @p4u1! all good on my side to merge it in then...
decentral1se merged commit d60d426752 into main 2026-02-13 09:29:02 +00:00
decentral1se added this to the Abra v0.13 project 2026-02-15 13:49:29 +00:00
decentral1se moved this to Done in Abra v0.13 on 2026-02-15 13:49:33 +00:00
Sign in to join this conversation.
No description provided.