fix: Allows multiple protocols on one port #741
Reference in New Issue
Block a user
No description provided.
Delete Branch "p4u1/abra:patch-docker-yolo"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Docs PR: toolshed/docs.coopcloud.tech#297
3e98d8797fto0dc98051e7@decentral1se @ammaratef45 I added an integration test. What do you think? Shall we merge this? I can also clean up the test by not using my forkof the test recipe for it
@p4u1 I'm into it but I fear this might cause even more chaos with #728. I struggled to upgrade the dependencies recently due to docker upstream maintenance chaos 😬 Is there any way to create this patch somehow "locally" that it can be applied to the vendored modules? Otherwise, this creates a circle where we need to update your fork, then update our deps 👁️ Curious how you think we can manage this.
@decentral1se I would also prefer a local gut patch but unfortunately this is not possible in go as far as I know.
I could move my fork to the toolshed org. Would that make it better?
3bcc08f99ato0effca1dd5WIP fix: Allows multiple protocols on one portto fix: Allows multiple protocols on one port@decentral1se @ammaratef45 This is ready to go from my side. I added a docs pr to document the docker/cli fork
I'm scared at the dependency puzzle maintenance acrobatics this can bring but let's do ittttt... thanks for the work @p4u1! all good on my side to merge it in then...