WIP: feat: introduce local recipes #742
Draft
p4u1
wants to merge 3 commits from
p4u1/abra:local-recipes into main
pull from: p4u1/abra:local-recipes
merge into: :main
:main
:fix/492
:renovate/golang-1.26
:local-integration-testing
:renovate/github.com-charmbracelet-lipgloss-2.x
:renovate/otel-weaver-0.x
:renovate/codespell-2.x
:renovate/github.com-charmbracelet-bubbletea-2.x
:renovate/tonistiigi-xx-1.x
:renovate/alpine-3.x
:renovate/github.com-charmbracelet-log-2.x
:chore-deps
:fix/deps
:fix/613
Labels
Clear labels
bug
build
ci/cd
critical fix
design
documentation
duplicate
easy-first-issue
enhancement
help wanted
i10n
i18n
installer
invalid
question
release
release-candidate
security
tech-debt
test
wontfix
Something is not working
go build related issues
Building things with CI/CD
https://docs.coopcloud.tech/federation/resolutions/passed/010/
UI/UX
Documenting all the things
This issue or pull request already exists
Something for new people to get stuck into. We hope it's easy!
New feature
Need some help
Everything to do with localisation
Everything to do with internationalisation
Everything to do with the install script.
Something is wrong
More information is needed
Release management
Related to the new release candidate
Security related
Unit/integration testing
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
Apfelwurm
BornDeleuze
Brooke
carla
cas (Cassowary)
coopcloud
cyrnel
decentral1se (d1)
dede
devydave
fauno (fauno)
iexos
jade (Jade Ambrose)
jjsfunhouse
jmakdah2 (Jackie Makdah)
joe-irving (Joe Irving)
kawaiipunk (KawaiiPunk)
knoflook
kolaente
lambdabundesverband
linnealovespie (April)
moosemower
moritz
notplants
oxaliq (sorrel)
p4u1
pharaohgraphy (Andrew 🐦🔥❤️🔥✴️)
renovate-bot (Comrade Renovate Bot)
ripclap
simon
sixsmith (Sixsmith)
stevensting
trav (Trav Fryer)
val (val (he/him))
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: toolshed/abra#742
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Docs PR: toolshed/docs.coopcloud.tech#298
@decentral1se @ammaratef45 and others: what do you think about the general idea? If others like this, I can add integratoin tests
Thanks, sounds good to me! People have asked for it also several times.
What happens with a local recipe that doesn't exist in the catalogue? It would be good to write some integration tests indeed that don't just test the direct functionality but also how a local recipe behaves with all the usual commands (
abra app deploy,upgrade, etc.). It would be good to adjust some existing tests and make the recipe local and see what explodes.@@ -133,0 +128,4 @@sshURL := ""dir := ""local := falseif strings.HasPrefix(name, "./") {This needs a docs patch for https://docs.coopcloud.tech/maintainers/handbook/ to explain how you create a "local only" recipe. We have too often created features which go undiscovered for years 🙃 Docs might help avoid this...
@@ -133,0 +129,4 @@dir := ""local := falseif strings.HasPrefix(name, "./") {dir = path.Join(config.ABRA_DIR, name)we should also check if the local recipe dir exists.
The feature makes sense to me, unsure from reading the code but it seems like local recipes will use whatever exists in the directory, so it won't look for a release tag
I wonder if local recipes should also be expected to be a git directory but without the need for a remote (one can exist but abra won't need it)
wdyt?
I don't think local recipes should check for git repo. If you want your recipe to be a git repooutside of the recipe catalogue you can already reference that with the full hit URL
For me local recipes should be, just take the files and deploy whatever is there. The upgrade command would then be a no op
Will add documentation in the coming days
@ammaratef45 @decentral1se I have added documentation toolshed/docs.coopcloud.tech#298
Let's discuss and agree on the feature before I add tests and make abra behave well in all cases
Aight, re: toolshed/docs.coopcloud.tech#298 (comment) let's push this out to the next
abrarelease ✅WIP feat: introduce local recipesto WIP: feat: introduce local recipesView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.