WIP feat: introduce local recipes #742
Reference in New Issue
Block a user
No description provided.
Delete Branch "p4u1/abra:local-recipes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@decentral1se @ammaratef45 and others: what do you think about the general idea? If others like this, I can add integratoin tests
Thanks, sounds good to me! People have asked for it also several times.
What happens with a local recipe that doesn't exist in the catalogue? It would be good to write some integration tests indeed that don't just test the direct functionality but also how a local recipe behaves with all the usual commands (
abra app deploy,upgrade, etc.). It would be good to adjust some existing tests and make the recipe local and see what explodes.@ -133,0 +128,4 @@sshURL := ""dir := ""local := falseif strings.HasPrefix(name, "./") {This needs a docs patch for https://docs.coopcloud.tech/maintainers/handbook/ to explain how you create a "local only" recipe. We have too often created features which go undiscovered for years 🙃 Docs might help avoid this...
@ -133,0 +129,4 @@dir := ""local := falseif strings.HasPrefix(name, "./") {dir = path.Join(config.ABRA_DIR, name)we should also check if the local recipe dir exists.
The feature makes sense to me, unsure from reading the code but it seems like local recipes will use whatever exists in the directory, so it won't look for a release tag
I wonder if local recipes should also be expected to be a git directory but without the need for a remote (one can exist but abra won't need it)
wdyt?
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.