toolshed/abra
3
3
Fork 21
Code Issues 53 Pull Requests 1 Packages Releases 45 Activity

fix: remove client timeout #772

Merged
decentral1se merged 1 commits from fix/remove-timeout into main 2026-02-15 16:34:20 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -3
decentral1se commented 2026-02-15 16:29:56 +00:00
Owner
Copy Link

It's the only timeout I can find re: #748. Let's see if that helps (or bounces back with a new "forever hanging" bug 🙃)

The other timeout code in connhelper.go is only used once for abra server add so you don't get stuck forever when a server doesn't respond 👇

cli/server/add.go Lines 72 to 75 in 4349ee82bc
// NOTE(d1): reasonable 5 second timeout for connections which can't
// succeed. The connection is attempted twice, so this results in 10
// seconds.
timeout := client.WithTimeout(5)

It's the only timeout I can find re: https://git.coopcloud.tech/toolshed/abra/issues/748. Let's see if that helps (or bounces back with a new "forever hanging" bug 🙃) The other timeout code in `connhelper.go` is only used once for `abra server add` so you don't get stuck forever when a server doesn't respond 👇 https://git.coopcloud.tech/toolshed/abra/src/commit/4349ee82bc194f5f473f4152ba79be94bb816920/cli/server/add.go#L72-L75
decentral1se added 1 commit 2026-02-15 16:29:57 +00:00
fix: remove timeout
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
10803b8bd0
decentral1se merged commit 5cfc1c076c into main 2026-02-15 16:34:20 +00:00
decentral1se deleted branch fix/remove-timeout 2026-02-15 16:34:20 +00:00
decentral1se added this to the Abra v0.13 project 2026-02-15 16:34:25 +00:00
decentral1se moved this to Done in Abra v0.13 on 2026-02-15 16:34:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
tech-debt
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra v0.13
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith stevensting trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#772
No description provided.
Delete Branch "fix/remove-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?