Allow digests in docker images #957

2026-10-22T19:33:08Z

ineiti commented

2026-10-22 19:33:08 +00:00

For the nextcloud update we need to be able to indicate the digest of the docker image, as the docker tag is the same for the vulnerable and the fixed docker image.
We did push a new abra version of the nextcloud recipe with the same docker tag, which normally should work. But: if the connection to docker hub fails during the abra upgrade, it will print a warning and still run the old image!

Following https://git.coopcloud.tech/c4dt/ai-policy/src/branch/main/AI-POLICY.md

#LLM_vibe Claude Opus 5.5

I take full responsibility for this code
I understand every line of this code
I tested this code thoroughly on my own computer / servers
None of the commit messages were created using LLMs
I will participate in any discussion on my own and will not use an LLM for the discussion

For the nextcloud update we need to be able to indicate the digest of the docker image, as the docker tag is the same for the vulnerable and the fixed docker image. We did push a new abra version of the nextcloud recipe with the same docker tag, which _normally_ should work. But: if the connection to docker hub fails during the `abra upgrade`, it will print a warning and still run the old image! Following https://git.coopcloud.tech/c4dt/ai-policy/src/branch/main/AI-POLICY.md #LLM_vibe Claude Opus 5.5 - [x] I take full responsibility for this code - [x] I understand every line of this code - [x] I tested this code thoroughly on my own computer / servers - [x] None of the commit messages were created using LLMs - [x] I will participate in any discussion on my own and will not use an LLM for the discussion

ineiti added 1 commit 2026-10-22 19:33:11 +00:00

Allow digests in docker images

continuous-integration/drone/pr Build is passing

Details

8a81dedf3b

For the nextcloud update we need to be able to indicate the
digest of the docker image, as the docker tag is the same
for the vulnerable and the fixed docker image.
This avoids 'abra update' to re-install with a warning an
old image if the connection to docker hub fails.

ineiti marked the pull request as work in progress 2026-10-22 19:33:32 +00:00

ineiti marked the pull request as ready for review 2026-10-22 19:50:20 +00:00

p4u1 commented

2026-10-22 20:57:40 +00:00

Did you take a look at #916 ?

Did you take a look at https://git.coopcloud.tech/toolshed/abra/pulls/916 ?

ineiti commented

2026-10-23 06:25:39 +00:00

No, I didn't - thanks! That looks more complete than this PR. I wrote it mainly as a reaction to the PHP fixes and nextcloud releasing the fix with the same tag...

I'll close this and have a look at #916.

No, I didn't - thanks! That looks more complete than this PR. I wrote it mainly as a reaction to the PHP fixes and nextcloud releasing the fix with the same tag... I'll close this and have a look at #916.

ineiti closed this pull request

2026-10-23 06:25:40 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#957

Allow edits from maintainers