fix: prevent localized values from breaking app list #963

2026-11-11T16:52:21Z

ChasquiLabo commented

2026-11-11 16:52:21 +00:00

First-time contributor

Summary

Fixes #817 by preventing translated values such as unknown and latest from interfering with the internal logic of abra app ls --status.

Changes

The original implementation used i18n.G("unknown") to initialize internal variables. In Spanish, this returned desconocido, causing comparisons and strconv.ParseBool() to fail.
We decided to keep technical values untranslated and apply translations only when presenting information to users.

Keep unknown and latest as internal values.
Translate these values only when displaying tables.
Preserve untranslated values in machine-readable JSON output.

Testing

Tested with Docker Swarm on Ubuntu 26.04 using Spanish (es_AR.UTF-8).

Reproduced the original strconv.ParseBool error.
Verified that the patched version displays desconocido correctly.
Tested deployed and undeployed applications, including chaos=true and chaos=false.
Verified JSON output and ran Go tests successfully.

AI assistance

This fix was developed with the assistance of ChatGPT (LLM) for code analysis, implementation, and debugging. All changes were manually reviewed and tested in a dedicated development environment.

Fixes #817.

Summary Fixes #817 by preventing translated values such as `unknown` and `latest` from interfering with the internal logic of `abra app ls --status`. Changes The original implementation used i18n.G("unknown") to initialize internal variables. In Spanish, this returned desconocido, causing comparisons and strconv.ParseBool() to fail. We decided to keep technical values untranslated and apply translations only when presenting information to users. - Keep `unknown` and `latest` as internal values. - Translate these values only when displaying tables. - Preserve untranslated values in machine-readable JSON output. Testing Tested with Docker Swarm on Ubuntu 26.04 using Spanish (`es_AR.UTF-8`). - Reproduced the original `strconv.ParseBool` error. - Verified that the patched version displays `desconocido` correctly. - Tested deployed and undeployed applications, including `chaos=true` and `chaos=false`. - Verified JSON output and ran Go tests successfully. AI assistance This fix was developed with the assistance of ChatGPT (LLM) for code analysis, implementation, and debugging. All changes were manually reviewed and tested in a dedicated development environment. Fixes #817.

ChasquiLabo added 1 commit 2026-11-11 16:52:24 +00:00

fix(app): prevent localized values from breaking app list

continuous-integration/drone/pr Build is failing

Details

162cbc3bd2

decentral1se commented

2026-11-11 20:53:42 +00:00

Same #964 (comment).

Same https://git.coopcloud.tech/toolshed/abra/pulls/964#issuecomment-46440.

Some required checks failed

continuous-integration/drone/pr Build is failing

Details

You are not authorized to merge this pull request.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u https://git.coopcloud.tech/escuela-comun/abra fix/817-list-i18n:escuela-comun-fix/817-list-i18n

git checkout escuela-comun-fix/817-list-i18n

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#963

Allow edits from maintainers