Add a debug message when client closes websocket attach connection
When the client closes websocket connections that sends container output through websocket, an error message is displayed: "Error attaching websocket: %!s(<nil>)" This message is misleading. Thus, this change suggests to check if error is nil and print the correct message accordingly. Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com> Upstream-commit: 8f65bb6d90e3a95420bb634e415c3cce36d86201 Component: engine
This commit is contained in:
@@ -593,7 +593,11 @@ func (s *containerRouter) wsContainersAttach(ctx context.Context, w http.Respons
|
||||
close(done)
|
||||
select {
|
||||
case <-started:
|
||||
logrus.Errorf("Error attaching websocket: %s", err)
|
||||
if err != nil {
|
||||
logrus.Errorf("Error attaching websocket: %s", err)
|
||||
} else {
|
||||
logrus.Debug("websocket connection was closed by client")
|
||||
}
|
||||
return nil
|
||||
default:
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user