Fix plugin remove dir name after rename.
Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 4bf263c19873718394f8161dbc020bf4be30f9d6) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
This commit is contained in:
@@ -637,11 +637,12 @@ func (pm *Manager) Remove(name string, config *types.PluginRmConfig) error {
|
||||
return errors.Wrap(err, "error unmounting plugin data")
|
||||
}
|
||||
|
||||
if err := os.Rename(pluginDir, pluginDir+"-removing"); err != nil {
|
||||
removeDir := pluginDir + "-removing"
|
||||
if err := os.Rename(pluginDir, removeDir); err != nil {
|
||||
return errors.Wrap(err, "error performing atomic remove of plugin dir")
|
||||
}
|
||||
|
||||
if err := system.EnsureRemoveAll(pluginDir); err != nil {
|
||||
if err := system.EnsureRemoveAll(removeDir); err != nil {
|
||||
return errors.Wrap(err, "error removing plugin dir")
|
||||
}
|
||||
pm.config.Store.Remove(p)
|
||||
|
||||
Reference in New Issue
Block a user