Synchronize the cursor returned by followJournal

Make sure that the cursor value returned by followJournal() is the last
of the values returned by its goroutine's calls to drainJournal() by
waiting for it, rather than returning a value that may be superceded by
another if we're singalling the goroutine that it should exit by closing
a pipe.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Upstream-commit: d57c330617efb97cad736a3e4ede82bb46ebbbf2
Component: engine
This commit is contained in:
Nalin Dahyabhai
2017-02-22 16:22:00 -05:00
parent 79d868fec9
commit 53075c0a1f
@@ -246,6 +246,8 @@ func (s *journald) followJournal(logWatcher *logger.LogWatcher, config logger.Re
s.readers.readers[logWatcher] = logWatcher
s.readers.mu.Unlock()
newCursor := make(chan *C.char)
go func() {
for {
// Keep copying journal data out until we're notified to stop
@@ -274,6 +276,7 @@ func (s *journald) followJournal(logWatcher *logger.LogWatcher, config logger.Re
s.readers.mu.Unlock()
C.sd_journal_close(j)
close(logWatcher.Msg)
newCursor <- cursor
}()
// Wait until we're told to stop.
@@ -283,6 +286,8 @@ func (s *journald) followJournal(logWatcher *logger.LogWatcher, config logger.Re
C.close(pfd[1])
}
cursor = <-newCursor
return cursor
}