more review updates

Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
Upstream-commit: eff36b7d669a8d0dbb9d79b70f9cb1f8a6ffdbd8
Component: engine

components/engine/api/types/swarm/secret.go

@@ -11,11 +11,13 @@ type Secret struct {
 	SecretSize int64
 }
 
+// SecretSpec represents a secret specification from a secret in swarm
 type SecretSpec struct {
 	Annotations
 	Data []byte
 }
 
+// SecretReferenceFileTarget is a file target in a secret reference
 type SecretReferenceFileTarget struct {
 	Name string
 	UID  string
@@ -23,6 +25,7 @@ type SecretReferenceFileTarget struct {
 	Mode os.FileMode
 }
 
+// SecretReference is a reference to a secret in swarm
 type SecretReference struct {
 	SecretID   string
 	SecretName string

components/engine/daemon/cluster/executor/container/adapter.go

@@ -223,7 +223,7 @@ func (c *containerAdapter) create(ctx context.Context) error {
 		return fmt.Errorf("unable to get container from task spec")
 	}
 	secrets := make([]*containertypes.ContainerSecret, 0, len(container.Secrets))
-	for _, s := range c.container.task.Spec.GetContainer().Secrets {
+	for _, s := range container.Secrets {
 		sec := c.secrets.Get(s.SecretID)
 		if sec == nil {
 			logrus.Warnf("unable to get secret %s from provider", s.SecretID)