Fix race in setting plugin refcounts.

Signed-off-by: Anusha Ragunathan <anusha@docker.com>
Upstream-commit: 4c088d1e2ebfcc384a365734017988f4fd1c4605
Component: engine

components/engine/plugin/store/store.go

@@ -174,7 +174,7 @@ func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlug
 		}
 		p, err = ps.GetByName(fullName)
 		if err == nil {
-			p.SetRefCount(mode + p.GetRefCount())
+			p.AddRefCount(mode)
 			if p.IsEnabled() {
 				return p.FilterByCap(capability)
 			}

components/engine/plugin/v2/plugin.go

@@ -278,12 +278,12 @@ func (p *Plugin) GetRefCount() int {
 	return p.refCount
 }
 
-// SetRefCount sets the reference count.
-func (p *Plugin) SetRefCount(count int) {
+// AddRefCount adds to reference count.
+func (p *Plugin) AddRefCount(count int) {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 
-	p.refCount = count
+	p.refCount += count
 }
 
 // InitSpec creates an OCI spec from the plugin's config.