Merge pull request #31207 from duglin/BuildArgDocs

Add even more docs around BuildArgs and *string
Upstream-commit: aef8aa565f471eeed64eb6f25e15b3ac634048a3
Component: engine
This commit is contained in:
Vincent Demeester
2017-02-21 09:46:31 +01:00
committed by GitHub
+4 -3
View File
@@ -160,9 +160,10 @@ type ImageBuildOptions struct {
ShmSize int64
Dockerfile string
Ulimits []*units.Ulimit
// See the parsing of buildArgs in api/server/router/build/build_routes.go
// for an explanation of why BuildArgs needs to use *string instead of
// just a string
// BuildArgs needs to be a *string instead of just a string so that
// we can tell the difference between "" (empty string) and no value
// at all (nil). See the parsing of buildArgs in
// api/server/router/build/build_routes.go for even more info.
BuildArgs map[string]*string
AuthConfigs map[string]AuthConfig
Context io.Reader