Fix incorrect assumption in TestAPISwarmRaftQuorum
This test shuts down two out of three managers and then asserts that the swarm has a leader. A swarm that lost quorum won't necessarily have a leader, and in this case only has one because the old leader is still around. Soon SwarmKit will be changed so the leader gives up leadership when quorum is lost. This will avoid confusing situations, like read-only APIs succeeding, while ones that write to Raft hang. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> Upstream-commit: c27603238c5493909ec9b657b342b67b23e615e3 Component: engine
This commit is contained in:
@@ -350,9 +350,6 @@ func (s *DockerSwarmSuite) TestAPISwarmRaftQuorum(c *check.C) {
|
||||
|
||||
d3.Stop(c)
|
||||
|
||||
// make sure there is a leader
|
||||
waitAndAssert(c, defaultReconciliationTimeout, d1.CheckLeader, checker.IsNil)
|
||||
|
||||
var service swarm.Service
|
||||
simpleTestService(&service)
|
||||
service.Spec.Name = "top2"
|
||||
|
||||
Reference in New Issue
Block a user