toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugins: do not try to contact disabled plugin

Browse Source 
Signed-off-by: Tibor Vass <tibor@docker.com>
Upstream-commit: 84e58e2f89b3dea30738f92edcabef4336d0cff6
Component: engine
This commit is contained in:
Tibor Vass
2016-11-21 14:52:14 -08:00
parent 4ae83fca35
commit f460bac81d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/engine/plugin/store/store.go
+8 -3
View File
@@ -126,7 +126,7 @@ func (ps *Store) updatePluginDB() error {
return nil
}
// Get returns a plugin matching the given name and capability.
// Get returns an enabled plugin matching the given name and capability.
func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlugin, error) {
var (
p *v2.Plugin
@@ -151,7 +151,12 @@ func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlug
p.Lock()
p.RefCount += mode
p.Unlock()
return p.FilterByCap(capability)
if p.IsEnabled() {
return p.FilterByCap(capability)
}
// Plugin was found but it is disabled, so we should not fall back to legacy plugins
// but we should error out right away
return nil, ErrNotFound(fullName)
}
if _, ok := err.(ErrNotFound); !ok {
return nil, err
@@ -170,7 +175,7 @@ func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlug
return nil, err
}
// GetAllByCap returns a list of plugins matching the given capability.
// GetAllByCap returns a list of enabled plugins matching the given capability.
func (ps *Store) GetAllByCap(capability string) ([]plugingetter.CompatPlugin, error) {
result := make([]plugingetter.CompatPlugin, 0, 1)