toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
10,148 Commits 3 Branches 295 Tags
30e9abbd3f78d2df1ffd0163fd6eb2a9e4fbbe11
Commit Graph
10148 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Laura BrehmandGitHub 30e9abbd3f Merge pull request #5492 from thaJeztah/completion_unit_tests 
cli/command/container: add unit tests for completion helpers
 2024-10-02 15:52:14 +01:00
Sebastiaan van Stijn d49e72c0ac cli/command/container: add unit tests for completion helpers 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-10-02 10:38:25 +02:00
Sebastiaan van StijnandGitHub ccb3b44fe3 Merge pull request #5480 from thaJeztah/moby_sys_capability 
cli/container: use github.com/moby/sys/capability for completions
 2024-10-01 15:08:46 +02:00
Sebastiaan van Stijn 462e08219d cli/container: use github.com/moby/sys/capability for completions 
We used a hard-coded list of capabilities that we copied from containerd,
but the new "capability" package allows use to have a maintained list
of capabilities.

There's likely still some improvements to be made;

First of all, the capability package could provide a function to get the list
of strings.

On the completion-side, we need to consider what format is most convenient;
currently we use the canonical name (uppercase and "CAP_" prefix), however,
tab-completion is case-sensitive by default, so requires the user to type
uppercase letters to filter the list of options.

Bash completion provides a `completion-ignore-case on` option to make completion
case-insensitive (https://askubuntu.com/a/87066), but it looks to be a global
option; the current cobra.CompletionOptions also don't provide this as an option
to be used in the generated completion-script.

Fish completion has `smartcase` (by default?) which matches any case if
all of the input is lowercase.

Zsh does not have a dedicated option, but allows setting matching-rules
(see https://superuser.com/a/1092328).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-10-01 14:01:02 +02:00
Sebastiaan van StijnandGitHub f4fab2c7f3 Merge pull request #5488 from thaJeztah/align_errs 
align "conflicting options" errors for consistency
 2024-10-01 13:05:55 +02:00
Sebastiaan van Stijn bd96bdaf1b align "conflicting options" errors for consistency 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-10-01 12:08:56 +02:00
Sebastiaan van StijnandGitHub 3907414549 Merge pull request #5485 from thaJeztah/time_or_timeout 
cli/command/container: stop, restart: rename "--time" to "--timeout"
 2024-09-30 13:06:29 +02:00
Sebastiaan van Stijn df8b34595b cli/command/container: stop, restart: rename "--time" to "--timeout" 
This renames the `--time` flag as used on `docker stop` and `docker restart`
to `--timeout`,  bringing it in line with other uses for this property,
such as `--stop-timeout` on `docker run`.

The `--time` option is deprecated and hidden, but will be kept for
backward compatibility, as these options existed for a long time.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-30 09:43:54 +02:00
Sebastiaan van StijnandGitHub b1ae218f60 Merge pull request #5484 from thaJeztah/stop_restart_flag_descriptions 
docs/reference: stop, restart: add flag descriptions
 2024-09-27 12:24:24 +02:00
Sebastiaan van Stijn 6075303483 docs/reference: stop, restart: add flag descriptions 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-27 10:18:55 +02:00
Sebastiaan van StijnandGitHub c767b9b2da Merge pull request #5483 from robmry/ip-range-validation 
Check that --ip-range is a CIDR address
 2024-09-26 22:49:12 +02:00
Rob Murray 8fca0a1f28 Check that --ip-range is a CIDR address 
Signed-off-by: Rob Murray <rob.murray@docker.com>
 2024-09-26 20:38:33 +01:00
Sebastiaan van StijnandGitHub daabb1533e Merge pull request #5482 from thaJeztah/restart_stop_unit_tests 
cli/command/container: add unit tests for container restart and container stop
 2024-09-26 20:06:48 +02:00
Sebastiaan van Stijn ac502b5909 cli/command/container: add unit tests for container stop 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-26 18:58:40 +02:00
Sebastiaan van Stijn 16aa994255 cli/command/container: add unit tests for container restart 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-26 18:57:27 +02:00
Sebastiaan van StijnandGitHub bae4b67c24 Merge pull request #5481 from dvdksn/fix-container-run-typo 
docs: fix a typo in run.md
 2024-09-26 15:39:20 +02:00
David Karlsson 54a20ce54c docs: fix a typo in run.md 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-09-26 15:33:09 +02:00
Laura BrehmandGitHub 3a3fe840ed Merge pull request #5428 from thaJeztah/bump_docker_28 
vendor: github.com/docker/docker 164cae56ed95 (master, v-next)
 2024-09-24 15:53:30 +01:00
Sebastiaan van StijnandPaweł Gronowski b12ac897fb vendor: github.com/docker/docker 164cae56ed95 (master, v-next) 
full diff: https://github.com/docker/docker/compare/2269acc7a31d...164cae56ed95d1fcbedae7cd3aebaff375d18272

Co-authored-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-24 16:30:30 +02:00
Laura BrehmandGitHub ff853c42a5 Merge pull request #5454 from thaJeztah/touchup_codeql 
gha: codeql: minor touch-ups and fixes
 2024-09-24 12:03:11 +01:00
Sebastiaan van StijnandGitHub 56d0af783c Merge pull request #5474 from docker/change_to_inuse 
Images Tree: Change 'Used' to 'In Use'
 2024-09-24 10:37:17 +02:00
Sebastiaan van StijnandGitHub 97a6bf3580 Merge pull request #5473 from rumpl/no-underline 
Do not underline image name
 2024-09-23 21:02:51 +02:00
Brian Goff df52ddcfcc Images Tree: Change 'Used' to 'In Use' 
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
 2024-09-23 11:26:42 -07:00
Djordje Lukic 17040890e4 Do not underline image name 
Blue text with underline looks too much as a hyperlink I can click on

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
 2024-09-23 15:36:18 +02:00
Sebastiaan van StijnandGitHub 9d478be4a8 Merge pull request #5468 from akerouanton/fix-ps-ipv6 
cli/formatter: fix unbracketed IPv6 addrs
 2024-09-23 15:31:02 +02:00
Laura BrehmandGitHub 66977d48e9 Merge pull request #5471 from dvdksn/fix-docker-login-anchorlink 
docs: fix anchor link to web-based login section
 2024-09-23 14:16:42 +01:00
David Karlsson 465e87afc7 docs: fix anchor link to web-based login section 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-09-23 13:48:33 +02:00
Albin Kerouanton 3e271461e6 cli/formatter: fix unbracketed IPv6 addrs 
Commit 964155cd tried to enclose all IPv6 addresses within brackets but
missed some cases. This commit fixes that, and adds a few test cases.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
 2024-09-23 12:17:24 +02:00
Laura BrehmandGitHub baa7a9f7ad Merge pull request #5460 from laurazard/master-update-VERSION 2024-09-20 11:48:05 +01:00
Laura Brehm 91c90a9797 Update VERSION file to v27.3.1-dev 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-09-20 11:41:30 +01:00
Sebastiaan van StijnandGitHub 9b4daca9f2 Merge pull request #5459 from thaJeztah/bump_compose 
Dockerfile: update compose to v2.29.7
 2024-09-20 12:38:14 +02:00
Sebastiaan van Stijn ce26ebc0e9 Dockerfile: update compose to v2.29.7 
Update the compose cli plugin used in the dev-container

full diff: https://github.com/docker/compose/compare/v2.29.4...v2.29.7

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-20 12:22:39 +02:00
Sebastiaan van StijnandGitHub 48cfe2137c Merge pull request #5456 from laurazard/fix-defer-mp-shutdown 
telemetry: fix early meterprovider shutdown
 2024-09-20 02:41:45 +02:00
Laura Brehm 1355d7e9f8 telemetry: fix early meterprovider shutdown 
In 4b5a196fee, we changed the CLI global
meter provider shutdown in order to handle any error returned by the
metric export.

Unfortunately, we dropped a `defer` during the fix, which
causes the meter provider to be immediately shutdown after being created
and metrics to not be collected/exporter.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-09-20 01:29:19 +01:00
Sebastiaan van Stijn f468606163 gha: codeql: minor touch-ups and fixes 
- remove trailing whitespace
- pin to a versioned ubuntu version
- adjust timeout to be more within expected duration
- remove redundant git checkout, which is no longer needed

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-19 11:09:51 +02:00
Sebastiaan van StijnandGitHub a5fb752ecf Merge pull request #5445 from jsternberg/lowercase-windows-drive 
command: change drive to lowercase for wsl path
 2024-09-18 12:15:45 +02:00
Laura BrehmandGitHub 4e64c59d64 Merge pull request #5446 from thaJeztah/codeql_updates 
gha: update codeql workflow to go1.22.7
 2024-09-18 11:04:32 +01:00
Jonathan A. SternbergandLaura Brehm 3472bbc28a command: change drive to lowercase for wsl path 
On Windows, the drive casing doesn't matter outside of WSL. For WSL, the
drives are lowercase. When we're producing a WSL path, lowercase the
drive letter.

Co-authored-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Co-authored-by: Laura Brehm <laurabrehm@hey.com>

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-09-18 10:59:08 +01:00
Laura BrehmandGitHub 649e564ee0 Merge pull request #5444 from jsternberg/handle-otel-errors 
telemetry: pass otel errors to the otel handler for shutdown and force flush
 2024-09-18 10:39:55 +01:00
Sebastiaan van Stijn e1213edcc6 gha: update codeql workflow to go1.22.7 
commit d7d56599ca updated this
repository to go1.22, but the codeql action didn't specify a
patch version, and was missed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-17 21:39:56 +02:00
Jonathan A. Sternberg b1956f5073 telemetry: pass otel errors to the otel handler for shutdown and force flush 
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
 2024-09-17 10:47:04 -05:00
Sebastiaan van StijnandGitHub a4619f3676 Merge pull request #5435 from juliogarciape/docs-fix-container-run 
Docs: Fix --rm=false flag in container_run.md
 2024-09-16 15:17:06 +02:00
Sebastiaan van StijnandGitHub 539a92baca Merge pull request #5441 from thaJeztah/bump_buildx_compose 
Dockerfile: update buildx to v0.17.1, compose to v2.29.4
 2024-09-16 15:15:09 +02:00
Sebastiaan van Stijn f7a513cff0 Dockerfile: update compose to v2.29.4 
Update the compose cli plugin used in the dev-container

full diff: https://github.com/docker/compose/compare/v2.29.0...v2.29.4

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-16 15:03:15 +02:00
Sebastiaan van Stijn 42ce06aa5b Dockerfile: update buildx to v0.17.1 
Update the buildx cli plugin used in the dev-container

full diff: https://github.com/docker/buildx/compare/0.16.1...0.17.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-16 15:01:56 +02:00
Laura BrehmandGitHub 7b630458bd Merge pull request #5437 from thaJeztah/remove_deprecated_cors_headers 
docs, man: dockerd: remove --api-cors-header (deprecated)
 2024-09-16 13:42:01 +01:00
Sebastiaan van StijnandGitHub ccc87eb6ab Merge pull request #5438 from thaJeztah/dockerd_logformat 
docs, man: dockerd: add documentation for "--log-format" option
 2024-09-16 13:44:19 +02:00
Sebastiaan van StijnandGitHub 4f78ffaa03 Merge pull request #5436 from thaJeztah/update_dockerd_docs 
docs: add documentation for dockerd --feature flag
 2024-09-16 13:43:57 +02:00
Sebastiaan van Stijn baceb4b158 docs: dockerd: add documentation for --log-format option 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-16 13:23:13 +02:00
Sebastiaan van Stijn a42ca1148d docs/reference: dockerd: add docs for --feature option 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-09-16 13:20:48 +02:00