12228 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Sebastiaan van Stijn	4d6fc331b9	Merge pull request #6704 from vvoland/list-fix ... image: Fix dangling image detection with graphdrivers	2025-12-12 13:25:44 +01:00
Paweł Gronowski	09a46645a0	image/tree: Add golden test ... Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-12 12:39:26 +01:00
Paweł Gronowski	0d88411f1b	image/tree: Remove --all flag check for untagged images in non-expanded view ... This reverts part of the logic introduced in 207bf52c27 which incorrectly gated untagged images behind the --all flag in non-expanded view. The original fix was addressing the wrong layer of the problem. The actual issue was that dangling images were being incorrectly passed to the tree code in the first place. This was properly fixed in 67f5e3413 which corrected the dangling image detection logic to properly filter them out before reaching the tree display code. Now that dangling images are correctly filtered upstream, untagged images that reach the tree view should be displayed regardless of the --all flag setting. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-12 11:22:47 +01:00
Paweł Gronowski	b315983898	image/tree: Fix width calculation for untagged images ... When calculating column widths for the tree view, untagged images weren't being properly accounted for in the width calculation. This caused layout issues when there were tagged images were shorter than the `<untagged>` string. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-12 11:18:27 +01:00
Paweł Gronowski	150a25b9ff	image/tree: Extract untagged image name to const ... Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-12 11:17:42 +01:00
Paweł Gronowski	67f5e3413b	image: Fix dangling image detection with graphdrivers ... The isDangling function was incorrectly identifying images as dangling when they had no RepoTags but had valid RepoDigests. This can occur when the graphdrivers are used instead of the containerd image store. An image should only be considered dangling if it has no RepoTags, regardless of whether it has RepoDigests. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-12 11:16:01 +01:00
Paweł Gronowski	d96b7869af	Merge pull request #6702 from thaJeztah/bump_compress ... vendor: github.com/klauspost/compress v1.18.2	2025-12-11 19:50:57 +00:00
Sebastiaan van Stijn	15de6ce8f7	vendor: github.com/klauspost/compress v1.18.2 ... full diff: https://github.com/klauspost/compress/compare/v1.18.0...v1.18.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-11 19:58:08 +01:00
Paweł Gronowski	815be4418f	Merge pull request #6701 from thaJeztah/bump_aec2 ... vendor: github.com/morikuni/aec v1.1.0	2025-12-11 18:14:44 +00:00
Sebastiaan van Stijn	ca0fb174cf	Merge pull request #6700 from thaJeztah/fix_validation ... docker run, create: don't swallow connection errors during validate	2025-12-11 18:12:13 +01:00
Sebastiaan van Stijn	5c406f5ee4	vendor: github.com/morikuni/aec v1.1.0 ... full diff: https://github.com/morikuni/aec/compare/v1.0.0...v1.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-11 17:30:12 +01:00
Sebastiaan van Stijn	a6335c4226	docker run, create: don't swallow connection errors during validate ... Some validation steps done by `docker create` (and `docker run`) are platform- specific, and need to know the daemon's OS. To get this information, the CLI.ServerInfo() method was used, which discards connection errors, resulting in an empty OS, which causes validation to fail with an "unknown server OS" error message. This patch changes it to use the Client.Ping so that we can error when failing to connect. We should look if we can reduce the platform-specific validation and parsing on the client-side, but at least this change should produce a more useful error. Before this patch: DOCKER_HOST=tcp://example.invalid docker run -it --rm --device=/dev/dri alpine docker: unknown server OS: Run 'docker run --help' for more information With this patch: DOCKER_HOST=tcp://example.invalid docker run -it --rm --device=/dev/dri alpine failed to connect to the docker API at tcp://example.invalid:2375: lookup example.invalid on 192.168.65.7:53: no such host Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-11 17:03:51 +01:00
Paweł Gronowski	91d44d6caf	Merge pull request #6697 from thaJeztah/migrate_yaml ... vendor: github.com/spf13/cobra v1.10.2, migrate to go.yaml.in/yaml/v3	2025-12-09 15:07:34 +00:00
Sebastiaan van Stijn	49021ad987	vendor: github.com/spf13/cobra v1.10.2, migrate to go.yaml.in/yaml/v3 ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-09 15:47:11 +01:00
Sebastiaan van Stijn	1a1a4fc478	Merge pull request #6685 from thaJeztah/less_nat ... remove some uses of go-connections/nat package	2025-12-05 11:06:55 +01:00
Sebastiaan van Stijn	6f75c0c8e2	add TODOs for replacing nat.ParsePortSpecs ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-04 22:07:01 +01:00
Sebastiaan van Stijn	9c10a9c9ac	opts/swarmopts: remove use of nat.ParsePortRange ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-04 22:06:57 +01:00
Paweł Gronowski	65cf8762d3	Merge pull request #6692 from thaJeztah/rm_FakeStore ... internal/test: remove unused FakeStore	2025-12-04 12:36:05 +00:00
Sebastiaan van Stijn	9dfe779abb	internal/test: remove unused FakeStore ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-04 00:18:33 +01:00
Sebastiaan van Stijn	dfa98d33ea	Merge pull request #6690 from thaJeztah/compose_file_completion ... add shell completion for "docker stack deploy --compose-file"	2025-12-03 11:47:52 +01:00
Sebastiaan van Stijn	c81e05eed8	add shell completion for "docker stack deploy --compose-file" ... With this patch: docker stack deploy -c<TAB> .codecov.yml contrib/ e2e/ pkg/ .git/ build/ debian/ experimental/ ... docker stack deploy -c contrib/otel/<TAB> compose.yaml otelcol.yaml prom.yaml Note that filtering for the file-extension only appears to be functional on bash, but not (currently) working on other shells (at least not on Fish). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-03 11:38:04 +01:00
Sebastiaan van Stijn	890dcca877	Merge pull request #6688 from vvoland/update-go ... update to go1.25.5 v29.1.2	2025-12-02 19:58:46 +01:00
Paweł Gronowski	d544885316	update to go1.25.5 ... These releases include 2 security fixes following the security policy: - crypto/x509: excessive resource consumption in printing error string for host certificate validation Within HostnameError.Error(), when constructing an error string, there is no limit to the number of hosts that will be printed out. Furthermore, the error string is constructed by repeated string concatenation, leading to quadratic runtime. Therefore, a certificate provided by a malicious actor can result in excessive resource consumption. HostnameError.Error() now limits the number of hosts and utilizes strings.Builder when constructing an error string. Thanks to Philippe Antoine (Catena cyber) for reporting this issue. This is CVE-2025-61729 and Go issue https://go.dev/issue/76445. - crypto/x509: excluded subdomain constraint does not restrict wildcard SANs An excluded subdomain constraint in a certificate chain does not restrict the usage of wildcard SANs in the leaf certificate. For example a constraint that excludes the subdomain test.example.com does not prevent a leaf certificate from claiming the SAN *.example.com. This is CVE-2025-61727 and Go issue https://go.dev/issue/76442. View the release notes for more information: https://go.dev/doc/devel/release#go1.25.5 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-12-02 18:03:18 +01:00
Paweł Gronowski	c197aa70ee	Merge pull request #6687 from thaJeztah/use_subtests ... opts/swarmopts: use sub-tests	2025-12-01 13:08:30 +00:00
Sebastiaan van Stijn	ba683d8df3	opts/swarmopts: use sub-tests ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-12-01 13:01:37 +01:00
Paweł Gronowski	0aedba58c2	Merge pull request #6669 from vvoland/29-norc ... gha/e2e: Switch to 29 from 29-rc v29.1.1	2025-11-28 12:26:43 +01:00
Paweł Gronowski	dd2be022c0	gha/e2e: Switch to rc and 29 latest ... Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-11-28 12:22:06 +01:00
Paweł Gronowski	360952c8d3	Merge pull request #6680 from thaJeztah/bump_modules ... vendor: github.com/moby/moby/client v0.2.1 v29.1.0	2025-11-27 17:36:37 +01:00
Sebastiaan van Stijn	8fc15eaf2c	Merge pull request #6579 from dvdksn/doc-daemon-buildc-example ... docs: update buildgc example config to use new buildkit v0.17 options	2025-11-27 17:35:32 +01:00
Sebastiaan van Stijn	1abfbf298c	vendor: github.com/moby/moby/client v0.2.1 ... full diff: https://github.com/moby/moby/compare/client/v0.1.0...v0.2.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 17:25:03 +01:00
David Karlsson	e0d30db115	docs: update buildgc example config to use new buildkit v0.17 options ... Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>	2025-11-27 16:24:42 +01:00
Paweł Gronowski	5691ade75a	Merge pull request #6682 from thaJeztah/bump_dct_deps ... cmd/docker-trust: update dependencies	2025-11-27 15:38:49 +01:00
Paweł Gronowski	848dcad809	Merge pull request #6681 from thaJeztah/bump_x_deps2 ... vendor: update various golang.org/x/xxx dependencies	2025-11-27 15:38:16 +01:00
Sebastiaan van Stijn	6a0099bc8a	cmd/docker-trust: bump golang.org/x/crypto v0.45.0 ... Hello gophers, We have tagged version v0.45.0 of golang.org/x/crypto in order to address two security issues. This version fixes a vulnerability in the golang.org/x/crypto/ssh package and a vulnerability in the golang.org/x/crypto/ssh/agent package which could cause programs to consume unbounded memory or panic respectively. SSH servers parsing GSSAPI authentication requests don't validate the number of mechanisms specified in the request, allowing an attacker to cause unbounded memory consumption. Thanks to Jakub Ciolek for reporting this issue. This is CVE-2025-58181 and Go issue https://go.dev/issue/76363. SSH Agent servers do not validate the size of messages when processing new identity requests, which may cause the program to panic if the message is malformed due to an out of bounds read. Thanks to Jakub Ciolek for reporting this issue. This is CVE-2025-47914 and Go issue https://go.dev/issue/76364. Cheers, Go Security team Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:38:30 +01:00
Sebastiaan van Stijn	c90166ffa6	cmd/docker-trust: update dependencies ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:37:10 +01:00
Sebastiaan van Stijn	ac5e886124	vendor: golang.org/x/net v0.47.0 ... full diff: https://github.com/golang/net/compare/v0.46.0...v0.47.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:28:29 +01:00
Sebastiaan van Stijn	3ec414638c	vendor: golang.org/x/term v0.37.0 ... full diff: https://github.com/golang/term/compare/v0.36.0...v0.37.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:27:21 +01:00
Sebastiaan van Stijn	616e93a0c2	vendor: golang.org/x/text v0.31.0 ... full diff: https://github.com/golang/text/compare/v0.30.0...v0.31.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:24:45 +01:00
Sebastiaan van Stijn	1202f8a642	vendor: golang.org/x/sync v0.18.0 ... full diff: https://github.com/golang/sync/compare/v0.17.0...v0.18.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:23:31 +01:00
Sebastiaan van Stijn	b67055c963	vendor: golang.org/x/sys v0.38.0 ... - cpu: add HPDS, LOR, PAN detection for arm64 - cpu: also use MRS instruction in getmmfr1 - cpu: use MRS instruction to read arm64 system registers - unix: add consts for ELF handling - unix: add SetMemPolicy and its mode/flag values - unix: add SizeofNhmsg and SizeofNexthopGrp - windows: add iphlpapi routing functions full diff: https://github.com/golang/sys/compare/v0.37.0...v0.38.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-27 14:22:32 +01:00
Sebastiaan van Stijn	eee3e3d015	Merge pull request #6671 from docker/dependabot/github_actions/actions/checkout-6 ... build(deps): bump actions/checkout from 5 to 6	2025-11-27 10:42:16 +01:00
Paweł Gronowski	3247a5aae3	Merge pull request #6675 from vvoland/img-list-noellipsis ... image/tree: Allow image names to overflow instead of truncating v29.0.4	2025-11-24 21:35:37 +00:00
Paweł Gronowski	4759615835	image/tree: Allow image names to overflow instead of truncating ... Users were experiencing poor UX when image names were truncated in the table output. Instead of cutting off long image names with ellipsis, the names now wrap to the next line to ensure full visibility. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>	2025-11-24 22:12:37 +01:00
dependabot[bot]	3099d4716c	build(deps): bump actions/checkout from 5 to 6 ... Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2025-11-21 08:04:55 +00:00
Paweł Gronowski	511dad69d0	Merge pull request #6667 from thaJeztah/use_format ... image ls: allow custom format in cli config v29.0.3	2025-11-20 16:31:07 +00:00
Paweł Gronowski	11f24b8458	Merge pull request #6668 from robmry/builttime-format ... docker version: restore top-level BuildTime to RFC3339Nano format	2025-11-20 16:21:40 +00:00
Sebastiaan van Stijn	d84396d4eb	image ls: allow custom format in cli config ... Setting a custom format in the cli cofig should still be supported, and not produce an error when specifying "--tree". Specifyihg both "--tree" and "--format" still produces an error, but we could consider allowing "json" format in a future update. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2025-11-20 16:20:33 +00:00
Rob Murray	6751cd1690	docker version: restore top-level BuildTime to RFC3339Nano ... Introduced by bff56f0 (cli/command/system: define struct for formatting version). In the "docker info" result, the Engine component's BuildTime should be in time.ANSIC format, but the top level BuildTime field should use time.RFC3339Nano. Signed-off-by: Rob Murray <rob.murray@docker.com>	2025-11-20 15:57:24 +00:00
Sebastiaan van Stijn	8108357bcb	Merge pull request #6662 from dvdksn/doc-update-http-proxy-link ... chore: update link/linktext to dockerd proxy config v29.0.2 v29.1.0-rc.1	2025-11-17 11:19:50 +01:00
David Karlsson	3a842587f9	chore: update link/linktext to dockerd proxy config ... Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>	2025-11-17 11:00:04 +01:00