Vincent Demeester
7b15b0b584
Merge pull request #23 from dnephin/fix-goimports-on-master
...
Fix goimports failure on master
Upstream-commit: b7d3dd4d41
2017-05-03 22:27:16 +02:00
Daniel Nephin
9afb137b84
Merge pull request #19 from dnephin/check-vendor
...
Check vendor
Upstream-commit: 328fa4b717
2017-05-03 16:01:56 -04:00
Daniel Nephin
d51e95efed
Fix goimports failure on master.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 36a7842089
2017-05-03 15:58:39 -04:00
Daniel Nephin
5f4fc55626
Merge pull request #13 from dnephin/cleanup-post-docker-stin
...
Small build client cleanup handling dockerfile from stdin
Upstream-commit: c202b4b987
2017-05-03 15:45:41 -04:00
Daniel Nephin
3ca812826a
Merge pull request #9 from gdevillele/pr-update-makefile
...
update Makefile
Upstream-commit: 589afd2f50
2017-05-03 15:43:26 -04:00
Vincent Demeester
df3bda7143
Merge pull request #20 from dnephin/more-lint
...
Add more lint checks
Upstream-commit: 9e413798bf
2017-05-03 20:53:30 +02:00
Gaetan de Villele
dfb4d9262a
define targets as “phony”, add comments, and mount docker.sock in dev target
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 7f7e842702
2017-05-03 11:14:06 -07:00
Daniel Nephin
9b62a84ca8
Add ineffassign linter.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: b86533c479
2017-05-02 17:57:46 -04:00
Daniel Nephin
dce23b177f
Add gocycle lint
...
Whitelist some existing offenders, and use a high limit for now.
This limit should decrese over time.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 08af0f28c5
2017-05-02 17:57:46 -04:00
Daniel Nephin
8315ceea29
Add deadcode linter.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 8f73a12f9b
2017-05-02 17:57:46 -04:00
Daniel Nephin
8b2d591082
Add goimports to linting
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 1378bf3dbe
2017-05-02 17:57:46 -04:00
Daniel Nephin
67b6e94f47
Enable golint
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 690ef8af79
2017-05-02 17:57:46 -04:00
Daniel Nephin
cc564a7692
Verify that vendored files are correct
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 31851fbe3c
2017-05-02 17:57:32 -04:00
Daniel Nephin
a91f6c4112
Merge pull request #18 from dnephin/add-linter
...
Add gometalinter to CI
Upstream-commit: 0a613971b9
2017-05-02 17:54:02 -04:00
Daniel Nephin
93938768a0
Add gometalinter to CI
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: e3f677794a
2017-05-02 17:15:56 -04:00
Gaetan
d9dd021654
Merge pull request #15 from gdevillele/pr-faster-build
...
improve speed of "go build" as well as "docker build"
Upstream-commit: 639764c00d
2017-04-28 13:08:39 -07:00
Daniel Nephin
cc473d040f
Move addDockerfileToBuildContext to the build package.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: a5044b4982
2017-04-28 15:11:36 -04:00
Daniel Nephin
f66cf98ef3
Extract dockerfile handling functions.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: b98e03d3b0
2017-04-28 15:11:36 -04:00
Daniel Nephin
e65709f0e3
Cleanup handling of the - for stdin
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 59983759c2
2017-04-28 15:11:36 -04:00
Gaetan
35669218fd
Merge pull request #7 from gdevillele/pr-fix-service-ls-filter
...
remove service runtime filter from client
Upstream-commit: f5c8a61c9b
2017-04-28 10:48:25 -07:00
Gaetan
0882299bad
Merge pull request #16 from gdevillele/pr-add-test-target
...
add “test” target to makefiles
Upstream-commit: 2075433f95
2017-04-28 10:47:51 -07:00
Gaetan de Villele
71e45d9207
add “test” target and make CI use it
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 4d4203f7fd
2017-04-27 15:57:35 -07:00
Gaetan de Villele
d9980d3397
remove service runtime filter from client
...
it’s moving to the server.
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 5aa70d68b3
2017-04-27 15:07:20 -07:00
Gaetan de Villele
11241e3a61
make go build and docker build operations faster
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 87449dbaa1
2017-04-27 15:06:57 -07:00
Gaetan
e082a7228d
Merge pull request #14 from gdevillele/pr-circle-ci
...
add CircleCI config file
Upstream-commit: e8d0ecdf7e
2017-04-27 14:58:58 -07:00
Gaetan de Villele
78926d2ac0
add circle ci config file
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 6b2a61a311
2017-04-27 14:24:28 -07:00
Gaetan
46ddd9d3d6
Merge pull request #10 from gdevillele/pr-ci-dockerfile
...
add Dockerfile for CI
Upstream-commit: 7e7df40930
2017-04-27 14:19:24 -07:00
Gaetan de Villele
93479d673b
add Dockerfile for CI
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: 9c3f1d9ae3
2017-04-27 13:36:29 -07:00
Daniel Nephin
e0163aef4b
Merge pull request #8 from tiborvass/fix-windows
...
windows: remove workaround for go#15286 and have compiling work on windows
Upstream-commit: 728060a7eb
2017-04-26 10:23:35 -04:00
Tibor Vass
8ef7f9b38c
windows: remove workaround for go#15286 and have compiling work on windows
...
Signed-off-by: Tibor Vass <tibor@docker.com >
Upstream-commit: 97a4da4cf1
2017-04-25 15:53:23 -07:00
Gaetan
8f4985c526
Merge pull request #3 from gdevillele/add-makefile
...
add Makefiles
Upstream-commit: b37ea22b1e
2017-04-25 09:58:40 -07:00
Gaetan de Villele
2c780f4003
add Makefiles and document their use in the README
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: fb413981d3
2017-04-25 09:57:06 -07:00
Gaetan
52ef86e5a9
Merge pull request #5 from gdevillele/add-gitignore
...
add gitignore file
Upstream-commit: 0f0b500cf3
2017-04-25 09:47:56 -07:00
Vincent Demeester
443e26b99c
Merge pull request #6 from aduermael/fix-path
...
fix docker/docker/cli path in comment
Upstream-commit: a01a35fb84
2017-04-25 09:33:17 +02:00
Adrien Duermael
a99e2613c0
fix docker/docker/cli path in comment
...
Signed-off-by: Adrien Duermael <adrien@duermael.com >
Upstream-commit: 763802b6a3
2017-04-24 11:31:08 -07:00
Daniel Nephin
4d8e68b211
Merge pull request #1 from dnephin/add-dockerfile
...
Add Dockerfile and fix vendor.conf
Upstream-commit: bbee80a62e
2017-04-21 13:19:54 -04:00
Gaetan de Villele
d6e6e95820
add gitignore file
...
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com >
Upstream-commit: acf4eab87b
2017-04-21 11:49:00 -05:00
Daniel Nephin
c0890fae22
Add a Dockerfile for building and testing.
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: b6cba06801
2017-04-18 19:12:24 -04:00
Daniel Nephin
dd0b499677
Update vendor.conf
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: 31c8672805
2017-04-18 18:35:14 -04:00
Daniel Nephin
01b8c0f13a
Add vendor
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 6686ada6a4
2017-04-17 18:12:58 -04:00
Daniel Nephin
82309a74cd
Update imports.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: 10641c2aae
2017-04-17 18:07:56 -04:00
Daniel Nephin
f68763d049
Add project files
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
Upstream-commit: f2559aa2e0
2017-04-17 17:49:33 -04:00
Daniel Nephin
0890ccc8cb
Import docker/docker/cmd/docker
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: cdd7bc516b
2017-04-17 17:44:40 -04:00
Daniel Nephin
27d281716f
Import docker/docker/client
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: e8a454d8a6
2017-04-17 17:41:20 -04:00
Daniel Nephin
b2d0c4c107
Import docker/docker/cli
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: 1630fc40f8
2017-04-17 17:40:59 -04:00
Daniel Nephin
87e2086595
init
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
Upstream-commit: 1302228707
2017-04-17 17:40:37 -04:00
Vincent Demeester
545fff51d9
Fix formatter unit test (moving to testify)
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
Upstream-commit: e5b7b7e87b
2017-04-17 17:32:52 +02:00
Daniel Nephin
337700e350
Merge pull request #32614 from aaronlehmann/testify
...
Remove pkg/testutil/assert in favor of testify
Upstream-commit: 31639e04ce
2017-04-17 11:07:08 -04:00
Sebastiaan van Stijn
17e2d9cef6
Merge pull request #30962 from TheHipbot/30431-implement-format-for-history-with-docs
...
30431 implement format for history with docs
Upstream-commit: 1d73df5fc2
2017-04-16 10:34:41 -07:00
Aaron Lehmann
9c185ed98a
Remove pkg/testutil/assert in favor of testify
...
I noticed that we're using a homegrown package for assertions. The
functions are extremely similar to testify, but with enough slight
differences to be confusing (for example, Equal takes its arguments in a
different order). We already vendor testify, and it's used in a few
places by tests.
I also found some problems with pkg/testutil/assert. For example, the
NotNil function seems to be broken. It checks the argument against
"nil", which only works for an interface. If you pass in a nil map or
slice, the equality check will fail.
In the interest of avoiding NIH, I'm proposing replacing
pkg/testutil/assert with testify. The test code looks almost the same,
but we avoid the confusion of having two similar but slightly different
assertion packages, and having to maintain our own package instead of
using a commonly-used one.
In the process, I found a few places where the tests should halt if an
assertion fails, so I've made those cases (that I noticed) use "require"
instead of "assert", and I've vendored the "require" package from
testify alongside the already-present "assert" package.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com >
Upstream-commit: 6029def4cb
2017-04-14 12:03:21 -07:00
Vincent Demeester
Daniel Nephin
Daniel Nephin
Gaetan de Villele
Tibor Vass
Adrien Duermael
Sebastiaan van Stijn
Aaron Lehmann