Sebastiaan van Stijn
b158181a1d
cli/command/images: runImages: use proper camel-case for dockerCLI
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-02-03 17:56:06 +01:00
Sebastiaan van Stijn
1328bb3381
cli/command/images: runImages: inline intermediate var
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-02-03 17:54:23 +01:00
Sebastiaan van Stijn
843951e84a
Merge pull request #4843 from docker/dependabot/github_actions/codecov/codecov-action-4
...
build(deps): Bump codecov/codecov-action from 3 to 4
2024-02-01 15:47:14 +01:00
dependabot[bot]
b123ce6526
build(deps): Bump codecov/codecov-action from 3 to 4
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-01 08:57:32 +00:00
David Karlsson
297704984b
Merge pull request #4396 from zliang-akamai/patch-1
...
Add Linode docker volume plugin
2024-01-31 12:55:31 +01:00
Sebastiaan van Stijn
d001ac4892
Merge pull request #4836 from thaJeztah/remove_dummy_circleci
...
Remove dummy circleci config
2024-01-30 17:46:03 +01:00
Sebastiaan van Stijn
1587b70ee7
Remove dummy circleci config
...
The 20.10 branch reached EOL, so we can probably remove this
one again.
This reverts commit a3d53e319f .
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-30 17:29:11 +01:00
Sebastiaan van Stijn
3865da2bc8
Merge pull request #4828 from laurazard/plugin-socket-tests
...
Add tests for CLI/plugin communication (i.e. let's not break everyone's plugins 🥲 )
2024-01-29 14:46:25 +01:00
Laura Brehm
cfa9fef77d
tests: add plugin-socket-compatibility tests
...
Adds a new plugin to the e2e plugins that simulates an older
plugin binary and a test suite to ensure older plugin binaries
keep behaving the same with newer CLI versions.
Signed-off-by: Laura Brehm <laurabrehm@hey.com >
2024-01-29 13:39:58 +00:00
Sebastiaan van Stijn
6dcf285ff1
Merge pull request #4834 from thaJeztah/flags_dont_varp
...
cli/command: don't use pflags.XXXVarP for flags without shorthand
2024-01-29 12:26:08 +01:00
Sebastiaan van Stijn
dfdff11a22
cli/command: don't use pflags.XXXVarP for flags without shorthand
...
Use the `XXXVar` equivalent for flags that don't have a shorthand flag
instead of passing an empty string for the shorthand flag.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-29 11:16:38 +01:00
Sebastiaan van Stijn
abf8cff233
Merge pull request #4832 from thaJeztah/docker_attach_fixups
...
cli/command/container: minor cleanup in attach
2024-01-26 16:45:59 +01:00
Paweł Gronowski
0ef5e95481
Merge pull request #4831 from thaJeztah/bump_compose
...
Dockerfile: update docker compose to v2.24.3
2024-01-26 16:19:38 +01:00
Sebastiaan van Stijn
690f63e6d3
cli/command/container: minor cleanup in attach
...
- rename confusing `target` argument, and use `containerID` in all places;
also make the variable more clearly local-scoped.
- rename `dockerCli` to be correctly camel-case, and to be consistent in
all places in this file.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-26 13:38:09 +01:00
Sebastiaan van Stijn
53e2e54c29
Dockerfile: update docker compose to v2.24.3
...
Update the version of compose used in CI to the latest version.
- full diff: https://github.com/docker/compose/compare/v2.24.2...v2.24.3
- release notes: https://github.com/docker/compose/releases/tag/v2.24.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-26 11:06:44 +01:00
Laura Brehm
1c4d6d85dd
scripts: don't hardcode architecture in e2e script
...
Signed-off-by: Laura Brehm <laurabrehm@hey.com >
2024-01-25 15:37:17 +00:00
Sebastiaan van Stijn
a1bd689a4d
Merge pull request #4821 from vvoland/vendor-v26.0.0-43ffb1ee9d5a
...
vendor: github.com/docker/docker 43ffb1ee9d5a (v26.0.0-dev)
2024-01-24 15:06:06 +01:00
Paweł Gronowski
4fa2fe9b9e
Replace deprecated types.Image* usage
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com >
2024-01-24 14:59:10 +01:00
Paweł Gronowski
68dac842a1
vendor: github.com/docker/docker 43ffb1ee9d5a (v26.0.0-dev)
...
full diff: https://github.com/docker/docker/compare/v25.0.0...43ffb1ee9d5a
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com >
2024-01-24 14:59:08 +01:00
Sebastiaan van Stijn
bb1cb4992c
Merge pull request #4820 from thaJeztah/bump_engine_25.0.1
...
vendor: github.com/docker/docker v25.0.1
2024-01-24 14:57:12 +01:00
Sebastiaan van Stijn
9e2615bc46
Merge pull request #4809 from thaJeztah/remove_printSecurityOptionsWarnings
...
info: remove printSecurityOptionsWarnings, printServerWarnings
2024-01-24 12:36:19 +01:00
Sebastiaan van Stijn
4b1ed1f442
vendor: github.com/docker/docker v25.0.1
...
relevant changes:
- Fix isGitURL regular expression
- pkg/system: return even richer xattr errors
full diff: https://github.com/moby/moby/compare/v25.0.0...v25.0.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-24 12:17:20 +01:00
Sebastiaan van Stijn
d9294f06b5
info: remove printSecurityOptionsWarnings, printServerWarnings
...
Docker Engine 1.13 (API v1.25) added an option to set a custom default seccomp
profile on the daemon (see [moby/moby@b237189 ]). A warning was added on the
client-side if a non-default profile was set.
Docker Engine 23.0 (API v1.42) added warnings about non-default seccomp
profiles to the "info" response ([moby/moby@04f932a ]), and the client was
updated to skip generating client-side warnings for API v1.42 and up in
[docker/cli@8964595 ].
These warnings are purely informational, and given that Docker Engine versions
before 23.0 have reached EOL, and any current version of the Engine now returns
the Warnings, it should be safe to remove the client-side fall back logic.
This patch removes the client-side fall back code for warnings that was
added in 8964595692 .
[moby/moby@b237189 ]: https://github.com/moby/moby/commit/b237189e6c8a4f97be59f08c63cdcb1f2f4680a8
[moby/moby@04f932a ]: https://github.com/moby/moby/commit/04f932ac862c05a5af2a5950b5e1744100b14eea
[docker/cli@8964595 ]: https://github.com/docker/cli/commit/8964595692766444fb84445931889677af5f55eb
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-23 18:23:35 +01:00
Sebastiaan van Stijn
c6ae74956c
Merge pull request #4808 from thaJeztah/remove_printServerWarningsLegacy
...
info: remove printServerWarningsLegacy
2024-01-23 18:22:58 +01:00
Sebastiaan van Stijn
69a4fcc3bb
Merge pull request #4810 from thaJeztah/remove_deprecated_cliopts
...
cli/command: remove deprecated DockerCliOption, InitializeOpt
2024-01-23 18:22:28 +01:00
Sebastiaan van Stijn
ea84a3fc31
Merge pull request #4811 from thaJeztah/remove_deprecated_NewStartOptions
...
cli/command/container: remove deprecated NewStartOptions
2024-01-23 18:22:03 +01:00
Sebastiaan van Stijn
1e8555a38e
Merge pull request #4818 from dvdksn/docs-dockerd-host-gateway-ip-daemonconfig
...
docs: update host-gateway-ip to use daemon.json instead of cli flag
2024-01-23 15:55:03 +01:00
David Karlsson
ec0a62436e
docs: update host-gateway-ip to use daemon.json instead of cli flag
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-23 15:45:59 +01:00
Laura Brehm
469bfc05ed
tests: add tests for cli-plugins/socket
...
Signed-off-by: Laura Brehm <laurabrehm@hey.com >
2024-01-23 14:19:33 +00:00
Sebastiaan van Stijn
c89975d531
Merge pull request #4814 from thaJeztah/update_compose
...
Dockerfile: update docker compose to v2.24.2
2024-01-23 11:04:31 +01:00
Sebastiaan van Stijn
091af560ca
Dockerfile: update docker compose to v2.24.2
...
Update the version of compose used in CI to the latest version.
- full diff: docker/compose@v2.24 .0...v2.24.2
- release notes: https://github.com/docker/compose/releases/tag/v2.24.1
- release notes: https://github.com/docker/compose/releases/tag/v2.24.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-23 10:32:22 +01:00
Sebastiaan van Stijn
2402dac819
cli/command/container: remove deprecated NewStartOptions
...
This function was deprecated in 298bddcc23 for
v25.0, and unused. This patch removes the function.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-20 21:48:46 +01:00
Sebastiaan van Stijn
b43377a38b
cli/command: remove deprecated DockerCliOption, InitializeOpt
...
These types were deprecated in 7af509c7f1 (v25.0),
in favor of CLIOption, and are no longer used.
This patch removes the deprecated type-aliases, and while updating, also improves
the documentation for the CLIOption type.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-20 21:39:32 +01:00
Sebastiaan van Stijn
a71d39bcad
info: remove printServerWarningsLegacy
...
Docker Engine 18.09 (API v1.39) introduced a Warnings field in the into response.
This enhancement was not gated by API version (see [moby/moby@a3d4238 ]), and
will be returned by Docker Engine 18.09 and up, regardless of the API version
chosen.
Likewise, the client-side code was written to prefer warnings returned by
the daemon, but to fall back on client-side detection of missing features
based on information in the Info response (see [docker/cli@3c27ce2 ]).
Thse warnings are purely informational, and given that Docker Engine versions
before 18.09 have reached EOL 6 Years ago, and any current version of the
Engine now returns the Warnings, it should be safe to remove the client-side
fall back logic.
This patch removes the client-side fall back code for warnings that was
added in 3c27ce21c9 .
[moby/moby@a3d4238 ]: https://github.com/moby/moby/commit/a3d4238b9ce653d2863fbc93057ed4162a83221e
[docker/cli@3c27ce2 ]: https://github.com/docker/cli/commit/3c27ce21c905f55c4fa06d28ca42caf7e960db18
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-20 20:45:59 +01:00
Sebastiaan van Stijn
f18a476b6d
Merge pull request #4805 from tonistiigi/socket-eof-return
...
socket: return from loop after EOF
2024-01-20 13:44:45 +01:00
Tonis Tiigi
8cd3b00420
socket: return from loop after EOF
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2024-01-19 17:06:43 -08:00
Sebastiaan van Stijn
e2519aefcb
Merge pull request #4802 from thaJeztah/update_engine
...
vendor: github.com/docker/docker v25.0.0
2024-01-19 15:31:23 +01:00
Sebastiaan van Stijn
1c73abb634
Merge pull request #4800 from dvdksn/docs-fix-broken-alias-links
...
docs: fix broken links to alias pages
2024-01-19 15:06:33 +01:00
Sebastiaan van Stijn
337dd82d8b
vendor: github.com/docker/docker v25.0.0
...
full diff: https://github.com/docker/docker/compare/v25.0.0-rc.3...v25.0.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-19 15:03:52 +01:00
David Karlsson
d633890f91
docs: move base command to docker.md
...
CLI reference for the base command was generated to cli.md
Changed it to docker.md to handle broken links.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-19 14:44:35 +01:00
Sebastiaan van Stijn
ca95badb36
Merge pull request #4799 from dvdksn/docs-cdi
...
docs: add documentation for CDI
2024-01-19 14:15:00 +01:00
David Karlsson
aff4649cb7
docs: fix broken links to alias pages
...
Alias pages redirect to the canonical names, but these pages still
linked to the aliases, causing broken links when building the docs site.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-19 14:06:29 +01:00
David Karlsson
852d198bb5
docs: add documentation for CDI
...
- Add section about cdi-spec-dirs daemon configuration
- Add subsection about cdi in --device section for docker run
- Update `docker info` output example
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-18 14:58:43 +01:00
Sebastiaan van Stijn
e758fe5a7f
Merge pull request #4795 from thaJeztah/bump_engine
...
build / prepare (push) Has been cancelled
build / build (push) Has been cancelled
build / bin-image (push) Has been cancelled
build / prepare-plugins (push) Has been cancelled
build / plugins (push) Has been cancelled
codeql / codeql (push) Has been cancelled
e2e / e2e (19.03-dind, non-experimental) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, connhelper-ssh) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, experimental) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, non-experimental) (push) Has been cancelled
e2e / e2e (debian, stable-dind, connhelper-ssh) (push) Has been cancelled
e2e / e2e (debian, stable-dind, experimental) (push) Has been cancelled
e2e / e2e (debian, stable-dind, non-experimental) (push) Has been cancelled
test / ctn (push) Has been cancelled
test / host (macos-12) (push) Has been cancelled
validate / validate (lint) (push) Has been cancelled
validate / validate (shellcheck) (push) Has been cancelled
validate / validate (update-authors) (push) Has been cancelled
validate / validate (validate-vendor) (push) Has been cancelled
validate / validate-md (push) Has been cancelled
validate / validate-make (manpages) (push) Has been cancelled
validate / validate-make (yamldocs) (push) Has been cancelled
vendor: github.com/docker/docker v25.0.0-rc.3
v25.0.0
2024-01-18 10:33:39 +01:00
Sebastiaan van Stijn
cdb1c105f6
vendor: github.com/docker/docker v25.0.0-rc.3
...
full diff: https://github.com/moby/moby/compare/v25.0.0-rc.2...v25.0.0-rc.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-17 23:28:28 +01:00
Sebastiaan van Stijn
d161a2a470
Merge pull request #4767 from dvdksn/refresh-plugin-docs
...
build / prepare (push) Has been cancelled
build / build (push) Has been cancelled
build / bin-image (push) Has been cancelled
build / prepare-plugins (push) Has been cancelled
build / plugins (push) Has been cancelled
codeql / codeql (push) Has been cancelled
e2e / e2e (19.03-dind, non-experimental) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, connhelper-ssh) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, experimental) (push) Has been cancelled
e2e / e2e (alpine, stable-dind, non-experimental) (push) Has been cancelled
e2e / e2e (debian, stable-dind, connhelper-ssh) (push) Has been cancelled
e2e / e2e (debian, stable-dind, experimental) (push) Has been cancelled
e2e / e2e (debian, stable-dind, non-experimental) (push) Has been cancelled
test / ctn (push) Has been cancelled
test / host (macos-12) (push) Has been cancelled
validate / validate (lint) (push) Has been cancelled
validate / validate (shellcheck) (push) Has been cancelled
validate / validate (update-authors) (push) Has been cancelled
validate / validate (validate-vendor) (push) Has been cancelled
validate / validate-md (push) Has been cancelled
validate / validate-make (manpages) (push) Has been cancelled
validate / validate-make (yamldocs) (push) Has been cancelled
docs(plugins): fix typos and formatting
v25.0.0-rc.3
2024-01-17 14:28:58 +01:00
David Karlsson
3df149545e
docs(plugins): fix typos and formatting
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-16 20:37:29 +01:00
Sebastiaan van Stijn
33b00e5185
Merge pull request #4797 from dvdksn/daemon-builder-config
...
docs: add "builder" key to full daemon.json example
2024-01-16 20:34:02 +01:00
David Karlsson
22bbdc7984
docs: add "builder" key to full daemon.json example
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com >
2024-01-16 20:19:06 +01:00
Sebastiaan van Stijn
5fde1f2b80
Merge pull request #4796 from thaJeztah/deprecate_old_api_versions
...
deprecate old API versions (1.23 and lower)
2024-01-16 19:42:14 +01:00