toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,773 Commits 3 Branches 295 Tags
b991b6236a32b19f3cbde8494fc096e28380dd0d
Commit Graph
5773 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tibor Vass b991b6236a prune: use filters.Args.Clone() 
Signed-off-by: Tibor Vass <tibor@docker.com>
 2018-12-10 16:48:59 +00:00
Tibor Vass 1408a3189f Merge pull request #1551 from thaJeztah/fix_filter_panic 
Fix panic when pruning images with label-filter
 2018-12-10 13:21:37 +01:00
Sebastiaan van Stijn a0fe333cab Merge pull request #1546 from albers/completion-import--platform 
Add bash completion for `import --platform`
 2018-12-07 20:07:49 +01:00
Sebastiaan van Stijn 687cf9bef7 Merge pull request #1547 from albers/completion-log-driver-local 
Add bash completion for "local" log driver
 2018-12-07 20:04:09 +01:00
Sebastiaan van Stijn 1e1dd5bca4 Fix panic when pruning images with label-filter 
Before this change:

    docker image prune --force --filter "label=foobar"
    panic: assignment to entry in nil map

    goroutine 1 [running]:
    github.com/docker/cli/vendor/github.com/docker/docker/api/types/filters.Args.Add(...)
    /go/src/github.com/docker/cli/vendor/github.com/docker/docker/api/types/filters/parse.go:167
    github.com/docker/cli/cli/command/image.runPrune(0x1db3a20, 0xc000344cf0, 0x16e0001, 0xc00015e600, 0x4, 0x3, 0xc00024e160, 0xc000545c70, 0x5ab4b5)
    /go/src/github.com/docker/cli/cli/command/image/prune.go:79 +0xbaf
    github.com/docker/cli/cli/command/image.NewPruneCommand.func1(0xc00029ef00, 0xc0004a8180, 0x0, 0x3, 0x0, 0x0)
    /go/src/github.com/docker/cli/cli/command/image/prune.go:32 +0x64
    github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).execute(0xc00029ef00, 0xc000038210, 0x3, 0x3, 0xc00029ef00, 0xc000038210)
    /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:762 +0x473
    github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000127180, 0xc000272770, 0x1836ce0, 0xc000272780)
    /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:852 +0x2fd
    github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).Execute(0xc000127180, 0xc000127180, 0x1d60880)
    /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:800 +0x2b
    main.main()
    /go/src/github.com/docker/cli/cmd/docker/docker.go:180 +0xdc

With this patch applied:

    docker image prune --force --filter "label=foobar"
    Total reclaimed space: 0B

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-12-07 17:56:31 +01:00
Harald Albers 561f6e399c Merge pull request #1130 from cyphar/separate-domainname-flag 
cli: add a separate --domainname flag
 2018-12-07 16:07:53 +01:00
Aleksa Sarai 647579068f cli: add a separate --domainname flag 
A while ago, Docker split the "Domainname" field out from the "Hostname"
field for the container configuration. There was no real user-visible
change associated with this (and under the hood "Domainname" was mostly
left unused from the command-line point of view). We now add this flag
in order to match other proposed changes to allow for setting the NIS
domainname of a container.

This also includes a fix for the --hostname parsing tests (they would
not error out if only one of .Hostname and .Domainname were incorrectly
set -- which is not correct).

Signed-off-by: Aleksa Sarai <asarai@suse.de>
 2018-12-08 00:03:56 +11:00
Sebastiaan van Stijn d8479b4238 Merge pull request #1548 from ZYecho/fix-images-filter 
fix: add more details about multiple images filter
 2018-12-07 11:26:56 +01:00
zhangyue 012e05bdd4 fix: add more details about multiple images filter 
Signed-off-by: zhangyue <zy675793960@yeah.net>
 2018-12-05 12:04:06 +08:00
Harald Albers c59038b15c Add bash completion for "local" log driver 
Ref: https://github.com/moby/moby/pull/37092

Also adds log-opt `compress` to json-file log driver because this was
also added in the referenced PR.

Signed-off-by: Harald Albers <github@albersweb.de>
 2018-12-02 19:07:19 +01:00
Harald Albers e0fe546c37 Add bash completion for import --platform 
Signed-off-by: Harald Albers <github@albersweb.de>
 2018-12-01 23:30:30 +01:00
Andrew Hsu 504cecf293 Merge pull request #1539 from thaJeztah/fix_flags_in_usage 
Fix yamldocs outputing `[flags]` in usage output
 2018-11-29 13:29:41 -08:00
Sebastiaan van Stijn 1f6a1a438c Merge pull request #1252 from albers/completion-cli-experimental 
Add bash completion for experimental CLI commands (manifest)
 2018-11-29 17:11:28 +01:00
Sebastiaan van Stijn 44d96e9120 Fix yamldocs outputing [flags] in usage output 
A similar change was made in the CLI itself, but is not
inherited by the code that generates the YAML docs.

Before this patch is applied;

```
usage: docker container exec [OPTIONS] CONTAINER COMMAND [ARG...] [flags]
```

With this patch applied:

```
usage: docker container exec [OPTIONS] CONTAINER COMMAND [ARG...]
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-11-29 15:39:07 +01:00
Vincent Demeester f64dc97aca Merge pull request #1306 from cyphar/obey-source_date_epoch 
man: obey SOURCE_DATE_EPOCH when generating man pages
 2018-11-29 09:49:44 +01:00
Sebastiaan van Stijn 1f61ced7b3 Merge pull request #1536 from nirs/environmental 
Replace environmental with environment
 2018-11-29 02:33:38 +01:00
Nir Soffer f1f3d3be17 Replace environmental with environment 
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
 2018-11-29 01:34:12 +02:00
Silvin Lubecki 69bd2728c4 Merge pull request #1509 from selansen/master 
Data Path Port configuration support
 2018-11-28 17:10:39 +01:00
selansen e3e976a82a Data Path Port configuration support 
This PR chnages allow user to configure data path
port number. By default we use 4789 port number. But this commit
will allow user to configure port number during swarm init.
Data path port can't be modified after swarm init.

Signed-off-by: selansen <elango.siva@docker.com>
 2018-11-28 10:55:42 -05:00
selansen 052133a4f5 Vendor commit for Data Path Port configuration support 
This commit brings Swarmkit and docker chnages

Signed-off-by: selansen <elango.siva@docker.com>
 2018-11-26 15:58:44 -05:00
Sebastiaan van Stijn 2d692aedb3 Merge pull request #1517 from glefloch/migrate-test-from-moby 
Migrate TestTrustedCreateFromBadTrustServer from moby into cli/e2e
 2018-11-26 17:09:40 +01:00
glefloch 37679bfc85 Add missing test 
Signed-off-by: glefloch <glfloch@gmail.com>
 2018-11-26 14:02:16 +00:00
Sebastiaan van Stijn e042b58f7d Merge pull request #1527 from tiborvass/fix-system-prune-filters 
prune: move image pruning before build cache pruning
 2018-11-21 19:01:48 +01:00
Sebastiaan van Stijn e1d28fad2d Merge pull request #1493 from tonistiigi/buildkit-docs-update 
add more buildkit docs
 2018-11-21 17:10:33 +01:00
Tonis Tiigi 83aeb219f0 buildkit reference docs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-11-21 16:41:33 +01:00
Silvin Lubecki 5931fb4276 Merge pull request #1528 from thaJeztah/add_logging_driver_example 
Update daemon.json example to show that log-opts must be a string
 2018-11-21 14:56:14 +01:00
Sebastiaan van Stijn fd33e0d933 Update daemon.json example to show that log-opts must be a string 
log-opts are passed to logging-drivers as-is, so the daemon is not
aware what value-type each option takes.

For this reason, all options must be provided as a string, even if
they are used as numeric values by the logging driver.

For example, to pass the "max-file" option to the default (json-file)
logging driver, this value has to be passed as a string;

```json
{
  "log-driver": "json-file",
  "log-opts": {
    "max-size": "10m",
    "max-file": "3"
  }
}
```

When passed as a _number_ (`"max-file": 3`), the daemon will invalidate
the configuration file, and fail to start;

    unable to configure the Docker daemon with file /etc/docker/daemon.json: json: cannot unmarshal number into Go value of type string

This patch adds an example to the daemon.json to show these  values
have to be passed as strings.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-11-21 13:26:08 +01:00
Tibor Vass 6c10abb247 prune: move image pruning before build cache pruning 
This is cleaner because running system prune twice in a row
now results in a no-op the second time.

Signed-off-by: Tibor Vass <tibor@docker.com>
 2018-11-21 05:33:36 +00:00
Silvin Lubecki 422baf69f6 Merge pull request #1523 from sudo-bmitch/pr-doc-cmd-entrypoint 
Documenting ENTRYPOINT can empty value of CMD
 2018-11-20 15:47:34 +01:00
Brandon Mitchell cc316fde55 Documenting ENTRYPOINT can empty value of CMD 
Signed-off-by: Brandon Mitchell <git@bmitch.net>
 2018-11-17 10:10:15 -05:00
Sebastiaan van Stijn f7ea8e831b Merge pull request #1521 from albers/completion-fix-service--force 
Fix bash completion for `service update --force`
 2018-11-15 18:15:32 +01:00
Harald Albers 5fa5eb1da6 Fix bash completion for service update --force 
- `--force` is not available in `service create`
- `--force` is a boolean option

Signed-off-by: Harald Albers <github@albersweb.de>
 2018-11-15 13:43:58 +01:00
Sebastiaan van Stijn 29625f6124 Merge pull request #1415 from dhiltgen/fix_panic_master 
Fix panic in display only case for license - forward port #1408 to master
 2018-11-15 00:55:48 +01:00
Vincent Demeester 0964455c59 Merge pull request #1520 from ijc/bump-gotest 
Bump to gotest.tools v2.2.0
 2018-11-14 17:20:42 +01:00
Ian Campbell 986196e3e3 Bump to gotest.tools v2.2.0 
I would like to use the regex matcher

Signed-off-by: Ian Campbell <ijc@docker.com>
 2018-11-14 11:40:09 +00:00
Silvin Lubecki 3a6f8b6774 Merge pull request #1504 from simonferquel/bump-moby-fix-tests 
Bump moby/moby vendoring and fix tests
 2018-11-08 11:49:52 +01:00
Simon Ferquel 8efa6a9567 Fix tests with missing mocks 
A recent change in moby/moby made tests with missing client mocks fail with panic.
This adds those missing mocks for the impacted tests.

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
 2018-11-08 11:37:49 +01:00
Simon Ferquel 561474d770 Vendoring bump for docker/docker 
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
 2018-11-08 11:37:35 +01:00
Silvin Lubecki 6b71e84ec8 Merge pull request #1472 from lifubang/sshlogs 
Enhancement: don't need to type ssh password twice when docker logs with ssh
 2018-10-26 15:41:39 +01:00
Silvin Lubecki 0904fbfc77 Merge pull request #1369 from vdemeester/formatter-refacto 
formatter package heavy refactoring
 2018-10-26 10:43:13 +01:00
Lifubang aba8821f60 don't need to type ssh password twice when docker logs with ssh 
Signed-off-by: Lifubang <lifubang@acmcoder.com>
 2018-10-26 08:22:49 +08:00
Sebastiaan van Stijn 79455f8238 Merge pull request #1325 from dhiltgen/product_license_master 
Expose product license in info output
 2018-10-26 00:31:32 +02:00
Sebastiaan van Stijn a954005237 Merge pull request #1482 from AkihiroSuda/ssh-nopassword 
docs, ssh: unsupport password auth explicitly
 2018-10-25 15:01:41 +02:00
Akihiro Suda 16b014e062 docs, ssh: unsupport password auth explicitly 
The issue with password auth is tracked in #1476 and #1477 .

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2018-10-25 16:02:26 +09:00
Sebastiaan van Stijn 15e40e7ee2 Merge pull request #1429 from AkihiroSuda/fix-docker-invalid-subcommand 
Fix `docker invalid-subcommand` regression
 2018-10-24 20:45:01 +02:00
Vincent Demeester 69fdd2a4ad formatter package heavy refactoring 
- make it possible to extract the formatter implementation from the
  "common" code, that way, the formatter package stays small
- extract some formatter into their own packages

This is essentially moving the "formatter" implementation of each type
in their respective packages. The *main* reason to do that, is to be
able to depend on `cli/command/formatter` without depending of the
implementation detail of the formatter. As of now, depending on
`cli/command/formatter` means we depend on `docker/docker/api/types`,
`docker/licensing`, … — that should not be the case. `formatter`
should hold the common code (or helpers) to easily create formatter,
not all formatter implementations.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-10-23 17:05:44 +02:00
Tibor Vass ea836abed5 Merge pull request #1474 from tiborvass/fix-build-stream 
build: update session support detection
 2018-10-22 16:01:12 -07:00
Tibor Vass 3e8c41beb0 build: update session support detection 
Avoid testing for session support in non-buildkit builder to support
servers that falsely report as `1.39` compatible

Signed-off-by: Tibor Vass <tibor@docker.com>
 2018-10-22 20:52:56 +00:00
Sebastiaan van Stijn 727a83bde2 Merge pull request #1445 from sudo-bmitch/pr-rmi-tag 
Updating rmi doc example to specify latest tag
 2018-10-19 01:11:23 +02:00
Sebastiaan van Stijn 3eaae8391b Merge pull request #1447 from sudo-bmitch/pr-daemon-json-formatting 
Adjust formatting on daemon.json documentation
 2018-10-18 17:52:08 +02:00