toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,039 Commits 3 Branches 295 Tags
cc1d7b7ac97cbc1d82a8ed3c5a4a311483dd0c61
Commit Graph
10039 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastiaan van Stijn cc1d7b7ac9 cli/command/system: remove redundant nil-check (gosimple) 
cli/command/system/info.go:375:5: S1009: should omit nil check; len() for []github.com/docker/docker/api/types/system.NetworkAddressPool is defined as zero (gosimple)
        if info.DefaultAddressPools != nil && len(info.DefaultAddressPools) > 0 {
           ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-08-26 13:44:42 +02:00
David Karlsson 436080b887 Merge pull request #5360 from dvdksn/update-apireference-link 
chore: update link to docker engine api reference
 2024-08-22 15:17:45 +02:00
David Karlsson 35626bae8a Merge pull request #5350 from dvdksn/docs-alerts-syntax 
docs: use gh alert syntax for callouts
 2024-08-21 11:39:45 +02:00
Sebastiaan van Stijn d47c36debb Merge pull request #5363 from akerouanton/fix-ps-pbs 
cli/formatter: bracket IPv6 addrs prepended to ports
 2024-08-20 17:51:14 +02:00
Albin Kerouanton 964155cd27 cli/formatter: bracket IPv6 addrs prepended to ports 
On `docker ps`, port bindings with an IPv6 HostIP should have their
addresses put into brackets when joining them to their ports.

RFC 3986 (Section 3.2.2) stipulates that IPv6 addresses should be
enclosed within square brackets. This RFC is only about URIs. However,
doing so here helps user identifier what's part of the IP address and
what's the port. It also makes it easier to copy/paste that
'[addr]:port' into other software (including browsers).

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
 2024-08-20 17:32:27 +02:00
Laura Brehm 986b077a53 Merge pull request #5361 from laurazard/add-oauth-login-escape-hatch 
login: add oauth escape hatch
 2024-08-20 12:31:07 +01:00
Laura Brehm a327476f7f login: add e2e tests for oauth + escape hatch 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-20 11:49:04 +01:00
David Karlsson c974a83391 chore: update link to docker engine api reference 
Engine API reference page is moving to /reference/api/engine

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-08-20 12:35:04 +02:00
Laura Brehm 846ecf59ff login: add oauth escape hatch 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-20 11:16:55 +01:00
David Karlsson 0be9e2faaa Merge pull request #5347 from dvdksn/update-build-context-link 
docs: update link to moved build context doc
 2024-08-19 13:13:31 +02:00
Laura Brehm b06db58d8d Merge pull request #5356 from vvoland/list-tree-gd-spacing 
list/tree: No extra spacing for graphdriver
 2024-08-19 11:46:07 +01:00
Paweł Gronowski 7b91647943 list/tree: No extra spacing for graphdriver 
Don't output the extra spacing around the images when none of the
top-level image entries has any children.

This makes the list look better when ran against the graphdrivers image
store.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-19 12:09:37 +02:00
Paweł Gronowski 8675f4c177 Merge pull request #5352 from vvoland/c8d-multiplatform-list-2 
list/tree: Print <untagged> as dangling image name
 2024-08-16 16:56:08 +02:00
Paweł Gronowski 351249dce9 list/tree: Print <untagged> as dangling image name 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 16:36:33 +02:00
Paweł Gronowski 6979ab073c list/tree: Fix some escape codes included in nonTTY 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 16:35:46 +02:00
Laura Brehm cab8a2e830 Merge pull request #4982 from vvoland/c8d-multiplatform-list 
image/list: Add `--tree` flag
 2024-08-16 14:27:15 +01:00
Paweł Gronowski a9b78da546 list/tree: Add spacing before the content and first image 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:10:00 +02:00
Paweł Gronowski 0242a1e3c6 list/tree: Capitalize column headers 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:59 +02:00
Paweł Gronowski d417d06682 list/tree: Add an experimental warning 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:57 +02:00
Paweł Gronowski b1a08f7841 list/tree: Sort by created date 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:55 +02:00
Paweł Gronowski 18ab78882c list/tree: Align number right, text left 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:54 +02:00
Paweł Gronowski ea8aafcd9e cli/tree: Add Content size column 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:52 +02:00
Paweł Gronowski be11b74ee9 image/list: Add --tree flag 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-16 15:09:51 +02:00
David Karlsson f1befabe9f docs: use gh alert syntax for callouts 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-08-16 11:02:10 +02:00
Sebastiaan van Stijn bbce5a0afa Merge pull request #5344 from laurazard/auth-device-flow-pat 
auth: add support for oauth device-code login
 2024-08-15 09:29:45 +02:00
Laura Brehm c3fe7bc336 fallback to regular login if oauth login fails to start 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-14 19:48:09 +01:00
Laura Brehm 5eb3275c28 filestore: don't print warning multiple times 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-14 19:48:08 +01:00
Laura Brehm e6624676e0 login: normalize registry-1.docker.io 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-14 19:48:07 +01:00
Laura Brehm 6e4818e7d6 Refactor cli/command/registry 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-14 19:48:05 +01:00
Laura Brehm fcfdd7b91f auth: add support for oauth device-code login 
This commit adds support for the oauth [device-code](https://auth0.com/docs/get-started/authentication-and-authorization-flow/device-authorization-flow)
login flow when authenticating against the official registry.

This is achieved by adding `cli/internal/oauth`, which contains code to manage
interacting with the Docker OAuth tenant (`login.docker.com`), including launching
the device-code flow, refreshing access using the refresh-token, and logging out.

The `OAuthManager` introduced here is also made available through the `command.Cli`
interface method `OAuthManager()`.

In order to maintain compatibility with any clients manually accessing
the credentials through `~/.docker/config.json` or via credential
helpers, the added `OAuthManager` uses the retrieved access token to
automatically generate a PAT with Hub, and store that in the
credentials.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-14 19:48:04 +01:00
David Karlsson 2dd4eb06ae docs: update link to moved build context doc 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-08-13 11:48:29 +02:00
Sebastiaan van Stijn 35666cf7cb Merge pull request #5345 from thaJeztah/connhelper_cleanups 
cli/connhelper: getConnectionHelper: move ssh-option funcs out of closure
 2024-08-13 11:38:44 +02:00
Sebastiaan van Stijn 0fd3fb0840 cli/connhelper: getConnectionHelper: move ssh-option funcs out of closure 
The addSSHTimeout and disablePseudoTerminalAllocation were added in commits
a5ebe2282a and f3c2c26b10,
and called inside the Dialer function, which means they're called every
time the Dialer is called. Given that the sshFlags slice is not mutated
by the Dialer, we can call these functions once.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-08-12 17:28:32 +02:00
Sebastiaan van Stijn 1a7b7dd7dd Merge pull request #5320 from trajano/patch-1 
disable pseudoterminal creation
 2024-08-12 16:59:47 +02:00
Archimedes Trajano f3c2c26b10 disable pseudoterminal creation 
avoided the join, also did manual iteration

added test, also added reflect for the DeepEqual comparison

Signed-off-by: Archimedes Trajano <developer@trajano.net>
 2024-08-12 16:53:49 +02:00
David Karlsson 211a5403b3 Merge pull request #5342 from dvdksn/docs-update-internal-links 
docs: update internal links after refactor
 2024-08-12 10:10:05 +02:00
David Karlsson d4a362aa1c docs: update internal links after refactor 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-08-11 16:58:08 +02:00
Sebastiaan van Stijn 471862b122 Merge pull request #5323 from jongwu/fix_bps_limit 
run: fix GetList return empty issue for throttledevice
 2024-08-09 19:46:23 +02:00
David Karlsson fc3e949a66 Merge pull request #5338 from dvdksn/fix-proxy-doclink 
docs: fix link to http proxy document
 2024-08-09 19:11:04 +02:00
David Karlsson 78a8fba2cc docs: fix link to http proxy document 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-08-09 18:19:58 +02:00
Paweł Gronowski c537fb9f48 Merge pull request #5332 from thaJeztah/bump_engine 
vendor: github.com/docker/docker 2269acc7a31d (master, v-next)
 2024-08-09 09:45:24 +02:00
Sebastiaan van Stijn 6440816c7c vendor: github.com/docker/docker 2269acc7a31d (master, v-next) 
removes (indirect) dependencie on the moby/sys/user/userns package, which
was retracted and moved to moby/sys/userns

- full diff: https://github.com/docker/docker/compare/f3cf9359bdf6...2269acc7a31df0241e9667d5df98be6a4db5ba6a

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-08-08 13:37:58 +02:00
Sebastiaan van Stijn 7fc8802889 Merge pull request #5330 from vvoland/vendor-docker-master 
vendor: github.com/docker/docker master  (f3cf9359bdf6)
 2024-08-08 12:09:30 +02:00
Paweł Gronowski 91b173e69f Merge pull request #5316 from thaJeztah/add_security 
add security policy
 2024-08-08 11:48:43 +02:00
Paweł Gronowski b8a53ee340 vendor: github.com/docker/docker master (f3cf9359bdf6) 
full diff: https://github.com/docker/docker/compare/2b1097f08088...f3cf9359bdf6

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-08 11:44:02 +02:00
Sebastiaan van Stijn 0052d2ce05 Merge pull request #5327 from laurazard/fix-panic-pluginserver 
plugins: don't panic on Close if PluginServer nil
 2024-08-07 17:16:00 +02:00
Laura Brehm 9c4480604e plugins: don't panic on Close if PluginServer nil 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-08-07 14:04:31 +01:00
Sebastiaan van Stijn 87c6624cb7 Merge pull request #5324 from vvoland/update-go-1.21.13 
update to go1.21.13
 2024-08-07 12:01:32 +02:00
Paweł Gronowski 434d8b75e8 update to go1.21.13 
- https://github.com/golang/go/issues?q=milestone%3AGo1.21.13+label%3ACherryPickApproved
- full diff: https://github.com/golang/go/compare/go1.21.12...go1.21.13

go1.21.13 (released 2024-08-06) includes fixes to the go command, the
covdata command, and the bytes package. See the [Go 1.21.13 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.21.13+label%3ACherryPickApproved)
on our issue tracker for details.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-08-07 11:49:40 +02:00
Jianyong Wu 73e78a5822 run: fix GetList return empty issue for throttledevice 
Test "--device-read-bps" "--device-write-bps" will fail. The root
cause is that GetList helper return empty as its local variable
initialized to zero size.

This patch fix it by setting the related slice size to non-zero.

Signed-off-by: Jianyong Wu <wujianyong@hygon.cn>
Fixes: #5321
 2024-08-07 02:48:39 +00:00