Daniel Nephin
26b834a698
Merge pull request #968 from dnephin/remove-myself-as-code-owner
...
Remove myself from CODEOWNERS
2018-03-27 16:46:54 -04:00
Daniel Nephin
d3efe30878
Merge pull request #931 from dnephin/refactor-build-unit-tests
...
Refactor build tests to re-use more code and not require root
2018-03-26 14:44:13 -04:00
Daniel Nephin
0f1bb35342
Refactor build tests to re-use more code and not require root
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-26 14:27:52 -04:00
Daniel Nephin
3a633aa271
Remove myself from CODEOWNERS
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-26 13:39:03 -04:00
Daniel Nephin
c0588a9c8f
Remove filewatcher
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-20 20:13:27 -04:00
Daniel Nephin
fcffd67028
Add e2e test for stack deploy
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-12 16:24:30 -04:00
Daniel Nephin
b4c108a385
Fix named network in compose file
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-12 15:15:27 -04:00
Daniel Nephin
ca88e5e9df
update vendor, add cmpopts
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-12 15:15:23 -04:00
Daniel Nephin
feae0e9756
Only read trust setting from options
...
Rename IsTrusted to ContentTrustEnabled
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-08 16:46:30 -05:00
Daniel Nephin
00b803b2d8
Add a build unit test for symlinked context
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-07 13:04:33 -05:00
Daniel Nephin
0e3677ead5
Merge pull request #921 from dnephin/use-canonical-imports
...
testing: Use canonical asserts
2018-03-07 12:00:34 -05:00
Daniel Nephin
e15b208e96
Convert assert.Check(t, is.Error()) to assert.Error
...
git grep -l -P '^\s+assert\.Check\(t, is\.Error\(' | \
xargs perl -pi -e 's/^(\s+assert\.)Check\(t, is\.Error\((.*)\)$/\1Error(t, \2/'
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 16:00:28 -05:00
Daniel Nephin
f21276575f
manual clean of asserts
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 15:49:00 -05:00
Daniel Nephin
078cbc9c4b
Convert assert.Check with
...
git grep -l -P '^\s+assert\.Check\(t, ' | \
xargs perl -pi -e 's/^(\s+assert)\.Check(\(t, (?!is).*(\.Execute\(|\.Set\(|\.Write\(|\.Close\(|\.Untar\(|\.WriteFile\(|Validate\().*\)$)/\1.NilError\2/'
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 15:43:53 -05:00
Daniel Nephin
baf65a5502
Convert to assert.NilError
...
Using:
git grep -l '^\s\+assert\.Check(t, err)$' | \
xargs sed -i -e 's/^\(\s\+assert\)\.Check(t, err)$/\1.NilError(t, err)/'
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 15:27:34 -05:00
Daniel Nephin
0f11a310fd
dont prompt for github creds in unit test
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 15:27:09 -05:00
Daniel Nephin
681c921528
Remove testutil
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 14:38:35 -05:00
Daniel Nephin
c969e1e0b3
Merge pull request #917 from dnephin/cleanup-test-configfile
...
Don't set a default filename for ConfigFile
2018-03-06 14:37:28 -05:00
Daniel Nephin
789acb526c
Cleanup config load error handling
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 13:44:06 -05:00
Daniel Nephin
7c8b5708eb
Don't set a default filename for ConfigFile
...
With a default filename tests will leave a file in the working directory
that is never cleaned up.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-06 13:32:50 -05:00
Daniel Nephin
5155cda716
Post migration fixes
...
Fix tests that failed when using cmp.Compare()
internal/test/testutil/assert
InDelta
Fix DeepEqual with kube metav1.Time
Convert some ErrorContains to assert
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-05 19:41:17 -05:00
Daniel Nephin
39c2ca57c1
Automated migration
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-05 19:41:17 -05:00
Daniel Nephin
5ef8835f23
Replace testify vendor with updated gotestyourself
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-05 19:41:14 -05:00
Daniel Nephin
93615dd967
Update some assertions.
...
and fix some tests
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-05 17:15:24 -05:00
Daniel Nephin
cff874122c
Use new APIClient interface
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-03-05 16:34:22 -05:00
Daniel Nephin
60dcc4cdfb
Merge pull request #912 from kkirsche/patch-1
...
Fix grammar typo in comment
2018-02-28 11:58:01 -05:00
Daniel Nephin
07cb69e9bc
Add more container cp tests
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-02-27 16:38:02 -05:00
Daniel Nephin
ce544823b6
Refactor substitute to reduce cyclo complexity
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-02-26 15:29:17 -05:00
Daniel Nephin
0e81cddd95
Merge pull request #884 from shin-/update_3.6_schema_id
...
Fix typo in 3.6 schema ID
2018-02-21 14:49:43 -05:00
Daniel Nephin
cea4d37bca
Merge pull request #824 from ethan-haynes/820-bind-mount-source-missing-error
...
added check for empty source in bind mount
2018-02-21 13:33:24 -05:00
Daniel Nephin
a160ad89c9
Merge pull request #894 from thaJeztah/update-moby
...
Bump moby to 0ede01237c9ab871f1b8db0364427407f3e46541
2018-02-21 13:15:58 -05:00
Daniel Nephin
939938b976
Merge pull request #891 from vdemeester/k8s-loader-make-sure-version
...
Make sure we marshall version too…
2018-02-21 11:45:14 -05:00
Daniel Nephin
bbe7f84540
Merge pull request #264 from thaJeztah/carry-moby-32803
...
Update docker kill reference docs
2018-02-20 11:19:59 -05:00
Daniel Nephin
847cc4bdc0
Merge pull request #564 from thaJeztah/fix-yaml-examples
...
Fix leading characters being stripped from example sections in YAML
2018-02-16 11:22:24 -05:00
Daniel Nephin
b127b8d927
Replace go-bindata with esc
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-02-12 14:23:19 -05:00
Daniel Nephin
dcd62981c4
Merge pull request #872 from nogoegst/fix-unsupported-default-credential-store
...
Fix compilation of defaultCredentialStore() on unsupported platforms
2018-02-12 11:51:18 -05:00
Daniel Nephin
a9ecf823ff
Merge pull request #868 from thaJeztah/bump-golang-1.9.4
...
Bump golang to 1.9.4
2018-02-08 08:06:52 -08:00
Daniel Nephin
a6dedd1a12
Fix vendor validation
...
vendor/ must be removed first, otherwise files added to vendor/ but not vendor.conf
will not cause the validation to fail
Signed-off-by: Daniel Nephin <dnephin@gmail.com >
2018-02-02 11:01:05 -08:00
Daniel Nephin
3988d9cfd9
Merge pull request #853 from thaJeztah/bump-go-connections
...
bump docker/go-connections to 98e7d807e5d804e4e42a98d74d1dd695321224ef
2018-01-31 10:22:41 -08:00
Daniel Nephin
4a03f2a4ae
Merge pull request #852 from thaJeztah/bump-version-18.03
...
Bump VERSION to 18.03.0-dev
2018-01-31 10:21:54 -08:00
Daniel Nephin
7da324a2f6
Merge pull request #844 from tophj-ibm/bump-to-go-1-9-3
...
Bump Go to 1.9.3 (cont.)
2018-01-29 16:17:28 -05:00
Daniel Nephin
a46fa0759d
Merge pull request #804 from thaJeztah/more-annotations
...
Annotate "stack" commands to be "swarm" and "kubernetes"
2018-01-26 15:12:09 -05:00
Daniel Nephin
819df0ebf6
Merge pull request #827 from thaJeztah/bump-go-1.9.3
...
Bump Go to 1.9.3
2018-01-24 17:34:05 -05:00
Daniel Nephin
ae03b006a6
Fix merge conflict
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-01-22 18:09:47 -05:00
Daniel Nephin
02ca1c8573
Add dockerfile for building on non-amd64 platforms
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-01-18 13:16:58 -05:00
Daniel Nephin
01b521c002
Update buidler ENV docs
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2018-01-17 16:55:07 -05:00
Daniel Nephin
fab4762941
Merge pull request #581 from thaJeztah/better-port-range-printing
...
Improve presentation of published port ranges
2018-01-16 17:16:45 -05:00
Daniel Nephin
1620538c49
Merge pull request #755 from kolyshkin/wait
...
Show container wait error
2018-01-16 14:40:36 -05:00
Daniel Nephin
220c50abc1
Merge pull request #781 from thaJeztah/fix-autogenerated-formatting
...
Fix gofmt for auto-generated k8s code
2018-01-04 11:23:32 -05:00
Daniel Nephin
718a245b6e
Merge pull request #713 from albers/completion-512
...
Fix #512 Bash autocompletion works incorrect with inspect
2017-12-15 16:33:41 -05:00
Daniel Nephin
9da2602f38
Fix external networks
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-12-11 11:29:49 -05:00
Daniel Nephin
d0b8aa7701
Support network.name in the compose schema.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-12-06 10:05:24 -05:00
Daniel Nephin
16cd84024c
Fix e2e build test
...
The build output changed in 17.11
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-29 11:02:40 -05:00
Daniel Nephin
8abb266043
Merge pull request #716 from vdemeester/bump-go
...
Bump Go to 1.9.2
2017-11-29 09:42:58 -05:00
Daniel Nephin
6476524c74
Merge pull request #709 from dnephin/e2e-docker-build
...
Add e2e test for docker build
2017-11-23 13:54:41 -05:00
Daniel Nephin
227dfea9e1
Merge pull request #689 from thaJeztah/remove-daemon-subcommand
...
Remove deprecated "daemon" subcommand
2017-11-23 11:10:50 -05:00
Daniel Nephin
8d41ba082b
Merge pull request #668 from ilyasotkov/667-secret-config-names
...
Add "name" field to secrets and configs to allow interpolation in Compose files
2017-11-22 13:33:59 -05:00
Daniel Nephin
7adb4c4b1e
Add e2e test for docker build
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-21 13:24:37 -05:00
Daniel Nephin
5b4af39b8d
Disable adding [flags] to UseLine in man pages
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-20 12:48:10 -05:00
Daniel Nephin
c01f642800
Update spf13/cobra
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-20 12:42:11 -05:00
Daniel Nephin
bace33d7a8
Fix TestAttachExitCode
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-17 18:12:48 -08:00
Daniel Nephin
f1cc679618
Add unit tests for some convert/service
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-10 16:28:39 -05:00
Daniel Nephin
a68c940f1a
Remove duplication in compose/convert
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-10 15:56:11 -05:00
Daniel Nephin
7bd26ed690
Remove duplication in loader
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-10 15:56:11 -05:00
Daniel Nephin
ee0615dc97
Merge pull request #575 from eiais/local-flag
...
trust sign: add --local flag
2017-11-07 14:15:53 -05:00
Daniel Nephin
aea9544db5
Only warn on volume.external.name for version 3.4
...
Also remove use of volume.external.name
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-11-06 17:04:36 -05:00
Daniel Nephin
5a4fe7fe05
Merge pull request #661 from thaJeztah/bump-golang-to-1.8.5
...
Bump Go to 1.8.5
2017-10-31 16:24:27 -04:00
Daniel Nephin
b7b62ca26a
Adding unit tests for cp
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-30 18:33:28 -04:00
Daniel Nephin
65398de1a6
Merge pull request #655 from eiais/extraQuote
...
Remove extra quotes from docker trust sign
2017-10-30 13:53:18 -04:00
Daniel Nephin
a79e742bfc
Merge pull request #648 from thaJeztah/fix-host-add-description
...
Fix flag description for --host-add
2017-10-30 13:52:29 -04:00
Daniel Nephin
b900676523
Use t.Run() for tests
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-30 13:00:03 -04:00
Daniel Nephin
54e1378e04
Merge pull request #636 from dnephin/fix-trust-output-stream
...
Fix stdout and errors in image/trust
2017-10-27 11:31:01 -04:00
Daniel Nephin
b087b13cae
Merge pull request #617 from dnephin/update-gometalinter
...
Update gometalinter
2017-10-26 13:08:00 -04:00
Daniel Nephin
c0d004f7cf
Update gometalinter
...
and enable the new WarnUnmatchedDirective to warn if a nolint is unnecessary.
remove some unnecessary nolint
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-26 12:21:02 -04:00
Daniel Nephin
b68c3d007f
Merge pull request #601 from dnephin/compose-cast-after-interpolate
...
[Compose] Cast values to expected type after interpolating values
2017-10-26 12:20:04 -04:00
Daniel Nephin
f50345a26c
Hide help flag from help output.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-26 12:17:50 -04:00
Daniel Nephin
8e600e10f7
Fix UseLine
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-25 18:22:04 -04:00
Daniel Nephin
4205416c9b
Update code for upstream cobra
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-25 14:49:26 -04:00
Daniel Nephin
0f2ebae056
Update vendor of spf13/pflag and spf13/cobra
...
Use upstream isntead of fork for cobra.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-25 12:50:37 -04:00
Daniel Nephin
8f86a25029
Fix stdout and errors in image/trust
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-23 13:54:55 -04:00
Daniel Nephin
dbd96badb6
Add nakedret linter.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-12 11:48:51 -04:00
Daniel Nephin
5c9784e3a3
Merge pull request #618 from albers/completion-secret-create--driver
...
Add bash completion for `secret create --driver`
2017-10-11 13:10:00 -04:00
Daniel Nephin
b11c11ea74
Update e2e test for image pull to check stdout
...
Also add TEST_DEBUG env variable for debugging E2E tests.
And change icmd environment helpers to fit the CmdOp interface os they
can be passed to 'icmd.RunCmd()'
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-10 17:04:49 -04:00
Daniel Nephin
e548861481
Refactor runPull to remove second GetImageReferencesAndAuth
...
Fix unit tests to catch the regression.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-10 16:32:27 -04:00
Daniel Nephin
ade675d36c
get e2e working with notary service
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-10 11:19:02 -07:00
Daniel Nephin
af8f563922
Fix load order
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-05 12:03:29 -04:00
Daniel Nephin
18ddec447a
Cast interpolated values
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-04 17:36:47 -04:00
Daniel Nephin
0aa7ca943c
Update interface of Interpolate
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-04 17:36:43 -04:00
Daniel Nephin
edcea7c7a6
Vendor gotestyourself/env
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-10-04 17:36:43 -04:00
Daniel Nephin
daafdf3d84
Merge pull request #594 from thaJeztah/remove-deprecated-error-check
...
Remove use of deprecated IsErr...NotFound checks
2017-10-03 10:30:55 -04:00
Daniel Nephin
adfc2d17a0
Merge pull request #579 from thaJeztah/dont-trunc-on-quiet
...
Do not truncate ID on docker service ps --quiet
2017-10-02 10:33:23 -04:00
Daniel Nephin
64d5c32b8e
Merge pull request #565 from thaJeztah/change-stats-format
...
Change default stats format and add --no-trunc flag
2017-09-28 15:14:43 -04:00
Daniel Nephin
4203b49431
Refactor image commands to make use of the new trust struct for trusted pull
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-26 15:15:42 -04:00
Daniel Nephin
d956386b2d
Update gometalinter
...
The update includes bug fixes in gometalinter and updates to linters, which
discovered more linter problems.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-26 12:33:35 -04:00
Daniel Nephin
9f73b8c718
Support parsing of named pipes for compose volumes.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-26 11:24:23 -04:00
Daniel Nephin
32612058cb
Use a local constant
...
This constant is going to be removed from jsonlog package.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-22 17:59:46 -04:00
Daniel Nephin
e828efa4ab
Set APIVersion on the client, even when Ping fails
...
Refactor to support testing
Also add tests
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-22 10:08:19 -04:00
Daniel Nephin
09c8f47af1
Merge pull request #544 from vdemeester/fix-build-loading
...
Fix loader error with different build syntax
2017-09-20 11:03:54 -04:00
Daniel Nephin
37ac97c72e
Merge pull request #523 from thaJeztah/more-yaml-information
...
Add more information to the generated YAML for documentation
2017-09-18 13:12:39 -04:00
Daniel Nephin
ab2e219116
Fix e2e test by using a pinned version of alpine
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-09-14 11:38:46 -04:00