toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,063 Commits 3 Branches 295 Tags
dd11de7dbb01b0794de3a18b2cd035479ea57f3e
Commit Graph
61 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
CrazyMax fca67dd817 Dockerfile: update to xx 1.2.1 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-07-10 13:09:07 +02:00
Kevin Alvarez 89583b92b7 improve plugins listing performance 
We can slightly improve plugins listing by spawning a
goroutine for each iteration.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-04-01 16:02:34 +02:00
CrazyMax e14f5fc1a7 revert "improve plugins discovery performance" 
This reverts commit 62f2358b99.

Spawning a goroutine for each iteration in the loop when listing
plugins is racy unfortunately. `plugins` slice is protected with
a mutex so not sure why it fails.

I tried using a channel to collect the plugins instead of a slice
to guarantee that they will be appended to the list in the order
they are processed but no dice.

I also tried without errgroup package and simply use sync.WaitGroup
but same. I have also created an extra channel to receive errors
from the goroutines but racy too.

I think the change in this function is not related to the race
condition but newPlugin is. So revert in the meantime :(

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-31 16:20:42 +02:00
Kevin Alvarez c39c711a18 load plugin command stubs when required 
We are currently loading plugin command stubs for every
invocation which still has a significant performance hit.
With this change we are doing this operation only if cobra
completion arg request is found.

- 20.10.23: `docker --version` takes ~15ms
- 23.0.1: `docker --version` takes ~93ms

With this change `docker --version` takes ~9ms

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-28 06:16:55 +02:00
CrazyMax 62f2358b99 improve plugins discovery performance 
We are currently loading plugin commands stubs for every
command invocation to add support for Cobra v2 completion.
This cause a significant performance hit if there is a
lot of plugins in the user space (7 atm in Docker Desktop):

`docker --version` takes in current 23.0.1 ~93ms

Instead of removing completion for plugins to fix the
regression, we can slightly improve plugins discovery by
spawning a goroutine for each iteration in the loop when
listing plugins:

`docker --version` now takes ~38ms

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-28 06:16:55 +02:00
CrazyMax bebdb6fa2a ci: enhanced build workflow 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-28 04:59:09 +02:00
CrazyMax bec5d37e91 don't use null values in the bake definition 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-27 14:32:14 +02:00
CrazyMax b201ce5efd e2e: update notary certificates 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-27 13:28:00 +02:00
CrazyMax c6c33380da e2e: increase tests certificates duration (10 years) 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-27 13:28:00 +02:00
CrazyMax d234a81de7 bake target to generate certs for e2e tets 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-27 13:27:59 +02:00
CrazyMax 3ce95c7af0 Dockerfile: build binary if no target specified 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-24 21:14:41 +01:00
CrazyMax b854eff300 Dockerfile: align go version 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-03-24 21:11:53 +01:00
CrazyMax aa0aa4a6dc Add bash completion for available plugins 
Signed-off-by: CrazyMax <github@crazymax.dev>
 2023-03-17 15:04:09 +01:00
CrazyMax 0f39598687 ci: fix branch filter pattern 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-02-09 18:03:11 +01:00
CrazyMax d347678cde README: fix badges 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-01-13 19:18:26 +01:00
CrazyMax e04f3dd0df docs: fix duplicated format anchor in plugin_ls 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-01-13 16:22:26 +01:00
Kevin Alvarez 79c9e527a3 docs: generate markdown 
Keep frontmatter for docker, dockerd and index markdown files.
Also needs to move cli.md > docker.md before generation and
then move it back because cli.md is needed for yaml generation on docs
website: https://github.com/docker/cli/pull/3924#discussion_r1059986605

Signed-off-by: Kevin Alvarez <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-01-06 22:36:47 +01:00
CrazyMax 186dcf30b1 docs: fix anchors 
Signed-off-by: Kevin Alvarez <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-01-06 22:36:03 +01:00
Kevin Alvarez c49f1ccb49 update cli-docs-tool to v0.5.1 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-01-06 19:15:34 +01:00
CrazyMax 5a5b7a61d5 contrib: fix engine logging docs link 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-01-06 19:15:34 +01:00
CrazyMax 4595ce588c cmd: set double quotes as code delimiter 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2023-01-06 19:15:33 +01:00
CrazyMax 997846918e build: keep "buildx install" behavior 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-11-04 08:42:34 +01:00
CrazyMax d1cabdff99 build: set default context builder if not specified 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-11-04 08:42:34 +01:00
CrazyMax 8dec4bcce8 cleanup leftovers for --stream build flag 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-11-04 08:16:04 +01:00
CrazyMax a7717513b3 docs: fix links to BuildKit backend 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-10-25 11:54:35 +02:00
CrazyMax da81c096bd ci: add concurrency check 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-08-20 16:01:03 +02:00
CrazyMax fd5590dcd4 chore: dependabot to keep gha up to date 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-08-20 16:01:03 +02:00
CrazyMax d598646f11 ci: update github actions 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-08-20 16:01:03 +02:00
CrazyMax 6f799c1a1c dockerfile: llvm needed on debian for cross comp 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-07-28 22:49:07 +02:00
CrazyMax 87b085c8cd missing DWARF symbol table 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-07-25 11:27:09 +02:00
CrazyMax f3ed630f8f docs: dockerfile reference moved to buildkit repo 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-06-27 11:51:46 +02:00
CrazyMax 8e0afc6489 bake: align platforms 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-06-06 18:33:17 +02:00
CrazyMax 0f6a0eb2d4 bake: use no-cache-filter for outdated stage 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-06-05 16:25:05 +02:00
CrazyMax 0c17225df0 Dockerfile: update xx to 1.1.1 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-06-05 16:16:16 +02:00
CrazyMax 22edabb584 fix version quad logic that trims 0 digit so returns an empty one 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-03-31 21:14:29 +02:00
CrazyMax 525845572a trim leading 0 for minor in the version quad 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-03-31 15:54:39 +02:00
CrazyMax a3d53e319f dummy circleci config 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 21:15:39 +01:00
CrazyMax f160fd3e31 remove circleci 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:11:17 +01:00
CrazyMax 7dc35c03fc validate manpages target 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:11:17 +01:00
CrazyMax a650f4ddd0 switch to cli-docs-tool for yaml docs generation 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
switch to cli-docs-tool and validate yamldocs

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:11:16 +01:00
CrazyMax 76a2a1945f fix inherits for vendor bake defs 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:03:25 +01:00
CrazyMax bea6c0d242 validate authors target 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:03:25 +01:00
CrazyMax ede32747b5 add common args bake target 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-25 17:03:24 +01:00
CrazyMax e7a8748b93 build: use legacy builder for wcow if not opt-in with a builder component 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-24 17:57:56 +01:00
CrazyMax e38e6c51ff bring back and expose BuildKitEnabled func 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-24 17:57:56 +01:00
CrazyMax 16edf8bffb builder: conditional warning for wcow 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-03 19:15:58 +01:00
CrazyMax 4d8e45782b builder: fallback to legacy 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-03 10:38:05 +01:00
CrazyMax 6fef143dbc Set buildx as default builder 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-02-03 10:38:05 +01:00
CrazyMax 663f01b9cc use uuid to invalidate cache 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-01-13 13:47:43 +01:00
CrazyMax caa31d9374 fix linguist with .gitattributes 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-12-16 21:16:02 +01:00
CrazyMax 7e560ae76f vendor with go mod 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-12-16 21:16:01 +01:00
CrazyMax 5fab1b2b10 ensure version quad for goversioninfo 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-12-10 10:50:23 +01:00
CrazyMax 3425e9dc3c ci: add glibc to build matrix 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-12-09 16:37:12 +01:00
CrazyMax 4d93717ae5 ci: github actions test workflow 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-12-07 14:50:22 +01:00
CrazyMax 62ea2bf1aa GitHub Actions e2e tests 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-11-17 17:18:25 +01:00
CrazyMax 83c253770c fix .dockerignore to avoid dirty working tree 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-10-24 18:09:57 +02:00
CrazyMax dbac826815 Fix checkout behavior and FileVersion 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-10-12 10:48:31 +02:00
CrazyMax 75284bd1d1 Use goversioninfo to create Windows Version Info 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-10-11 16:54:22 +02:00
CrazyMax d9f4352c26 GitHub Actions cross 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-09-26 18:01:55 +02:00
CrazyMax 698c155478 GitHub Actions for lint 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-08-05 08:44:21 +02:00
CrazyMax ecaaa35be6 Add doc for BUILDKIT_PROGRESS env var 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2021-07-25 20:27:38 +02:00