toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,435 Commits 3 Branches 295 Tags
edc09e6038851a5fd0cb12a787348ce2325eaaf7
Commit Graph
9435 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paweł Gronowski edc09e6038 mount: Add volume-subpath option 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-02-13 14:04:00 +01:00
Sebastiaan van StijnandGitHub a253318869 Merge pull request #4873 from vvoland/test-daemon-apiversion 
testenv: Add DaemonAPIVersion helper
 2024-02-13 13:50:35 +01:00
Paweł Gronowski 9831fea4db testenv: Add DaemonAPIVersion helper 
Allow tests to check the negotiated API version used by the client.

Can be used to skip tests based on API versions, for example:
```go
    skip.If(t, versions.LessThan(environment.DaemonAPIVersion(t), "1.44"))
```

will skip the test if the API version is older than 1.44

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-02-12 16:29:47 +01:00
Christopher PetitoandGitHub d1b88930c3 Merge pull request #4867 from krissetto/test-fixes 
Test fixes needed for upgrading ci runners and engine
 2024-02-12 14:40:22 +01:00
Sebastiaan van StijnandGitHub d7f195833d Merge pull request #4862 from catap/openbsd 
Avoid keeping @docker_cli_[UUID] files
 2024-02-12 13:53:33 +01:00
Sebastiaan van StijnandGitHub b807ea8084 Merge pull request #4868 from thaJeztah/update_engine 
vendor: github.com/docker/docker 86b86412a1b7 (v26.0-dev)
 2024-02-12 09:36:04 +01:00
Sebastiaan van StijnandGitHub 1cda2c45f8 Merge pull request #4869 from thaJeztah/commandcon_cleanup 
cli/connhelper/commandconn: inline variables
 2024-02-12 07:46:14 +01:00
Sebastiaan van Stijn 8bae662713 cli/connhelper/commandconn: inline variables 
Inline the variables used to define the command + args used in the
tests, which makes it slightly easier to see what's run.

Also explicitly define a context, in case we want to add telemetry
to these tests.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-10 13:59:36 +01:00
Sebastiaan van Stijn df6220d434 vendor: github.com/docker/docker 86b86412a1b7 (v26.0-dev) 
full diff: https://github.com/moby/moby/compare/9e075f3808a5...86b86412a1b7df7dcecc81aa6ba795ff6b0c3ce3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-10 12:26:39 +01:00
Christopher Petito 30dd7c1319 Minor test fixes necessary for eventually upgrading ci runners and engine version 
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
 2024-02-09 13:55:03 +00:00
Kirill A. Korinsky 2c214241fa Avoid keeping @docker_cli_[UUID] files 
Seems that OpenBSD behaves like darwin and requires to unlink all
socket, after it was used.

Tested on OpenBSD 7.4

Signed-off-by: Kirill A. Korinsky <kirill@korins.ky>
 2024-02-09 00:19:27 +01:00
Sebastiaan van StijnandGitHub 34797d1678 Merge pull request #4860 from robmry/4859_compose_extra_hosts_eq_sep 
docker stack: allow '=' separator in extra_hosts
 2024-02-08 17:08:47 +01:00
Rob Murray c986d09bca docker stack: allow '=' separator in extra_hosts 
extra_hosts in the compose file format allows '=' as a separator, and brackets
around IP addresses, the engine API doesn't.

So, transform the values when reading a compose file for 'docker stack'.

Signed-off-by: Rob Murray <rob.murray@docker.com>
 2024-02-07 17:57:17 +00:00
Sebastiaan van StijnandGitHub 79fa65e7b5 Merge pull request #4835 from thaJeztah/update_engine_api_removal 
vendor: github.com/docker/docker 9e075f3808a5 (master, v26.0.0-dev)
 2024-02-07 10:47:21 +01:00
Sebastiaan van Stijn 324309b086 vendor: github.com/docker/docker 9e075f3808a5 (master, v26.0.0-dev) 
Vendor docker/docker with API < 1.24 removed. This should not affect client
code.

https://github.com/moby/moby/compare/43ffb1ee9d5a..9e075f3808a5a5fd54f0217ac114d3a02b16af2f

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-07 02:27:53 +01:00
Sebastiaan van Stijn 93ad9fbdf6 vendor: github.com/moby/swarmkit/v2 v2.0.0-20240125134710-dcda100a8261 
full diff: https://github.com/moby/swarmkit/compare/f082dd7a0cee...dcda100a8261

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-07 02:23:51 +01:00
Sebastiaan van StijnandGitHub 57d72237d7 Merge pull request #4854 from krissetto/uniform-volume-prune-output 
Uniform output of volume prune cmd with other prune cmds
 2024-02-06 19:45:51 +01:00
Christopher Petito 69e0f53a03 Uniform volume prune output msg with other prune commands 
- Return error when user refuses at confirmation prompt
- Avoid sending space freed msg if user cancelled
- Fixed unit tests

Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
 2024-02-06 14:04:53 +00:00
Sebastiaan van StijnandGitHub ce3b07c0db Merge pull request #4849 from thaJeztah/image_list_dedup 
images: print hint when invoking "docker images" with ambiguous argument
 2024-02-05 16:25:51 +01:00
Sebastiaan van Stijn 809eb8cdee images: print hint when invoking "docker images" with ambiguous argument 
The `docker images` top-level subcommand predates the `docker <object> <verb>`
convention (e.g. `docker image ls`), but accepts a positional argument to
search/filter images by name (globbing). It's common for users to accidentally
mistake these commands, and to use (e.g.) `docker images ls`, expecting
to see all images, but ending up with an empty list because no image named
"ls" was found.

Disallowing these search-terms would be a breaking change, but we can print
and informational message to help the users correct their mistake.

Before this patch:

    docker images ls
    REPOSITORY   TAG       IMAGE ID   CREATED   SIZE

With this patch applied:

    docker images ls
    REPOSITORY   TAG       IMAGE ID   CREATED   SIZE

    No images found matching "ls": did you mean "docker image ls"?

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-03 18:10:55 +01:00
Sebastiaan van Stijn b158181a1d cli/command/images: runImages: use proper camel-case for dockerCLI 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-03 17:56:06 +01:00
Sebastiaan van Stijn 1328bb3381 cli/command/images: runImages: inline intermediate var 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-02-03 17:54:23 +01:00
Sebastiaan van StijnandGitHub 843951e84a Merge pull request #4843 from docker/dependabot/github_actions/codecov/codecov-action-4 
build(deps): Bump codecov/codecov-action from 3 to 4
 2024-02-01 15:47:14 +01:00
dependabot[bot]andGitHub b123ce6526 build(deps): Bump codecov/codecov-action from 3 to 4 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-02-01 08:57:32 +00:00
David KarlssonandGitHub 297704984b Merge pull request #4396 from zliang-akamai/patch-1 
Add Linode docker volume plugin
 2024-01-31 12:55:31 +01:00
Sebastiaan van StijnandGitHub d001ac4892 Merge pull request #4836 from thaJeztah/remove_dummy_circleci 
Remove dummy circleci config
 2024-01-30 17:46:03 +01:00
Sebastiaan van Stijn 1587b70ee7 Remove dummy circleci config 
The 20.10 branch reached EOL, so we can probably remove this
one again.

This reverts commit a3d53e319f.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-30 17:29:11 +01:00
Sebastiaan van StijnandGitHub 3865da2bc8 Merge pull request #4828 from laurazard/plugin-socket-tests 
Add tests for CLI/plugin communication (i.e. let's not break everyone's plugins 🥲)
 2024-01-29 14:46:25 +01:00
Laura Brehm cfa9fef77d tests: add plugin-socket-compatibility tests 
Adds a new plugin to the e2e plugins that simulates an older
plugin binary and a test suite to ensure older plugin binaries
keep behaving the same with newer CLI versions.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-01-29 13:39:58 +00:00
Sebastiaan van StijnandGitHub 6dcf285ff1 Merge pull request #4834 from thaJeztah/flags_dont_varp 
cli/command: don't use pflags.XXXVarP for flags without shorthand
 2024-01-29 12:26:08 +01:00
Sebastiaan van Stijn dfdff11a22 cli/command: don't use pflags.XXXVarP for flags without shorthand 
Use the `XXXVar` equivalent for flags that don't have a shorthand flag
instead of passing an empty string for the shorthand flag.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-29 11:16:38 +01:00
Sebastiaan van StijnandGitHub abf8cff233 Merge pull request #4832 from thaJeztah/docker_attach_fixups 
cli/command/container: minor cleanup in attach
 2024-01-26 16:45:59 +01:00
Paweł GronowskiandGitHub 0ef5e95481 Merge pull request #4831 from thaJeztah/bump_compose 
Dockerfile: update docker compose to v2.24.3
 2024-01-26 16:19:38 +01:00
Sebastiaan van Stijn 690f63e6d3 cli/command/container: minor cleanup in attach 
- rename confusing `target` argument, and use `containerID` in all places;
  also make the variable more clearly local-scoped.
- rename `dockerCli` to be correctly camel-case, and to be consistent in
  all places in this file.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-26 13:38:09 +01:00
Sebastiaan van Stijn 53e2e54c29 Dockerfile: update docker compose to v2.24.3 
Update the version of compose used in CI to the latest version.

- full diff: https://github.com/docker/compose/compare/v2.24.2...v2.24.3
- release notes: https://github.com/docker/compose/releases/tag/v2.24.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-26 11:06:44 +01:00
Laura Brehm 1c4d6d85dd scripts: don't hardcode architecture in e2e script 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-01-25 15:37:17 +00:00
Sebastiaan van StijnandGitHub a1bd689a4d Merge pull request #4821 from vvoland/vendor-v26.0.0-43ffb1ee9d5a 
vendor: github.com/docker/docker 43ffb1ee9d5a (v26.0.0-dev)
 2024-01-24 15:06:06 +01:00
Paweł Gronowski 4fa2fe9b9e Replace deprecated types.Image* usage 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-01-24 14:59:10 +01:00
Paweł Gronowski 68dac842a1 vendor: github.com/docker/docker 43ffb1ee9d5a (v26.0.0-dev) 
full diff: https://github.com/docker/docker/compare/v25.0.0...43ffb1ee9d5a

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2024-01-24 14:59:08 +01:00
Sebastiaan van StijnandGitHub bb1cb4992c Merge pull request #4820 from thaJeztah/bump_engine_25.0.1 
vendor: github.com/docker/docker v25.0.1
 2024-01-24 14:57:12 +01:00
Sebastiaan van StijnandGitHub 9e2615bc46 Merge pull request #4809 from thaJeztah/remove_printSecurityOptionsWarnings 
info: remove printSecurityOptionsWarnings, printServerWarnings
 2024-01-24 12:36:19 +01:00
Sebastiaan van Stijn 4b1ed1f442 vendor: github.com/docker/docker v25.0.1 
relevant changes:

- Fix isGitURL regular expression
- pkg/system: return even richer xattr errors

full diff: https://github.com/moby/moby/compare/v25.0.0...v25.0.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-24 12:17:20 +01:00
Sebastiaan van Stijn d9294f06b5 info: remove printSecurityOptionsWarnings, printServerWarnings 
Docker Engine 1.13 (API v1.25) added an option to set a custom default seccomp
profile on the daemon (see [moby/moby@b237189]). A warning was added on the
client-side if a non-default profile was set.

Docker Engine 23.0 (API v1.42) added warnings about non-default seccomp
profiles to the "info" response ([moby/moby@04f932a]), and the client was
updated to skip generating client-side warnings for API v1.42 and up in
[docker/cli@8964595].

These warnings are purely informational, and given that Docker Engine versions
before 23.0 have reached EOL, and any current version of the Engine now returns
the Warnings, it should be safe to remove the client-side fall back logic.

This patch removes the client-side fall back code for warnings that was
added in 8964595692.

[moby/moby@b237189]: https://github.com/moby/moby/commit/b237189e6c8a4f97be59f08c63cdcb1f2f4680a8
[moby/moby@04f932a]: https://github.com/moby/moby/commit/04f932ac862c05a5af2a5950b5e1744100b14eea
[docker/cli@8964595]: https://github.com/docker/cli/commit/8964595692766444fb84445931889677af5f55eb

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2024-01-23 18:23:35 +01:00
Sebastiaan van StijnandGitHub c6ae74956c Merge pull request #4808 from thaJeztah/remove_printServerWarningsLegacy 
info: remove printServerWarningsLegacy
 2024-01-23 18:22:58 +01:00
Sebastiaan van StijnandGitHub 69a4fcc3bb Merge pull request #4810 from thaJeztah/remove_deprecated_cliopts 
cli/command: remove deprecated DockerCliOption, InitializeOpt
 2024-01-23 18:22:28 +01:00
Sebastiaan van StijnandGitHub ea84a3fc31 Merge pull request #4811 from thaJeztah/remove_deprecated_NewStartOptions 
cli/command/container: remove deprecated NewStartOptions
 2024-01-23 18:22:03 +01:00
Sebastiaan van StijnandGitHub 1e8555a38e Merge pull request #4818 from dvdksn/docs-dockerd-host-gateway-ip-daemonconfig 
docs: update host-gateway-ip to use daemon.json instead of cli flag
 2024-01-23 15:55:03 +01:00
David Karlsson ec0a62436e docs: update host-gateway-ip to use daemon.json instead of cli flag 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
 2024-01-23 15:45:59 +01:00
Laura Brehm 469bfc05ed tests: add tests for cli-plugins/socket 
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
 2024-01-23 14:19:33 +00:00
Sebastiaan van StijnandGitHub c89975d531 Merge pull request #4814 from thaJeztah/update_compose 
Dockerfile: update docker compose to v2.24.2
 2024-01-23 11:04:31 +01:00