Sebastiaan van Stijn
016304f346
ContainerExecAttach used `types.ExecConfig` instead of `types.ExecStartCheck`, which is the type that's expected by the `/exec/execid/start` API endpoint. Investigating when this inconsistency was introduced, I found that the client has sent the additional properties since its first imlpementation in c786a8ee5e9db8f5f609cf8721bd1e1513fb0043. The `postContainerExecStart()` at that time used the "jobs" package, which only took the information from the body that was needed (`Detach` and `Tty`). Commit 24425021d26f29a475702064181e6c99fb6bd1c5 refactored the Exec commands to remove the "jobs", and introduced the `ExecStartCheck` type, but failed to update the `cli.hijack()` call with the new type. The change in this patch should not affect compatibility with older clients, as the additional information from the `ExecConfig` type is not used (the API server already decodes to the `ExecStartCheck` type). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5fee8bddfeb9b268f3e0b3c91e0932ee9a5eff83 Component: engine