The logic used in this function was confusing; some errors were ignored, but responses handled regardless. The intent here is to try to detect whether the destination exists inside the container and is of the right "type" (otherwise produce an error). Failing to "stat" the path in the container means we can't produce a nice error for the user, but we'll continue the request, which either would succeed or produce an error returned by the daemon. While working on this patch, I noticed that some error-handling on the daemon side is incorrect. This patch does not fix those cases, but makes the logic slightly easier to follow (we should consider extracting the "stat" code to a separate function though). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Docker CLI
About
This repository is the home of the Docker CLI.
Development
docker/cli is developed using Docker.
Build CLI from source:
docker buildx bake
Build binaries for all supported platforms:
docker buildx bake cross
Build for a specific platform:
docker buildx bake --set binary.platform=linux/arm64
Build dynamic binary for glibc or musl:
USE_GLIBC=1 docker buildx bake dynbinary
Run all linting:
docker buildx bake lint shellcheck
Run test:
docker buildx bake test
List all the available targets:
make help
In-container development environment
Start an interactive development environment:
make -f docker.Makefile shell
Legal
Brought to you courtesy of our legal counsel. For more context, see the NOTICE document in this repo.
Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.
It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.
For more information, see https://www.bis.doc.gov
Licensing
docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.