docs/maintainers/handbook.md aktualisiert #278
Reference in New Issue
Block a user
No description provided.
Delete Branch "lambdabundesverband-patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Thats how I until now understood process of adding an env var. Thought it might help other's who are new. I am very open to suggestions, other best practices, corrected typos...
💖
@ -127,0 +135,4 @@# ... other existing envs```With `${REQUIRE_AUTH_FOR_PROFILE_REQUESTS:-false}` you set a default value (`false`), ensuring not to break existing deployments.I think the only missing point here is that you know sometimes you are breaking stuff. In that case, you can let the rest know they need to take action with a release note. I think that would be a good addition to add somewhere.
thanks, added this advice.
@ -127,0 +151,4 @@#REQUIRE_AUTH_FOR_PROFILE_REQUESTS=true```3. now you can use the environment-variable in your `.tmpl` files, e.g. add to `homserver.yaml.tmpl`I think when you use env vars in .tmpl files you don't need to set the environment variable in the docker-compose file. You could split the example in two:
Thanks for the idea.
I don't have time at the moment to do this, but I keep that in mind and would use the next time I add an env var to a recipe to update this :)
@lambdabundesverband any updates on this one?
ah sorry I lost track of this. now i did "rebase" here and wasn't aware that would directly merge to main. hope i didn't break something @decentral1se
That's cool, it's done so @lambdabundesverband 😃 Idk if you wanna loop back and deal with https://git.coopcloud.tech/toolshed/docs.coopcloud.tech/pulls/278/files#issuecomment-25086 but it's up to you! Feel free to do whatever. Thanks!