Merge pull request #4 from GoIncremental/4-windows-line-returns

Tests failing on Windows
This commit is contained in:
John Barton
2014-07-14 19:35:09 +10:00
2 changed files with 12 additions and 4 deletions

View File

@ -16,8 +16,8 @@ and all the env vars declared in .env will be avaiable through os.Getenv("SOME_E
package godotenv package godotenv
import ( import (
"bufio"
"errors" "errors"
"io/ioutil"
"os" "os"
"strings" "strings"
) )
@ -87,14 +87,21 @@ func loadFile(filename string) (err error) {
} }
func readFile(filename string) (envMap map[string]string, err error) { func readFile(filename string) (envMap map[string]string, err error) {
content, err := ioutil.ReadFile(filename) file, err := os.Open(filename)
// content, err := ioutil.ReadFile(filename)
if err != nil { if err != nil {
return return
} }
defer file.Close()
envMap = make(map[string]string) envMap = make(map[string]string)
lines := strings.Split(string(content), "\n") var lines []string
scanner := bufio.NewScanner(file)
for scanner.Scan() {
lines = append(lines, scanner.Text())
}
for _, fullLine := range lines { for _, fullLine := range lines {
if !isIgnoredLine(fullLine) { if !isIgnoredLine(fullLine) {

View File

@ -32,7 +32,8 @@ func loadEnvAndCompareValues(t *testing.T, envFileName string, expectedValues ma
func TestLoadWithNoArgsLoadsDotEnv(t *testing.T) { func TestLoadWithNoArgsLoadsDotEnv(t *testing.T) {
err := Load() err := Load()
if err.Error() != "open .env: no such file or directory" { pathError := err.(*os.PathError)
if pathError == nil || pathError.Op != "open" || pathError.Path != ".env"{
t.Errorf("Didn't try and open .env by default") t.Errorf("Didn't try and open .env by default")
} }
} }