Abra ignores comments in .env files #167

New Issue

2021-09-14T13:31:57Z

knoflook commented

2021-09-14 13:31:57 +00:00

Describe the current behavior

When trying to deploy traefik I encountered a very irritating issue where it wouldn't let me deploy because
FATA[0003] service app: secret not found: appname_ovh_consumer_key_v1
also this secret is not generated even when SECRET_OVH_CONSUMER_KEY=v1 is uncommented

Steps to reproduce

abra app new traefik
choose the server etc
abra app config <new app name>
put your domain etc but leave OVH configuration commented
abra fails
workaround: uncomment OVH_ENABLED and set it to 0

Describe the expected behavior

deploy successfuly

Additional information

version: 0.1.2-alpha-719e24e

## Describe the current behavior When trying to deploy traefik I encountered a very irritating issue where it wouldn't let me deploy because `FATA[0003] service app: secret not found: appname_ovh_consumer_key_v1` also this secret is not generated even when `SECRET_OVH_CONSUMER_KEY=v1` is uncommented ## Steps to reproduce `abra app new traefik` choose the server etc `abra app config <new app name>` put your domain etc but leave OVH configuration commented abra fails workaround: uncomment OVH_ENABLED and set it to 0 ## Describe the expected behavior deploy successfuly ## Additional information  - version: 0.1.2-alpha-719e24e

knoflook added the bug abra labels 2021-09-14 13:31:57 +00:00

decentral1se added this to the (deleted) milestone 2021-09-14 14:29:11 +00:00

decentral1se referenced this issue from a commit

2021-09-16 07:45:14 +00:00

fix: log which compose files are being loaded

decentral1se commented

2021-09-16 07:47:15 +00:00

I think this is a symptom of two issues:

In 0.1.2-alpha-719e24e, our godotenv fork was not loaded which means env loading is broken. This was fixed in f39c8cbe21. That might fix the issues with generation/skipping based on comments.
This happened and in 0.1.2-alpha-719e24e, I am not sure that abra knows how to select the right compose files yet.

I just ran ./abra app check mytraefik and saw:

FATA[0000] /home/foo/.abra/servers/myserver/mytraefik.env is missing COMPOSE_FILE

That is good! We could add the abra app check mytraefik logic into a "pre-check flight" before deploy?

I've also added 20ecdb8061 which will let you know which compose files are being selected when using --debug.

I would say try again using latest abra and lemme know what you face?

I think this is a symptom of two issues: - In `0.1.2-alpha-719e24e`, our `godotenv` fork was not loaded which means env loading is broken. This was fixed in https://git.coopcloud.tech/coop-cloud/abra/commit/f39c8cbe2145e3432a2bf5cc91ea001a01eb77b4. That might fix the issues with generation/skipping based on comments. - [This happened](https://git.coopcloud.tech/coop-cloud/traefik/pulls/27/files) and in `0.1.2-alpha-719e24e`, I am not sure that `abra` knows how to select the right compose files yet. I just ran `./abra app check mytraefik` and saw: ``` FATA[0000] /home/foo/.abra/servers/myserver/mytraefik.env is missing COMPOSE_FILE ``` That is good! We could add the `abra app check mytraefik` logic into a "pre-check flight" before deploy? I've also added https://git.coopcloud.tech/coop-cloud/abra/commit/20ecdb80611349b58122d90e1fd0b52c07a51cce which will let you know which compose files are being selected when using `--debug`. I would say try again using latest abra and lemme know what you face?

decentral1se commented

2021-09-16 07:58:04 +00:00

Or also: https://git.coopcloud.tech/coop-cloud/abra/releases/tag/0.1.3-alpha