pulling a file from remote machine never finishes #245

New Issue

2021-11-13T19:43:23Z

knoflook commented

2021-11-13 19:43:23 +00:00

Describe the current behavior

abra hangs when pulling a file from a remote machine

Steps to reproduce

abra app cp <appname> app:/entrypoint.sh entrypoint
app is a newly deployed traefik instance

~/./a/traefik> git log -1
commit ec47f5c9dd590bd79295303139355627c67cf7c0 (HEAD, tag: 1.0.0+v2.5.2)
Author: decentral1se <lukewm@riseup.net>
Date:   Tue Oct 12 11:41:53 2021 +0200

    chore: first release

> abra -v 
abra version 0.3.1-alpha-rc1-fcbf41e

Describe the expected behavior

pull the file

Any idea how this might be fixed?

nope

Additional information

DEBU[0000] found context connection details &{user1 cc.marinara.xyz 22} for cc.marinara.xyz  caller="/drone/src/pkg/ssh/ssh.go:493 GetContextConnDetails"
DEBU[0000] server SSH host key present in ~/.ssh/known_hosts for cc.marinara.xyz  caller="/drone/src/pkg/ssh/ssh.go:279 GetHostKey"
DEBU[0000] created client for 'cc.marinara.xyz'          caller="/drone/src/pkg/client/client.go:58 New"
DEBU[0000] commandconn: starting ssh with [-o ConnectTimeout=5 -l p0rt -p 22 -- cc.marinara.xyz docker system dial-stdio]  caller="/drone/src/pkg/upstream/commandconn/commandconn.go:49 New"
DEBU[0000] retrieved 'ac8387f9689a' as target container on 'cc.marinara.xyz'  caller="/drone/src/cli/app/cp.go:94 glob..func23"

## Describe the current behavior abra hangs when pulling a file from a remote machine ## Steps to reproduce `abra app cp <appname> app:/entrypoint.sh entrypoint` app is a newly deployed traefik instance ``` ~/./a/traefik> git log -1 commit ec47f5c9dd590bd79295303139355627c67cf7c0 (HEAD, tag: 1.0.0+v2.5.2) Author: decentral1se <lukewm@riseup.net> Date: Tue Oct 12 11:41:53 2021 +0200 chore: first release > abra -v abra version 0.3.1-alpha-rc1-fcbf41e ``` ## Describe the expected behavior pull the file ## Any idea how this might be fixed? nope ## Additional information ``` DEBU[0000] found context connection details &{user1 cc.marinara.xyz 22} for cc.marinara.xyz caller="/drone/src/pkg/ssh/ssh.go:493 GetContextConnDetails" DEBU[0000] server SSH host key present in ~/.ssh/known_hosts for cc.marinara.xyz caller="/drone/src/pkg/ssh/ssh.go:279 GetHostKey" DEBU[0000] created client for 'cc.marinara.xyz' caller="/drone/src/pkg/client/client.go:58 New" DEBU[0000] commandconn: starting ssh with [-o ConnectTimeout=5 -l p0rt -p 22 -- cc.marinara.xyz docker system dial-stdio] caller="/drone/src/pkg/upstream/commandconn/commandconn.go:49 New" DEBU[0000] retrieved 'ac8387f9689a' as target container on 'cc.marinara.xyz' caller="/drone/src/cli/app/cp.go:94 glob..func23" ```

knoflook added the bug abra labels 2021-11-13 19:43:23 +00:00

decentral1se commented

2021-11-13 21:45:11 +00:00

Could reproduce this ☺️

abra app cp <appname> app:/entrypoint.sh entrypoint does hang for me but abra app cp <appname> app:/entrypoint.sh . does not where entrypoint -> . which is a path. It seems to hang because entrypoint is not an existing folder on the local file system.

Idk what is causing the root of that issue but I'll add a check for the existence of the local path and expand the documentation for this command.

Could reproduce this ☺️ `abra app cp <appname> app:/entrypoint.sh entrypoint` does hang for me but `abra app cp <appname> app:/entrypoint.sh .` does not where `entrypoint` -> `.` which is a path. It seems to hang because `entrypoint` is not an existing folder on the local file system. Idk what is causing the root of that issue but I'll add a check for the existence of the local path and expand the documentation for this command.

decentral1se commented

2021-11-13 21:48:09 +00:00

The remote case does work.

➜  abra (main) ✗ ./abra app cp foo.com myfile app:/DOESNTEXIST  
FATA[0000] Error: No such container:path: ...:/DOESNTEXIST

The remote case does work. ``` ➜ abra (main) ✗ ./abra app cp foo.com myfile app:/DOESNTEXIST FATA[0000] Error: No such container:path: ...:/DOESNTEXIST ```

decentral1se referenced this issue from a commit

2021-11-13 21:50:52 +00:00

docs: document app cp command syntax

decentral1se referenced this issue from a commit

2021-11-13 21:50:53 +00:00

fix: check local path exists

decentral1se commented

2021-11-13 21:51:12 +00:00

Should be fixed now, lemme know if not 👍

decentral1se added the awaiting-feedback label 2021-11-13 22:17:37 +00:00

decentral1se commented

2021-11-22 17:40:09 +00:00