abra recipe release - show diff / don't git add . #466

New Issue

yksflip · 2023-07-19T16:06:41Z

yksflip commented

2023-07-19 16:06:41 +00:00

I've heard that one could easily add unwanted files to a recipe in the process of recipe upgrade:

e.g.

$ touch blabla.txt
$ abra r u foo
$ abra r s foo
$ abra r rl foo

I guess that abra recipe release executes a git add . at this point?

I'd suggest to rather do smth like git add compose.yml (or is it possible that .overwrite.yml files have updated labels?!) or show a git diff before.
Maybe this is also a good point to review the upgrade and write last-minute upgrade notes :D

I've heard that one could easily add unwanted files to a recipe in the process of recipe upgrade: e.g. ``` $ touch blabla.txt $ abra r u foo $ abra r s foo $ abra r rl foo ``` I guess that `abra recipe release` executes a `git add .` at this point? I'd suggest to rather do smth like `git add compose.yml` (or is it possible that `.overwrite.yml` files have updated labels?!) or show a `git diff` before. Maybe this is also a good point to review the upgrade and write last-minute upgrade notes :D

yksflip added the

enhancement

label 2023-07-19 16:06:41 +00:00

decentral1se commented

2023-07-19 22:22:29 +00:00

Yeh right, good to address this.

I guess that abra recipe release executes a git add . at this point?

Yep 🙃 a7ce71d6cf/cli/recipe/release.go (L247)

I'd suggest to rather do smth like git add compose.yml (or is it possible that .overwrite.yml files have updated labels?!) or show a git diff before.

Hmmm it's hard to know what is and isn't being hacked on at commit time. But perhaps we could filter on only "dirty" files, meaning, stuff Git already knows about? And you choose to commit new files yourself, e.g. a new releases directory? That might leave people wondering why some stuff gets committed and other stuff not... so could be a documentation issue also.

Yeh right, good to address this. > I guess that abra recipe release executes a git add . at this point? Yep 🙃 https://git.coopcloud.tech/coop-cloud/abra/src/commit/a7ce71d6cfe0e47900cfff51db32885187f10647/cli/recipe/release.go#L247 > I'd suggest to rather do smth like git add compose.yml (or is it possible that .overwrite.yml files have updated labels?!) or show a git diff before. Hmmm it's hard to know what is and isn't being hacked on at commit time. But perhaps we could filter on only "dirty" files, meaning, stuff Git already knows about? And you choose to commit new files yourself, e.g. a new `releases` directory? That might leave people wondering why some stuff gets committed and other stuff not... so could be a documentation issue also.

decentral1se self-assigned this 2023-10-04 13:25:06 +00:00

decentral1se commented

2023-10-04 13:25:35 +00:00