Remove --no-domain-checks; warn on abra server add #631

New Issue

2024-07-24T15:47:49Z

p4u1 commented

2024-07-24 15:47:49 +00:00

When adding a new server abra does a domain check by default. After coop-cloud/abra#415 it is possible to specify non TLD resolving host names. The domain check can be confusing in those cases. Maybe it would be better to only show a warning when the server is not dns resolvable. The warning could also metion that this could lead to problems with traefik.

Related #566

When adding a new server abra does a domain check by default. After coop-cloud/abra#415 it is possible to specify non TLD resolving host names. The domain check can be confusing in those cases. Maybe it would be better to only show a warning when the server is not dns resolvable. The warning could also metion that this could lead to problems with traefik. Related #566

👍 1

p4u1 added the abra label 2024-07-24 15:48:01 +00:00

decentral1se commented

2024-07-24 18:59:18 +00:00

Nice. However, when you choose a not-resolvable-domain, you'll always see this warning 🥵

I think it was a nice idea to try to help operators by doing this automatically but we're starting to see quite a few limits in this kind of design when the use cases get more diverse. It fits one but not the other and CLI ergonomics are suffering.

Maybe a third way is to start to move the choice into the abra config file. Something like:

# $ABRA_DIR/abra.yml

resolve_dns: true

And the default is resolve_dns: false (change in behaviour)?

The advantage is that we'll also speed up operations by disabling it. I do think about how to make abra fast again. Maybe this is also a slow phase shift from "make it work" to "make it work fast".

Nice. However, when you choose a not-resolvable-domain, you'll always see this warning 🥵 I think it was a nice idea to try to help operators by doing this automatically but we're starting to see quite a few limits in this kind of design when the use cases get more diverse. It fits one but not the other and CLI ergonomics are suffering. Maybe a third way is to start to move the choice into the `abra` config file. Something like: ```yaml # $ABRA_DIR/abra.yml resolve_dns: true ``` And the default is `resolve_dns: false` (change in behaviour)? The advantage is that we'll also speed up operations by disabling it. I do think about how to make `abra` fast again. Maybe this is also a slow phase shift from "make it work" to "make it work fast".

decentral1se added the question label 2024-07-24 19:01:15 +00:00

~~decentral1se referenced this issue 2024-07-24 19:48:02 +00:00~~

`abra` v0.10.x-beta release planning #583

p4u1 commented

2024-07-24 21:52:41 +00:00

My thought was to only show the warning on Abra server add. I'm hesitant with adding a config option in generall if we can solve the problem without one

👍 1

decentral1se commented

2024-07-25 21:01:11 +00:00

Oh yeh, that's actually pretty great. 👍 for me then to drop -D and only warn on abra server add.

Oh yeh, that's actually pretty great. 👍 for me then to drop `-D` and only warn on `abra server add`.

decentral1se added good first issue and removed question labels 2024-07-27 10:36:41 +00:00

decentral1se changed title from ~~Discuss if domain check is necessary~~ to Remove --no-domain-checks; warn on `abra server add`

2024-07-27 10:37:26 +00:00

decentral1se added the enhancement label 2024-07-27 10:37:34 +00:00

fauno commented

2024-11-05 12:45:30 +00:00

in our case the coopcloud server is behind a reverse proxy so we always have to add the app to the internal domain (server.comun) but create the app on the public domain (server.abyaya.la) and deploy with --no-domain-checks.

👍 1

ammaratef45 referenced this issue from toolshed/abra

2024-11-26 01:25:50 +00:00

#631: remove -D on server add #448

ammaratef45 commented

2024-11-26 01:28:35 +00:00

Does this PR implement what we're talking about here? coop-cloud/abra#448

Does this PR implement what we're talking about here? https://git.coopcloud.tech/coop-cloud/abra/pulls/448

decentral1se referenced this issue from toolshed/abra

2024-11-27 14:55:50 +00:00

#631: remove -D on server add #448

ammaratef45 commented

2024-11-27 19:50:40 +00:00

PR above merged, it only removes the -D from server add, I can remove it from other commands like deploy and app new ..etc if necessary
/cc @fauno

PR above merged, it only removes the `-D` from `server add`, I can remove it from other commands like `deploy` and `app new` ..etc if necessary /cc @fauno

❤️ 1

decentral1se referenced this issue from toolshed/docs.coopcloud.tech

2025-01-10 10:14:30 +00:00

Operators tutorial update #265

decentral1se commented

2025-03-16 23:15:29 +00:00

Let's say this one is solved for now based on lack of new feedback and the work done in #631 (comment). Please feel free to re-open if you feel strongly about it. Thanks @ammaratef45!

Let's say this one is solved for now based on lack of new feedback and the work done in https://git.coopcloud.tech/toolshed/organising/issues/631#issuecomment-21760. Please feel free to re-open if you feel strongly about it. Thanks @ammaratef45!

decentral1se closed this issue

2025-03-16 23:15:29 +00:00

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/organising#631

Remove --no-domain-checks; warn on abra server add #631

Remove --no-domain-checks; warn on `abra server add` #631