Remove --no-domain-checks; warn on abra server add
#631
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: toolshed/organising#631
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When adding a new server abra does a domain check by default. After coop-cloud/abra#415 it is possible to specify non TLD resolving host names. The domain check can be confusing in those cases. Maybe it would be better to only show a warning when the server is not dns resolvable. The warning could also metion that this could lead to problems with traefik.
Related #566
Nice. However, when you choose a not-resolvable-domain, you'll always see this warning 🥵
I think it was a nice idea to try to help operators by doing this automatically but we're starting to see quite a few limits in this kind of design when the use cases get more diverse. It fits one but not the other and CLI ergonomics are suffering.
Maybe a third way is to start to move the choice into the
abraconfig file. Something like:And the default is
resolve_dns: false(change in behaviour)?The advantage is that we'll also speed up operations by disabling it. I do think about how to make
abrafast again. Maybe this is also a slow phase shift from "make it work" to "make it work fast".decentral1se referenced this issue2024-07-24 19:48:02 +00:00
My thought was to only show the warning on Abra server add. I'm hesitant with adding a config option in generall if we can solve the problem without one
Oh yeh, that's actually pretty great. 👍 for me then to drop
-Dand only warn onabra server add.Discuss if domain check is necessaryto Remove --no-domain-checks; warn on `abra server add`in our case the coopcloud server is behind a reverse proxy so we always have to add the app to the internal domain (server.comun) but create the app on the public domain (server.abyaya.la) and deploy with --no-domain-checks.
Does this PR implement what we're talking about here? coop-cloud/abra#448
PR above merged, it only removes the
-Dfromserver add, I can remove it from other commands likedeployandapp new..etc if necessary/cc @fauno
Let's say this one is solved for now based on lack of new feedback and the work done in #631 (comment). Please feel free to re-open if you feel strongly about it. Thanks @ammaratef45!