The readiness panel says whether members can find a product by a rule the catalog no longer uses #178
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#178
Reference in New Issue
Block a user
The readiness panel (
internal/server/product_readiness.go) decides findability from whether a product is a plan tier or carries theaddondisplay category. The catalog (buildAddonsData,internal/server/member_products.go) lists every published public product outside plan tiers whose default price is active, recurring and synced, whatever its category. So a recurring product without a category is listed while the panel says it is not, and anaddonproduct with a one-time price is hidden while the panel says it is shown and Purchasable. The panel branches on the display category, which the catalog model forbids. The model page and one requirement of the member catalog spec still state the old rule, and that spec contradicts itself.Done when: the panel and the catalog call one predicate, the one Checkout uses outside plan tiers (#175); tests cover both mismatches; and the model page and spec agree.
The predicate this issue asks for now exists:
plans.OffLadder(internal/plans/offer.go) decides Checkout for a product that is a tier of no ladder (listed for members; default price active, recurring and reachable in Stripe), and Checkout and the add-ons list both call it. The panel also misses recurrence for plan tiers: it says Purchasable for a tier whose default price is one-time, which the Products page now draws as not purchasable and Checkout refuses.plans.Offerdecides that case for tiers, so the panel can take its verdict from the two functions.