PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Insert domain into invite #125

Merged
notplants merged 1 commits from insert-invite into main 2022-06-30 13:00:47 +00:00
Conversation 2 Commits 1 Files Changed 3
+10 -4
notplants commented 2022-06-29 20:25:54 +00:00
Owner
Copy Link
Copy Source

If a domain is configured, it replaces [::] in the invite with the domain, and if not it leaves it.

A config variable for configuring a domain was already created earlier as part of dynamic dns route. The config variable was named EXTERNAL_DOMAIN to differentiate it from DYN_DOMAIN (another configurable variable).

If a domain is configured, it replaces [::] in the invite with the domain, and if not it leaves it. A config variable for configuring a domain was already created earlier as part of dynamic dns route. The config variable was named EXTERNAL_DOMAIN to differentiate it from DYN_DOMAIN (another configurable variable).
Screen Shot 2022-06-29 at 4.22.41 PM.png
27 KiB
Screen Shot 2022-06-29 at 4.22.41 PM.png
notplants added 1 commit 2022-06-29 20:25:55 +00:00
Insert domain into invite
continuous-integration/drone/pr Build is passing
Details
6621a09ec9
notplants requested review from glyph 2022-06-29 20:26:04 +00:00
glyph added the enhancementpeach-web labels 2022-06-30 10:15:46 +00:00
glyph approved these changes 2022-06-30 10:17:23 +00:00
glyph left a comment
Owner
Copy Link
Copy Source

Great, looks good to me.

It would be good to document all of the config variables in the peach-lib README at some point and link to it from the peach-web README.

Great, looks good to me. It would be good to document all of the config variables in the `peach-lib` README at some point and link to it from the `peach-web` README.
👍 1
notplants commented 2022-06-30 13:00:41 +00:00
Author
Owner
Copy Link
Copy Source

@glyph agreed, made an issue for that here #126

@glyph agreed, made an issue for that here https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/126
notplants merged commit fba1e91d8b into main 2022-06-30 13:00:47 +00:00
notplants deleted branch insert-invite 2022-06-30 13:00:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
glyph
Labels
Clear labels
bug
Something is not working
 documentation
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 maintenance
Pruning and weeding
 peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
 refactor
Code rewrite
 wontfix
This won't be fixed
No labels enhancement peach-web
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cblgh glyph (glyph) notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#125