This ended up getting a bit complicated. I had to update peach-network because the public API of one of our dependencies changed (wpa-ctrl-rs). Everything is now compiling.
This PR introduces the keystore selector which was just added to golgi in [PR #39](https://git.coopcloud.tech/golgi-ssb/golgi/pulls/39).
The update effects `peach-web` and `peach-lib`. I have also updated the dependencies (as represented by the changed lockfile).
CC: @notplants
-----
Update:
This ended up getting a bit complicated. I had to update `peach-network` because the public API of one of our dependencies changed (`wpa-ctrl-rs`). Everything is now compiling.
I think that's nice to have as a convenience but we would still want to allow for a unique path to be supplied. I'd suggest we do that with an additional enum variant:
Then we could still use the read_patchwork_config() function from kuska to parse the file content into an instance of OwnedIdentity.
Regarding your question about hardcoding:
> i haven't looked into how kuska-ssb handles the keystore selection, but I wonder if they hard-code the ssb-go folder location
They hardcode the location: https://github.com/Kuska-ssb/ssb/blob/master/src/keystore/patchwork.rs#L13
I think that's nice to have as a convenience but we would still want to allow for a unique path to be supplied. I'd suggest we do that with an additional enum variant:
```rust
enum Keystore {
Patchwork,
GoSbot,
Custom(Path)
}
```
Usage would be something like this:
```rust
let path = Path::new("./unique/secret");
let mut sbot_client = Sbot::init(Keystore::Custom(path), None, None).await?;
```
Then we could still use the `read_patchwork_config()` function from kuska to parse the file content into an instance of `OwnedIdentity`.
glyph
merged commit bf7f2c8e31 into main2022-05-16 13:12:01 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
notplants
This PR introduces the keystore selector which was just added to golgi in PR #39.
The update effects
peach-webandpeach-lib. I have also updated the dependencies (as represented by the changed lockfile).CC: @notplants
Update:
This ended up getting a bit complicated. I had to update
peach-networkbecause the public API of one of our dependencies changed (wpa-ctrl-rs). Everything is now compiling.@notplants
Could you take a peek at this and make sure it all looks good to you? I ended up having to make some small updates to
peach-network.nice ~ new golgi code coming in
Regarding your question about hardcoding:
They hardcode the location: https://github.com/Kuska-ssb/ssb/blob/master/src/keystore/patchwork.rs#L13
I think that's nice to have as a convenience but we would still want to allow for a unique path to be supplied. I'd suggest we do that with an additional enum variant:
Usage would be something like this:
Then we could still use the
read_patchwork_config()function from kuska to parse the file content into an instance ofOwnedIdentity.I'm working on this right now