golgi-ssb
/
golgi
4
5
Fork 0
Code Issues 11 Pull Requests 1 Projects 1 Releases Wiki Activity

Add support for custom keyfile paths #41

Merged
notplants merged 7 commits from keypaths into main 2022-06-15 10:27:29 +00:00
Conversation 5 Commits 7 Files Changed 4 +34 -8
notplants commented 2022-05-25 11:49:54 +00:00
Owner
Copy Link
No description provided.
notplants added 1 commit 2022-05-25 11:49:55 +00:00
notplants commented 2022-05-25 11:50:21 +00:00
Author
Owner
Copy Link

based on this issue: PeachCloud/peach-workspace#107 (comment)

based on this issue: https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/107#issuecomment-13055
notplants commented 2022-05-25 11:52:02 +00:00
Author
Owner
Copy Link

based on this proposed change to kuska:
48adac914f

can make a PR to upstream

based on this proposed change to kuska: https://github.com/mhfowler/kuska-ssb/commit/48adac914fd2288abcc267560c5a3e013a072003 can make a PR to upstream
notplants commented 2022-05-25 12:52:39 +00:00
Author
Owner
Copy Link

And here is the relevant PR in peach-web: PeachCloud/peach-workspace#115

And here is the relevant PR in peach-web: https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/115
notplants commented 2022-05-25 12:55:31 +00:00
Author
Owner
Copy Link

And here is the relevant PR for kuska: https://github.com/Kuska-ssb/ssb/pull/26

And here is the relevant PR for kuska: https://github.com/Kuska-ssb/ssb/pull/26
glyph commented 2022-06-08 08:03:23 +00:00
Owner
Copy Link

@notplants

Sweet. I've commented on the kuska PR. I'll review this properly once that has been checked by Adria and merged.

@notplants Sweet. I've commented on the kuska PR. I'll review this properly once that has been checked by Adria and merged.
glyph requested changes 2022-06-14 07:25:21 +00:00
glyph left a comment
Owner
Copy Link

Just left a tiny note about the kuska dependency definition, otherwise this looks good to merge.

Just left a tiny note about the kuska dependency definition, otherwise this looks good to merge.
Cargo.toml Outdated
@ -20,3 +20,3 @@
kuska-handshake = { version = "0.2.0", features = ["async_std"] }
kuska-sodiumoxide = "0.2.5-0"
kuska-ssb = { git = "https://github.com/Kuska-ssb/ssb" }
#kuska-ssb = { git = "https://github.com/Kuska-ssb/ssb" }
glyph commented 2022-06-14 07:24:45 +00:00
Owner
Copy Link

Don't forget to revert this dependency now that the kuska PR has been merged ;)

Don't forget to revert this dependency now that the kuska PR has been merged ;)
notplants added 5 commits 2022-06-15 10:12:31 +00:00
notplants added 1 commit 2022-06-15 10:27:13 +00:00
notplants merged commit ca4c1114dd into main 2022-06-15 10:27:29 +00:00
notplants deleted branch keypaths 2022-06-15 10:27:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
glyph
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#41
No description provided.
Delete Branch "keypaths"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?