PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Miniserde refactor with custom error impls #11

Merged
glyph merged 7 commits from miniserde_refactor into main 2021-11-02 09:33:26 +00:00
Conversation 1 Commits 7 Files Changed 6 +77 -71
glyph commented 2021-11-01 12:21:39 +00:00
Owner
Copy Link

The nature and results of this refactor are discussed in the linked issue: #9 (comment)

The commit messages tell the story:

  • replace serde with miniserde (fewer dependencies)
  • move jsonrpc_test to dev deps (only gets compiled when running cargo test)
  • remove snafu and replace with handwritten error code (shorter compile time)
  • update dependencies to latest
  • change rpc methods to async (made possible by latest jsonrpc crates)
  • API change: uptime now only returns secs, not secs and nanos as before

43% reduction in total dependencies
20% reduction in compile time
16% reduction in binary size

Overall, a relatively small number of code changes result in a lighter crate with almost identical functionality.

The nature and results of this refactor are discussed in the linked issue: https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/9#issuecomment-9873 The commit messages tell the story: - replace serde with miniserde (fewer dependencies) - move jsonrpc_test to dev deps (only gets compiled when running `cargo test`) - remove snafu and replace with handwritten error code (shorter compile time) - update dependencies to latest - change rpc methods to async (made possible by latest jsonrpc crates) - **API change**: `uptime` now only returns `secs`, not `secs` and `nanos` as before 43% reduction in total dependencies 20% reduction in compile time 16% reduction in binary size Overall, a relatively small number of code changes result in a lighter crate with almost identical functionality.
glyph added 7 commits 2021-11-01 12:21:40 +00:00
glyph added the
refactor
 label 2021-11-01 12:22:00 +00:00
glyph requested review from notplants 2021-11-01 12:22:06 +00:00
glyph added the
peach-stats
 label 2021-11-01 12:31:41 +00:00
notplants commented 2021-11-02 09:02:20 +00:00
Owner
Copy Link

LGTM

comments here #9 (comment)

LGTM comments here https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/9#issuecomment-9917
👍 1
glyph merged commit 35a524e9db into main 2021-11-02 09:33:26 +00:00
glyph deleted branch miniserde_refactor 2021-11-02 09:34:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-stats
refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#11
No description provided.
Delete Branch "miniserde_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?