Miniserde refactor with custom error impls #11

glyph · 2021-11-01T12:21:39Z

glyph commented

2021-11-01 12:21:39 +00:00

The nature and results of this refactor are discussed in the linked issue: #9 (comment)

The commit messages tell the story:

replace serde with miniserde (fewer dependencies)
move jsonrpc_test to dev deps (only gets compiled when running cargo test)
remove snafu and replace with handwritten error code (shorter compile time)
update dependencies to latest
change rpc methods to async (made possible by latest jsonrpc crates)
API change: uptime now only returns secs, not secs and nanos as before

43% reduction in total dependencies
20% reduction in compile time
16% reduction in binary size

Overall, a relatively small number of code changes result in a lighter crate with almost identical functionality.

The nature and results of this refactor are discussed in the linked issue: https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/9#issuecomment-9873 The commit messages tell the story: - replace serde with miniserde (fewer dependencies) - move jsonrpc_test to dev deps (only gets compiled when running `cargo test`) - remove snafu and replace with handwritten error code (shorter compile time) - update dependencies to latest - change rpc methods to async (made possible by latest jsonrpc crates) - **API change**: `uptime` now only returns `secs`, not `secs` and `nanos` as before 43% reduction in total dependencies 20% reduction in compile time 16% reduction in binary size Overall, a relatively small number of code changes result in a lighter crate with almost identical functionality.

glyph added 7 commits 2021-11-01 12:21:40 +00:00