PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Custom error implementation for peach-oled #34

Merged
glyph merged 5 commits from lean_refactor into main 2021-11-24 09:16:20 +00:00
Conversation 1 Commits 5 Files Changed 5 +143 -150
glyph commented 2021-11-23 08:57:55 +00:00
Owner
Copy Link

This is a similar refactor to the one for peach-stats in PR #11.

  • remove snafu and replace with handwritten error code
  • improve some variable names (no more single-letter variables)
  • update dependencies to latest
    • I did not update the OLED-related dependencies because there are a lot of breaking changes in those APIs (I'll do this as a separate PR sometime)
  • bump the version
This is a similar refactor to the one for `peach-stats` in [PR #11](https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/11). - remove `snafu` and replace with handwritten error code - improve some variable names (no more single-letter variables) - update dependencies to latest - I did not update the OLED-related dependencies because there are a lot of breaking changes in those APIs (I'll do this as a separate PR sometime) - bump the version
glyph added 5 commits 2021-11-23 08:57:55 +00:00
glyph requested review from notplants 2021-11-23 08:58:01 +00:00
glyph added the
refactor
 label 2021-11-23 08:58:10 +00:00
glyph added the
peach-oled
 label 2021-11-23 08:59:18 +00:00
notplants approved these changes 2021-11-24 09:12:28 +00:00
glyph merged commit 1dc740eeae into main 2021-11-24 09:16:20 +00:00
glyph deleted branch lean_refactor 2021-11-24 09:16:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-oled
refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#34
No description provided.
Delete Branch "lean_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?