refactor: remove old/non-urgen/resolved FIXMEs
This commit is contained in:
parent
6a98024a2b
commit
5cacd09a04
|
@ -183,7 +183,6 @@ can take some time.
|
||||||
stats.latestCount++
|
stats.latestCount++
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
// FIXME: jeezus golang why do you not have a list reverse function
|
|
||||||
for i, j := 0, len(newUpdates)-1; i < j; i, j = i+1, j-1 {
|
for i, j := 0, len(newUpdates)-1; i < j; i, j = i+1, j-1 {
|
||||||
newUpdates[i], newUpdates[j] = newUpdates[j], newUpdates[i]
|
newUpdates[i], newUpdates[j] = newUpdates[j], newUpdates[i]
|
||||||
}
|
}
|
||||||
|
|
|
@ -112,7 +112,6 @@ recipes.
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// FIXME: jeezus golang why do you not have a list reverse function
|
|
||||||
for i, j := 0, len(availableDowngrades)-1; i < j; i, j = i+1, j-1 {
|
for i, j := 0, len(availableDowngrades)-1; i < j; i, j = i+1, j-1 {
|
||||||
availableDowngrades[i], availableDowngrades[j] = availableDowngrades[j], availableDowngrades[i]
|
availableDowngrades[i], availableDowngrades[j] = availableDowngrades[j], availableDowngrades[i]
|
||||||
}
|
}
|
||||||
|
|
|
@ -82,11 +82,7 @@ var appRunCommand = &cli.Command{
|
||||||
execCreateOpts.Tty = false
|
execCreateOpts.Tty = false
|
||||||
}
|
}
|
||||||
|
|
||||||
// FIXME: an absolutely monumental hack to instantiate another command-line
|
// FIXME: avoid instantiating a new CLI
|
||||||
// client withing our command-line client so that we pass something down
|
|
||||||
// the tubes that satisfies the necessary interface requirements. We should
|
|
||||||
// refactor our vendored container code to not require all this cruft. For
|
|
||||||
// now, It Works.
|
|
||||||
dcli, err := command.NewDockerCli()
|
dcli, err := command.NewDockerCli()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logrus.Fatal(err)
|
logrus.Fatal(err)
|
||||||
|
|
|
@ -327,9 +327,6 @@ func GetAppStatuses(appFiles AppFiles) (map[string]map[string]string, error) {
|
||||||
if version, ok := service.Spec.Labels[labelKey]; ok {
|
if version, ok := service.Spec.Labels[labelKey]; ok {
|
||||||
result["version"] = version
|
result["version"] = version
|
||||||
} else {
|
} else {
|
||||||
//FIXME: we only need to check containers with the version label not
|
|
||||||
// every single container and then skip when we see no label perf gains
|
|
||||||
// to be had here
|
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -360,18 +360,6 @@ func deployServices(
|
||||||
encodedAuth string
|
encodedAuth string
|
||||||
)
|
)
|
||||||
|
|
||||||
// FIXME: disable for now as not sure how to avoid having a `dockerCli`
|
|
||||||
// instance here and would rather not copy/pasta that entire module in
|
|
||||||
// right now for something that we don't even support right now. Will skip
|
|
||||||
// this for now.
|
|
||||||
if sendAuth {
|
|
||||||
// Retrieve encoded auth token from the image reference
|
|
||||||
// encodedAuth, err = command.RetrieveAuthTokenFromImage(ctx, dockerCli, image)
|
|
||||||
// if err != nil {
|
|
||||||
// return err
|
|
||||||
// }
|
|
||||||
}
|
|
||||||
|
|
||||||
if service, exists := existingServiceMap[name]; exists {
|
if service, exists := existingServiceMap[name]; exists {
|
||||||
logrus.Infof("Updating service %s (id: %s)\n", name, service.ID)
|
logrus.Infof("Updating service %s (id: %s)\n", name, service.ID)
|
||||||
|
|
||||||
|
|
|
@ -45,7 +45,6 @@ function install_abra_release {
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
|
||||||
# FIXME: support different architectures
|
|
||||||
PLATFORM=$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m)
|
PLATFORM=$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m)
|
||||||
FILENAME="abra_"$ABRA_VERSION"_"$PLATFORM""
|
FILENAME="abra_"$ABRA_VERSION"_"$PLATFORM""
|
||||||
sed_command_rel='s/.*"assets":\[\{[^]]*"name":"'$FILENAME'"[^}]*"browser_download_url":"([^"]*)".*\].*/\1/p'
|
sed_command_rel='s/.*"assets":\[\{[^]]*"name":"'$FILENAME'"[^}]*"browser_download_url":"([^"]*)".*\].*/\1/p'
|
||||||
|
|
Loading…
Reference in New Issue