feat(cmd): make env variables accessible for local abra.sh commands #225

moritz · 2022-11-09T19:30:20Z

moritz commented

2022-11-09 19:30:20 +00:00

Solving this issue: coop-cloud/organising#351
My first lines of code I ever wrote in go...

Solving this issue: https://git.coopcloud.tech/coop-cloud/organising/issues/351 My first lines of code I ever wrote in go...

moritz added 1 commit 2022-11-09 19:30:21 +00:00

continuous-integration/drone/pr Build is failing Details

773a43eaa1 feat(cmd): make env variables accessible for local abra.sh commands

decentral1se requested changes 2022-11-10 10:50:24 +00:00

decentral1se left a comment

Amazing @moritz! Welcome to hell 🔥

Could you also update the remote handling? This change covers including the env vars in the --local case but not when you run the command on the container. I think you need to update this:

773a43eaa1/cli/app/cmd.go (L197)

Thanks!

Amazing @moritz! Welcome to hell 🔥 Could you also update the remote handling? This change covers including the env vars in the `--local` case but not when you run the command on the container. I think you need to update this: https://git.coopcloud.tech/coop-cloud/abra/src/commit/773a43eaa123ac957f920d4fc95c5a08c5bb715e/cli/app/cmd.go#L197 Thanks!

moritz added 1 commit 2022-11-10 10:57:41 +00:00

continuous-integration/drone/pr Build is passing Details

dd6f9d5681 Merge remote-tracking branch 'origin/main'

moritz commented

2022-11-10 11:08:34 +00:00

Amazing @moritz! Welcome to hell 🔥

Could you also update the remote handling? This change covers including the env vars in the --local case but not when you run the command on the container. I think you need to update this:

773a43eaa1/cli/app/cmd.go (L197)

Thanks!

I don't think this is necessary. In the container the env variables are alreadey accessible, because they are exported by docker.

> Amazing @moritz! Welcome to hell 🔥 > > Could you also update the remote handling? This change covers including the env vars in the `--local` case but not when you run the command on the container. I think you need to update this: > > https://git.coopcloud.tech/coop-cloud/abra/src/commit/773a43eaa123ac957f920d4fc95c5a08c5bb715e/cli/app/cmd.go#L197 > > Thanks! I don't think this is necessary. In the container the env variables are alreadey accessible, because they are exported by docker.

👍 1

decentral1se approved these changes 2022-11-10 11:12:04 +00:00

decentral1se commented

2022-11-10 11:12:27 +00:00

@moritz

I don't think this is necessary. In the container the env variables are alreadey accessible, because they are exported by docker.

Aha, indeed! Great, merging 🚀 Thanks again!

@moritz > I don't think this is necessary. In the container the env variables are alreadey accessible, because they are exported by docker. Aha, indeed! Great, merging 🚀 Thanks again!

decentral1se merged commit 9591e91ed6 into main

2022-11-10 11:12:39 +00:00

Sign in to join this conversation.

No reviewers

No Label