fix: always fetch all repository tags #266

moritz · 2023-01-31T11:04:39Z

moritz commented

2023-01-31 11:04:39 +00:00

I have encountered problems several times when upgrading, always when the tags were subsequently updated. This happens for example if abra recipe release fails and changes are pushed manually without pushing the tags.
It can be resolved by manually fetching the tags git pull --tags.
But for the automatic updater this would break the whole process.

My proposed fix is to just always fetch the tags when pulling the repository.

I have encountered problems several times when upgrading, always when the tags were subsequently updated. This happens for example if `abra recipe release` fails and changes are pushed manually without pushing the tags. It can be resolved by manually fetching the tags `git pull --tags`. But for the automatic updater this would break the whole process. My proposed fix is to just always fetch the tags when pulling the repository.

moritz added 1 commit 2023-01-31 11:04:41 +00:00

continuous-integration/drone/pr Build is failing Details

continuous-integration/drone/push Build is failing Details

32851d4d99 fix: always fetch all repository tags

decentral1se approved these changes 2023-01-31 13:00:23 +00:00

decentral1se left a comment

Strange to see there is no tags fetching option on PullOptions but then again, go-git is just confusion from start to finish 😅 LGTM for now and glad to see this once patched up! Merge as you see fit.

Strange to see there is no tags fetching option on `PullOptions` but then again, `go-git` is just confusion from start to finish 😅 LGTM for now and glad to see this once patched up! Merge as you see fit.

moritz merged commit 32851d4d99 into main

2023-01-31 13:21:57 +00:00

moritz deleted branch fetch_tags

2023-01-31 13:22:06 +00:00

decentral1se referenced this issue from a commit

2023-02-02 19:27:35 +00:00

fix: catch errors here too

Sign in to join this conversation.

No reviewers