toolshed/abra
4
3
Fork 21
Code Issues 40 Pull Requests 4 Packages Releases 42 Activity

fix: always fetch all repository tags #266

Merged
moritz merged 1 commits from moritz/abra:fetch_tags into main 2023-01-31 13:21:58 +00:00
Conversation 1 Commits 1 Files Changed 1 +5
moritz commented 2023-01-31 11:04:39 +00:00
Member
Copy Link

I have encountered problems several times when upgrading, always when the tags were subsequently updated. This happens for example if abra recipe release fails and changes are pushed manually without pushing the tags.
It can be resolved by manually fetching the tags git pull --tags.
But for the automatic updater this would break the whole process.

My proposed fix is to just always fetch the tags when pulling the repository.

I have encountered problems several times when upgrading, always when the tags were subsequently updated. This happens for example if `abra recipe release` fails and changes are pushed manually without pushing the tags. It can be resolved by manually fetching the tags `git pull --tags`. But for the automatic updater this would break the whole process. My proposed fix is to just always fetch the tags when pulling the repository.
moritz added 1 commit 2023-01-31 11:04:41 +00:00
fix: always fetch all repository tags
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
32851d4d99
decentral1se approved these changes 2023-01-31 13:00:23 +00:00
decentral1se left a comment
Owner
Copy Link

Strange to see there is no tags fetching option on PullOptions but then again, go-git is just confusion from start to finish 😅 LGTM for now and glad to see this once patched up! Merge as you see fit.

Strange to see there is no tags fetching option on `PullOptions` but then again, `go-git` is just confusion from start to finish 😅 LGTM for now and glad to see this once patched up! Merge as you see fit.
moritz merged commit 32851d4d99 into main 2023-01-31 13:21:57 +00:00
moritz deleted branch fetch_tags 2023-01-31 13:22:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#266
No description provided.
Delete Branch "moritz/abra:fetch_tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?