add label to enable/disable the auto update process #267
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#267
Loading…
Reference in New Issue
No description provided.
Delete Branch "moritz/abra:update_label"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A suggestion for enabling/disabling automatic updates per env variable
ENABLE_AUTO_UPDATE=true
.This is required for the auto updater coop-cloud/organising#236 (comment)
It adds the label
coop-cloud.${STACK_NAME}.autoupdate=${ENABLE_AUTO_UPDATE}
.With a label it is easier to access the value without parsing all the environment variables.
This looks legit to me!
It seems consisent to me that we'd require people to opt-in to auto-update. That does assume that a missing label = don't update. Assume that will be reflected in the auto-updater logic.
I think this change is missing docs, do you want to write them now? It's OK if you want to keep experimenting first. In that case, I'd open up a separate ticket so we remember to document what we're doing.
Maybe @3wordchant @knoflook have a review for this?
@ -448,2 +448,4 @@
return compose, nil
}
// add env ENABLE_AUTO_UPDATE as label to enable/disable the auto update process for this app
Go doc needs a thing like the following to generate well:
79fd23695e
to6774893412