Fix #498 #363

decentral1se · 2023-10-04T00:40:11Z

decentral1se commented

2023-10-04 00:40:11 +00:00

See coop-cloud/organising#498. Maybe not robust enough but now avoids borking when export is in the actual name of the function (🙄) and skips any indented line which has export ... in it. Which seems to most likely mean it's defined in a function. Hackity hack hack 🛠️ Uses regex, should be more stable!

379915587c is the main change. The rest is shuffling code to allow for testing.

See https://git.coopcloud.tech/coop-cloud/organising/issues/498. ~~Maybe not robust enough but now avoids borking when `export` is in the actual name of the function (🙄) and skips any indented line which has `export ...` in it. Which seems to most likely mean it's defined in a function. Hackity hack hack 🛠️~~ Uses regex, should be more stable! https://git.coopcloud.tech/coop-cloud/abra/commit/379915587c249da3b2cc1473f5c406dadc9d068f is the main change. The rest is shuffling code to allow for testing.

👀 1

decentral1se added 2 commits 2023-10-04 00:40:12 +00:00

970ae0fc4e

test: use _test to avoid cyclic imports

continuous-integration/drone/push Build is passing Details

continuous-integration/drone/pr Build is passing Details

bad686f715

fix: don't export from within function

Also, don't explode on command function which has "export" in the name!

See coop-cloud/organising#498

decentral1se force-pushed fix-498 from bad686f715 to 2fcebe8309

2023-10-04 00:42:22 +00:00

Compare

decentral1se changed title from ~~Fix #498~~ to WIP: fix #498

2023-10-04 00:55:56 +00:00

3wordchant commented

2023-10-04 08:30:13 +00:00

Looks good to me, thanks so much! 🙏

decentral1se force-pushed fix-498 from 2fcebe8309 to 379915587c

2023-10-04 09:21:30 +00:00

Compare

decentral1se changed title from ~~WIP: fix #498~~ to Fix #498

2023-10-04 09:22:59 +00:00

decentral1se merged commit 379915587c into main

2023-10-04 09:24:41 +00:00

decentral1se deleted branch fix-498

2023-10-04 09:24:41 +00:00

Sign in to join this conversation.

No reviewers

No Label