coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

fix: validate COMPOSE_FILE #365

Merged
decentral1se merged 4 commits from compose-file-validation into main 2023-10-04 12:38:57 +00:00
Conversation 0 Commits 4 Files Changed 9 +137 -42
decentral1se commented 2023-10-04 11:27:36 +00:00
Owner
Copy Link

See coop-cloud/organising#468.
See coop-cloud/organising#376.

Heuristic is to count : if present in COMPOSE_FILE=... and try to ensure the count + 1 turns up after parsing. We also now check that these files exist. I think I've got the COMPOSE_FILE="$COMPOSE_FILE:... approach covered also in the integration tests.

Reviews welcome!

See https://git.coopcloud.tech/coop-cloud/organising/issues/468. See https://git.coopcloud.tech/coop-cloud/organising/issues/376. Heuristic is to count `:` if present in `COMPOSE_FILE=...` and try to ensure the count + 1 turns up after parsing. We also now check that these files exist. I think I've got the `COMPOSE_FILE="$COMPOSE_FILE:...` approach covered also in the integration tests. Reviews welcome!
decentral1se added 1 commit 2023-10-04 11:27:37 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is passing Details
c646263e9e
fix: validate COMPOSE_FILE 
See coop-cloud/organising#468.
See coop-cloud/organising#376.
decentral1se added 1 commit 2023-10-04 12:20:27 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
e837835e00
test: remove duplicate call to EnsureCatalogue
decentral1se added 1 commit 2023-10-04 12:26:02 +00:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is failing Details
2de5016f16
WIP: smoke out CI failure
decentral1se force-pushed compose-file-validation from 2de5016f16 to 3222d52343 2023-10-04 12:27:00 +00:00 Compare
decentral1se force-pushed compose-file-validation from 3222d52343 to 3c4466fad1 2023-10-04 12:31:24 +00:00 Compare
decentral1se force-pushed compose-file-validation from 3c4466fad1 to 8faf315487 2023-10-04 12:32:39 +00:00 Compare
decentral1se force-pushed compose-file-validation from 8faf315487 to 0de11a4b4a 2023-10-04 12:34:57 +00:00 Compare
decentral1se force-pushed compose-file-validation from 0de11a4b4a to dc5d3a8dd6 2023-10-04 12:37:32 +00:00 Compare
decentral1se merged commit dc5d3a8dd6 into main 2023-10-04 12:38:57 +00:00
decentral1se deleted branch compose-file-validation 2023-10-04 12:38:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#365
No description provided.
Delete Branch "compose-file-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?