Improve confusing error message when there's a syntax error in COMPOSE_FILE #376

New Issue

3wordchant · 2023-01-13T23:01:04Z

3wordchant commented

2023-01-13 23:01:04 +00:00

Steps to reproduce:

abra app config <someapp>
(Accidentally biff a COMPOSE_FILE line, so the resulting COMPOSE_FILE var has a double colon, e.g. COMPOSE_FILE=compose.yml::compose.host.yml
abra app deploy <someapp> -f

Expected:

"Hang on, your COMPOSE_FILE setting looks wacky"

Actual:

FATA[0006] read /home/user/.abra/recipes/traefik/: is a directory  caller="/home/user/Projects/Autonomic/CoopCloud/abra/cli/internal/deploy.go:135 DeployAction" stack="/home/user/Projects/Autonomic/CoopCloud/abra/cli/internal/deploy.go:135 DeployAction\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:524        HandleAction\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:173    Command.Run\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:405        (*App).RunAsSubcommand\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:378    Command.startApp\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:102    Command.Run\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:277        (*App).Run\n/home/user/Projects/Autonomic/CoopCloud/abra/cli/cli.go:199             RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cmd/abra/main.go:22        main\n/usr/lib/golang/src/runtime/proc.go:250                              main\n/usr/lib/golang/src/runtime/asm_amd64.s:1594                         goexit"

Steps to reproduce: 1. `abra app config <someapp>` 2. (Accidentally biff a `COMPOSE_FILE` line, so the resulting `COMPOSE_FILE` var has a double colon, e.g. `COMPOSE_FILE=compose.yml::compose.host.yml` 3. `abra app deploy <someapp> -f` Expected: "Hang on, your COMPOSE_FILE setting looks wacky" Actual: ``` FATA[0006] read /home/user/.abra/recipes/traefik/: is a directory caller="/home/user/Projects/Autonomic/CoopCloud/abra/cli/internal/deploy.go:135 DeployAction" stack="/home/user/Projects/Autonomic/CoopCloud/abra/cli/internal/deploy.go:135 DeployAction\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:524 HandleAction\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:173 Command.Run\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:405 (*App).RunAsSubcommand\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:378 Command.startApp\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/command.go:102 Command.Run\n/home/user/.go/pkg/mod/github.com/urfave/cli@v1.22.10/app.go:277 (*App).Run\n/home/user/Projects/Autonomic/CoopCloud/abra/cli/cli.go:199 RunApp\n/home/user/Projects/Autonomic/CoopCloud/abra/cmd/abra/main.go:22 main\n/usr/lib/golang/src/runtime/proc.go:250 main\n/usr/lib/golang/src/runtime/asm_amd64.s:1594 goexit" ```

👍 1

3wordchant added the

enhancement

abra

labels 2023-01-13 23:01:04 +00:00

decentral1se referenced this issue

2023-07-19 21:57:26 +00:00

COMPOSE_FILE overriding gives strange "is a directory" error #468

decentral1se referenced this issue from a commit

2023-10-04 10:50:23 +00:00

fix: validate COMPOSE_FILE

decentral1se referenced this issue from a commit