toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

fix: validate COMPOSE_FILE #365

Merged
decentral1se merged 4 commits from compose-file-validation into main 2023-10-04 12:38:57 +00:00
Conversation 0 Commits 4 Files Changed 9 +137 -42
decentral1se commented 2023-10-04 11:27:36 +00:00
Owner
Copy Link

See coop-cloud/organising#468.
See coop-cloud/organising#376.

Heuristic is to count : if present in COMPOSE_FILE=... and try to ensure the count + 1 turns up after parsing. We also now check that these files exist. I think I've got the COMPOSE_FILE="$COMPOSE_FILE:... approach covered also in the integration tests.

Reviews welcome!

See https://git.coopcloud.tech/coop-cloud/organising/issues/468. See https://git.coopcloud.tech/coop-cloud/organising/issues/376. Heuristic is to count `:` if present in `COMPOSE_FILE=...` and try to ensure the count + 1 turns up after parsing. We also now check that these files exist. I think I've got the `COMPOSE_FILE="$COMPOSE_FILE:...` approach covered also in the integration tests. Reviews welcome!
decentral1se added 1 commit 2023-10-04 11:27:37 +00:00
fix: validate COMPOSE_FILE
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is passing
Details
c646263e9e 
See coop-cloud/organising#468.
See coop-cloud/organising#376.
decentral1se added 1 commit 2023-10-04 12:20:27 +00:00
test: remove duplicate call to EnsureCatalogue
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e837835e00
decentral1se force-pushed compose-file-validation from 2de5016f16 to 3222d52343 2023-10-04 12:27:00 +00:00 Compare
decentral1se force-pushed compose-file-validation from 3222d52343 to 3c4466fad1 2023-10-04 12:31:24 +00:00 Compare
decentral1se force-pushed compose-file-validation from 3c4466fad1 to 8faf315487 2023-10-04 12:32:39 +00:00 Compare
decentral1se force-pushed compose-file-validation from 8faf315487 to 0de11a4b4a 2023-10-04 12:34:57 +00:00 Compare
decentral1se force-pushed compose-file-validation from 0de11a4b4a to dc5d3a8dd6 2023-10-04 12:37:32 +00:00 Compare
decentral1se merged commit dc5d3a8dd6 into main 2023-10-04 12:38:57 +00:00
decentral1se deleted branch compose-file-validation 2023-10-04 12:38:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#365
No description provided.
Delete Branch "compose-file-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?