coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

WIP: upgrade urfave/cli to v2 #404

Draft
p4u1 wants to merge 7 commits from p4u1/abra:upgrade-cli into main
pull from: p4u1/abra:upgrade-cli
merge into: coop-cloud:main
Conversation 4 Commits 7 Files Changed 50 +372 -292
p4u1 commented 2024-02-23 14:00:05 +00:00
Member
Copy Link

THIS IS VERY WIP!!!!

This is an attempt to fix a regression found by running the integration test suite.

The problem is with running the following:

  run $ABRA app cmd --local "$TEST_APP_DOMAIN" test_cmd_arg -- bing

This does not work properly with the old cli library

The main breaking change is a change in the order of flag and argument parsing (see here for details in the migration guide). This change is also what fixes the problem above.

THIS IS VERY WIP!!!! This is an attempt to fix [a regression](https://git.coopcloud.tech/coop-cloud/abra/pulls/403#issuecomment-19723) found by running the integration test suite. The problem is with running the following: ``` run $ABRA app cmd --local "$TEST_APP_DOMAIN" test_cmd_arg -- bing ``` This does not work properly with the old cli library The main breaking change is a change in the order of flag and argument parsing ([see here](https://cli.urfave.org/migrate-v1-to-v2/#flags-before-args) for details in the migration guide). This change is also what fixes the problem above.
p4u1 added 4 commits 2024-02-23 14:00:06 +00:00
continuous-integration/drone/pr Build is failing Details
8a7d17f37b fix
decentral1se commented 2024-02-29 09:14:25 +00:00
Owner
Copy Link

@p4u1 Trying to dig into this now. abra users at large requested that we stay on v1 of urfave for the arg handling that it provides and I did the revert migration in 0e688f1407. Maybe handy if you DM me on matrix to figure this out together. Thanks for looking into it!

@p4u1 Trying to dig into this now. `abra` users at large requested that we stay on v1 of `urfave` for the arg handling that it provides and I did the revert migration in 0e688f1407a1f17333ea6cf4c4f64ba9b9d800fa. Maybe handy if you DM me on matrix to figure this out together. Thanks for looking into it!
decentral1se commented 2024-02-29 09:18:00 +00:00
Owner
Copy Link

coop-cloud/organising#336 seems relevant? Which involved dropping back to a point release of urfave? We could possibly attempt to pin there... am using git log -p --follow go.mod to check the updates/commits...

https://git.coopcloud.tech/coop-cloud/organising/issues/336 seems relevant? Which involved dropping back to a point release of `urfave`? We could possibly attempt to pin there... am using `git log -p --follow go.mod` to check the updates/commits...
p4u1 commented 2024-03-07 17:38:43 +00:00
Author
Member
Copy Link

Thanks for the feedback! I open an issue to discuss this further coop-cloud/organising#581

Thanks for the feedback! I open an issue to discuss this further https://git.coopcloud.tech/coop-cloud/organising/issues/581
p4u1 added 2 commits 2024-03-11 15:09:02 +00:00
continuous-integration/drone/pr Build is failing Details
7d80f4d56b fix
p4u1 added 1 commit 2024-03-11 15:14:39 +00:00
continuous-integration/drone/pr Build is passing Details
b81f5651d3 fmt
decentral1se commented 2024-04-06 22:21:41 +00:00
Owner
Copy Link

@p4u1 given coop-cloud/docs.coopcloud.tech#256 (comment) I think it might be worth a look into how feasible it is to upgrade further into the alpha v3 which provides https://github.com/urfave/cli/pull/1568. this would allow us to specify some flags ("--chaos", "--debug", etc.) as global and can be passed in any "style"? This is a bit of a long shot but might be nicer than "patch to re-order flags" and we could also help upstream fix stuff as we go... whatcha reckon?

@p4u1 given https://git.coopcloud.tech/coop-cloud/docs.coopcloud.tech/pulls/256#issuecomment-20322 I think it might be worth a look into how feasible it is to upgrade further into the alpha v3 which provides https://github.com/urfave/cli/pull/1568. this would allow us to specify some flags ("--chaos", "--debug", etc.) as global and can be passed in any "style"? This is a bit of a long shot but might be nicer than "patch to re-order flags" and we could also help upstream fix stuff as we go... whatcha reckon?
All checks were successful
continuous-integration/drone/pr Build is passing
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b p4u1-upgrade-cli main
git pull upgrade-cli

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff p4u1-upgrade-cli
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#404
No description provided.
Delete Branch "p4u1/abra:upgrade-cli"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?