coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 5 Packages Releases 36 Activity

fix: tag sorting as map is unsorted #66

Closed
roxxers wants to merge 1 commits from fix/tag-sort into main
pull from: fix/tag-sort
merge into: coop-cloud:main
Conversation 2 Commits 1 Files Changed 1 +15 -4
roxxers commented 2021-09-03 19:01:00 +00:00
First-time contributor
Copy Link

Did this to fix #64 and #44 but I am unsure if its ok to merge given the issue I did in coop-cloud/tagcmp#2 since some tags cannot be parsed. Just want others to code review it before I merge it into main.

Did this to fix #64 and #44 but I am unsure if its ok to merge given the issue I did in coop-cloud/tagcmp#2 since some tags cannot be parsed. Just want others to code review it before I merge it into main.
roxxers added 1 commit 2021-09-03 19:01:01 +00:00
continuous-integration/drone/pr Build is passing Details
8cf3930518
fix: tag sorting as map is unsorted
decentral1se commented 2021-09-04 18:17:18 +00:00
Owner
Copy Link

Thanks! This is nice but other things like the https://dev.apps.coopcloud.tech won't have tagcmp to figure this out and perhaps other programs will want to consume the app listing, so I'd rather fix the data structure than working around it here in abra, following coop-cloud/go-abra#44 (comment) instead?

Thanks! This is nice but other things like the https://dev.apps.coopcloud.tech won't have `tagcmp` to figure this out and perhaps other programs will want to consume the app listing, so I'd rather fix the data structure than working around it here in abra, following https://git.coopcloud.tech/coop-cloud/go-abra/issues/44#issue-1892 instead?
decentral1se commented 2021-09-06 09:57:13 +00:00
Owner
Copy Link

I'll get out a fix for this today 👍

I'll get out a fix for this today 👍
decentral1se closed this pull request 2021-09-06 09:57:15 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#66
No description provided.
Delete Branch "fix/tag-sort"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?