backup -- ls: shows too many paths? #37

New Issue

2023-10-12T13:41:46Z

decentral1se commented

2023-10-12 13:41:46 +00:00

I think I would not expect the timestamps?

And further, the lines with /var, /var/lib etc.

🌻 ./abra app backup ls abra-test-recipe.foo.com
2023-10-12T13:33:57.595887937Z /secrets
2023-10-12T13:33:57.595887937Z /secrets/abra-test-recipe_foo_com_pass_one_v1
2023-10-12T13:33:57.595887937Z /secrets/abra-test-recipe_foo_com_test_pass_two_v1
2023-10-12T13:33:03.084078341Z /var
2023-10-12T13:33:03.084078341Z /var/lib
2023-10-12T13:33:03.088078326Z /var/lib/docker
2023-10-12T13:33:02.108081747Z /var/lib/docker/volumes
2023-10-12T13:24:40.985842291Z /var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume
2023-10-12T13:24:40.985842291Z /var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume/_data

Maybe something like?

🌻 ./abra app backup ls abra-test-recipe.foo.com
/secrets/abra-test-recipe_foo_com_pass_one_v1
/secrets/abra-test-recipe_foo_com_test_pass_two_v1
var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume/_data

Also, it would be good to include the time/date of this backup? Is there also an accompanying snapshot ID or additonal metadata you think would be useful to have on the receiving end of this?

I think I would not expect the timestamps? And further, the lines with `/var`, `/var/lib` etc. > 🌻 ./abra app backup ls abra-test-recipe.foo.com > 2023-10-12T13:33:57.595887937Z /secrets > 2023-10-12T13:33:57.595887937Z /secrets/abra-test-recipe_foo_com_pass_one_v1 > 2023-10-12T13:33:57.595887937Z /secrets/abra-test-recipe_foo_com_test_pass_two_v1 > 2023-10-12T13:33:03.084078341Z /var > 2023-10-12T13:33:03.084078341Z /var/lib > 2023-10-12T13:33:03.088078326Z /var/lib/docker > 2023-10-12T13:33:02.108081747Z /var/lib/docker/volumes > 2023-10-12T13:24:40.985842291Z /var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume > 2023-10-12T13:24:40.985842291Z /var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume/_data Maybe something like? > 🌻 ./abra app backup ls abra-test-recipe.foo.com > /secrets/abra-test-recipe_foo_com_pass_one_v1 > /secrets/abra-test-recipe_foo_com_test_pass_two_v1 > var/lib/docker/volumes/abra-test-recipe_foo_com_test-volume/_data Also, it would be good to include the time/date of this backup? Is there also an accompanying snapshot ID or additonal metadata you think would be useful to have on the receiving end of this?

decentral1se commented

2023-10-12 13:45:39 +00:00

Related #27

Related https://git.coopcloud.tech/coop-cloud/backup-bot-two/issues/27

decentral1se commented

2023-10-12 13:46:01 +00:00

@3wordchant any thoughts on output for this which would be useful?

moritz commented

2023-10-18 13:32:08 +00:00

I think for finding files with grep it would be nice to list all files recursively. But instead of being the default behavior, it could be activated with a flag like --all / -a . And the default behavior could be to provide a path, like unix ls works. And maybe activating timestamps with a -t flag?

I think for finding files with `grep` it would be nice to list all files recursively. But instead of being the default behavior, it could be activated with a flag like `--all / -a `. And the default behavior could be to provide a path, like unix `ls` works. And maybe activating timestamps with a `-t` flag?

👍 1 🎉 1

decentral1se commented

2023-10-18 14:53:20 +00:00

That sounds Very Cool @moritz 👍

moritz referenced this issue from a commit

2024-10-24 15:55:33 +00:00

feat(ls): default to show selected paths, --all flag to show all #37

moritz referenced this issue from a commit

2024-10-24 15:59:04 +00:00

feat(ls): default to /var/lib/docker/volumes/ if no path is given #37

moritz commented

2024-10-24 16:05:09 +00:00

The usage is:

Usage: backup ls [OPTIONS] [PATH]

Options:
  -s, --snapshot TEXT
  -a, --all

backup ls will now show /var/lib/docker/volumes/ per default, if no PATH is given. The path can also be set per INCLUDE_PATH env.
The --all flag will show all files recursively. This flag can also be set with the env SHOW_ALL.

The usage is: ``` Usage: backup ls [OPTIONS] [PATH] Options: -s, --snapshot TEXT -a, --all ``` `backup ls` will now show `/var/lib/docker/volumes/` per default, if no `PATH` is given. The path can also be set per `INCLUDE_PATH` env. The `--all` flag will show all files recursively. This flag can also be set with the env `SHOW_ALL`.

❤️ 1

moritz referenced this issue from a commit

2024-10-24 16:09:38 +00:00

feat(ls): add --timestamps flag #37

moritz commented

2024-10-24 16:09:39 +00:00

Added -t, --timestamps flag (TIMESTAMPS env) to show timestamps.

Added `-t, --timestamps` flag (`TIMESTAMPS` env) to show timestamps.

🎉 1

moritz closed this issue

2024-10-24 16:09:39 +00:00

Sign in to join this conversation.