Add healthcheck, backup support, and update documentation #5
Reference in New Issue
Block a user
No description provided.
Delete Branch "yaup/jellyfin:pr/healthcheck-backup-improvements-v2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overview
Adds healthcheck, backup support, and improved documentation to the jellyfin recipe. Updates recipe status from score 1 (alpha) to score 3 (beta).
I compared this to the YunoHost recipe for reference when implementing the changes.
Description
/healthendpointTested generally and validated YAML syntax with
docker compose configThe backup functionality needs additional testing / confirmation - I haven't tested the backup yet. If someone can help verify the backup configuration or notices something missing, I'd appreciate it!
Welcome @yaup 👋 Thanks for the PR! I just one minor comment and have asked for review from others who commit to this recipe. If you don't get anything back shortly, please come ask in the matrix community channels for help.
@ -3,3 +3,2 @@> One line description of the recipe> The Free Software Media System<!-- metadata -->This wild metadata comment system is actually what we parse with
abra:🙈
Hi!
Ah, makes sense! Thanks for the doc reference.
Hmm, I need some convincing regarding backups. coop-cloud apps use backup-bot-two for backups which allows enabling and configuring backups using labels and env values.
Is there a benefit from breaking consistency on how we do backups?
9abbd967c6to30bbd37d48Ah, missed this in my speed run of the docs. No benefit that I know of, let's go with backup bot.
30bbd37d48to2b4e18cea2looks legit!
@ -41,2 +38,4 @@proxy:external: true# coop-cloud recipe metadataHmmm, do these comments do anything?
Oops, good catch. Some leftover notes I didn't mean to commit. Removed them.
2b4e18cea2tocde0595c77Alright, jellyfin is still without a maintainer so I'll just allow myself and merge your change