coop-cloud/matrix-synapse
3
0
Fork 1
Code Issues 6 Pull Requests 5 Releases Activity

Hard to follow upstream homserver.yaml? #33

New Issue
Closed
opened 2022-07-15 14:08:09 +00:00 by decentral1se · 3 comments
decentral1se commented 2022-07-15 14:08:09 +00:00
Owner
Copy Link
Copy Source

Related to #32, I've seen that in https://github.com/matrix-org/synapse/pull/12941 they've removed all the new options from the sample_config.yml in new releases.

This means, it is not possible to check all the homeserver.yaml configuration changes and therefore adapt to new changes via git log .... Especially for security changes.

It seems that we now have to follow the change log and then look into each PR, to see what is the name / default of the new option? Does anyone have any tips here? I'm not quite sure how to keep up now.

I've just released 1.62.0 and it deployed find. But maybe some default config is on that shouldn't be? Feels a bit unstable now tbh.

/cc @yksflip @kawaiipunk

Related to https://git.coopcloud.tech/coop-cloud/matrix-synapse/issues/32, I've seen that in https://github.com/matrix-org/synapse/pull/12941 they've removed all the new options from the `sample_config.yml` in new releases. This means, it is not possible to check all the `homeserver.yaml` configuration changes and therefore adapt to new changes via `git log ...`. Especially for security changes. It seems that we now have to follow the change log and then look into each PR, to see what is the name / default of the new option? Does anyone have any tips here? I'm not quite sure how to keep up now. I've just released 1.62.0 and it deployed find. But maybe some default config is on that shouldn't be? Feels a bit unstable now tbh. /cc @yksflip @kawaiipunk
sef commented 2022-07-16 13:38:05 +00:00
Owner
Copy Link
Copy Source

Perhaps the package maintenance commit log of Cloudron's Synapse can be of some use? https://git.cloudron.io/cloudron/synapse-app/-/commits/master

Perhaps the package maintenance commit log of Cloudron's Synapse can be of some use? https://git.cloudron.io/cloudron/synapse-app/-/commits/master
decentral1se commented 2022-07-18 08:12:40 +00:00
Author
Owner
Copy Link
Copy Source

Nice @sef! I see they are doing a stripped config (no comments, no random defaults) in https://git.cloudron.io/cloudron/synapse-app/-/blob/master/homeserver.yaml.template which we could also consider, I guess. But the concerns in https://github.com/matrix-org/synapse/pull/12941 still apply, some defaults might flip from true/false and we wouldn't really know unless we're following the change log + commit log of upstream closely... there might be no way around that for now until upstream change the way theyre doing things?

Nice @sef! I see they are doing a stripped config (no comments, no random defaults) in https://git.cloudron.io/cloudron/synapse-app/-/blob/master/homeserver.yaml.template which we could also consider, I guess. But the concerns in https://github.com/matrix-org/synapse/pull/12941 still apply, some defaults might flip from true/false and we wouldn't really know unless we're following the change log + commit log of upstream closely... there might be no way around that for now until upstream change the way theyre doing things?
decentral1se commented 2022-11-17 12:26:18 +00:00
Author
Owner
Copy Link
Copy Source

Ping: I am gonna make a move on this soon-ish. If upstream is reducing the config size, I'm inclined to follow them. Then we use our collective brain on the recipe side to make good decisions for privacy and such as we go forward with it.

Ping: I am gonna make a move on this soon-ish. If upstream is reducing the config size, I'm inclined to follow them. Then we use our collective brain on the recipe side to make good decisions for privacy and such as we go forward with it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/matrix-synapse#33