coop-cloud/monitoring-ng
2
0
Fork 2
Code Issues 7 Pull Requests 4 Packages Projects Releases Wiki Activity

fix: Shorten all secret and config names to max 14 characters #13

Open
dannygroenewegen wants to merge 3 commits from eCommons/monitoring-ng:shorter-names into main
pull from: eCommons/monitoring-ng:shorter-names
merge into: coop-cloud:main
Conversation 3 Commits 3 Files Changed 12 +153 -55
dannygroenewegen commented 2026-03-12 11:41:29 +00:00
Owner
Copy Link

This PR solves #12 by shortening all secret and config names to max 14 characters.
Note that this PR is based on #6, which hasn't been merged yet.

I've briefly tested by deploying the current recipe version and upgrading to this PR:

  • When deploying the upgrade, all config files are created with the new shortened name. docker config ls still shows the old config files with longer names, they are not automatically cleaned up.
  • Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.
This PR solves #12 by shortening all secret and config names to max 14 characters. Note that this PR is based on #6, which hasn't been merged yet. I've briefly tested by deploying the current recipe version and upgrading to this PR: - When deploying the upgrade, all config files are created with the new shortened name. `docker config ls` still shows the old config files with longer names, they are not automatically cleaned up. - Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.
❤️ 2
dannygroenewegen added 1 commit 2026-03-12 11:41:30 +00:00
Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it. 0f4033aa97
dannygroenewegen changed title from Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it. to fix: Shorten all secret and config names to max 14 characters 2026-03-12 11:42:23 +00:00
decentral1se requested review from iexos 2026-03-12 12:06:11 +00:00
decentral1se requested review from p4u1 2026-03-12 12:06:11 +00:00
decentral1se requested review from moritz 2026-03-12 12:06:18 +00:00
iexos refused to review 2026-03-12 20:04:56 +00:00
p4u1 changed target branch from seperate-oidc to main 2026-03-20 09:10:49 +00:00
p4u1 approved these changes 2026-03-20 09:13:17 +00:00
p4u1 left a comment
Owner
Copy Link

Thanks a lot! This looks good to me :) I also just merge #6
Could you add a note to the release notes (in release/next) that explains what to do when upgrading?

Thanks a lot! This looks good to me :) I also just merge https://git.coopcloud.tech/coop-cloud/monitoring-ng/pulls/6 Could you add a note to the release notes (in release/next) that explains what to do when upgrading?
👍 1
dannygroenewegen force-pushed shorter-names from 0f4033aa97 to cda5c89033 2026-03-20 20:46:13 +00:00 Compare
dannygroenewegen added 1 commit 2026-03-20 21:00:17 +00:00
Add instructions for shorter secret names to release notes 8cdc3bf744
moritz requested changes 2026-03-24 22:37:41 +00:00
moritz left a comment
Owner
Copy Link

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains.
But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains. But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.
dannygroenewegen force-pushed shorter-names from 8cdc3bf744 to 0ebee51b47 2026-03-25 15:06:38 +00:00 Compare
dannygroenewegen force-pushed shorter-names from 0ebee51b47 to 682f30cef1 2026-03-25 15:11:53 +00:00 Compare
dannygroenewegen commented 2026-03-25 15:18:51 +00:00
Author
Owner
Copy Link

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains.
But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.

I've added migrate_secret_names to abra.sh. It works for me. Can you review if it would fit your needs?

> Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains. > But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it. I've added migrate_secret_names to abra.sh. It works for me. Can you review if it would fit your needs?
dannygroenewegen requested review from moritz 2026-03-25 15:19:00 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u shorter-names:eCommons-shorter-names
git checkout eCommons-shorter-names
Sign in to join this conversation.
Reviewers
No Reviewers
p4u1
moritz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel dannygroenewegen decentral1se devydave fauno flancian Frando iexos jade javielico jjsfunhouse jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moosemower moritz nicksellen notplants p4u1 pau pharaohgraphy PhiNatalie renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val vaznasty virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#13
No description provided.
Delete Branch "eCommons/monitoring-ng:shorter-names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?