fix: Shorten all secret and config names to max 14 characters #13

2026-03-12T11:41:29Z

dannygroenewegen commented

2026-03-12 11:41:29 +00:00

This PR solves #12 by shortening all secret and config names to max 14 characters.
Note that this PR is based on #6, which hasn't been merged yet.

I've briefly tested by deploying the current recipe version and upgrading to this PR:

When deploying the upgrade, all config files are created with the new shortened name. docker config ls still shows the old config files with longer names, they are not automatically cleaned up.
Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.

This PR solves #12 by shortening all secret and config names to max 14 characters. Note that this PR is based on #6, which hasn't been merged yet. I've briefly tested by deploying the current recipe version and upgrading to this PR: - When deploying the upgrade, all config files are created with the new shortened name. `docker config ls` still shows the old config files with longer names, they are not automatically cleaned up. - Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.

❤️ 2

dannygroenewegen added 1 commit 2026-03-12 11:41:30 +00:00

Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it. 0f4033aa97

dannygroenewegen changed title from ~~Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it.~~ to fix: Shorten all secret and config names to max 14 characters

2026-03-12 11:42:23 +00:00

decentral1se requested review from iexos 2026-03-12 12:06:11 +00:00

decentral1se requested review from p4u1 2026-03-12 12:06:11 +00:00

decentral1se requested review from moritz 2026-03-12 12:06:18 +00:00

iexos declined to review 2026-03-12 20:04:56 +00:00

p4u1 changed target branch from seperate-oidc to main

2026-03-20 09:10:49 +00:00

p4u1 approved these changes 2026-03-20 09:13:17 +00:00

p4u1 left a comment

Thanks a lot! This looks good to me :) I also just merge #6
Could you add a note to the release notes (in release/next) that explains what to do when upgrading?

Thanks a lot! This looks good to me :) I also just merge https://git.coopcloud.tech/coop-cloud/monitoring-ng/pulls/6 Could you add a note to the release notes (in release/next) that explains what to do when upgrading?

👍 1

dannygroenewegen force-pushed shorter-names from 0f4033aa97 to cda5c89033

2026-03-20 20:46:13 +00:00

Compare

dannygroenewegen added 1 commit 2026-03-20 21:00:17 +00:00

Add instructions for shorter secret names to release notes 8cdc3bf744

moritz requested changes 2026-03-24 22:37:41 +00:00

Dismissed

moritz left a comment

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains.
But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains. But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.

dannygroenewegen force-pushed shorter-names from 8cdc3bf744 to 0ebee51b47

2026-03-25 15:06:38 +00:00

Compare

dannygroenewegen force-pushed shorter-names from 0ebee51b47 to 682f30cef1

2026-03-25 15:11:53 +00:00

Compare

dannygroenewegen commented

2026-03-25 15:18:51 +00:00

Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains.
But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it.

I've added migrate_secret_names to abra.sh. It works for me. Can you review if it would fit your needs?

> Thank you, I really like this PR. I also tried to shorten the secret names of many recipes long ago because we had problems with too long domains. > But changing the secret names is also a huge breaking change, that takes a lot of effort to change all secrets for all deployed apps. I would favor if there is a abra.sh function that can be run with the --local flag, that extracts the actual secrets and automatically inserts them with the new names, before running the update. Just contact if you need help in implementing it. I've added migrate_secret_names to abra.sh. It works for me. Can you review if it would fit your needs?

🎉 1

dannygroenewegen requested review from moritz 2026-03-25 15:19:00 +00:00

p4u1 referenced this pull request

2026-03-27 16:37:39 +00:00

Future of the recipe #14

dannygroenewegen commented

2026-05-07 08:26:19 +00:00

@moritz Do you want to review the migrate_secret_names function? Or is it ok for you to merge this so we can move forward? Also happy to prioritise if we want any changes to this function after merging. I'd like to resolve all my chaos deployments. It's a bit awkward to develop chaos on top of chaos.

p4u1 commented

2026-05-07 18:14:53 +00:00

@dannygroenewegen I would say we merge this and make changes later if needed

moritz approved these changes 2026-05-11 15:36:35 +00:00

moritz left a comment

By reading it, it looks all fine to me, but I have not the time to carefully test it at the moment. I will just merge it so the we can move forward. And if something will break we can simply patch it, note it in the release notes and remove the tag from the breaking version.

👍 1

moritz merged commit dd320e9f1c into main

2026-05-11 15:38:17 +00:00

moritz referenced this issue from a commit

2026-05-11 15:38:17 +00:00

fix: Shorten all secret and config names to max 14 characters (#13)

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#13

Allow edits from maintainers