coop-cloud/monitoring-ng
1
0
Fork 2
Code Issues 4 Pull Requests 8 Packages Projects Releases Wiki Activity

fix: Shorten all secret and config names to max 14 characters #13

Open
dannygroenewegen wants to merge 1 commits from eCommons/monitoring-ng:shorter-names into seperate-oidc
pull from: eCommons/monitoring-ng:shorter-names
merge into: coop-cloud:seperate-oidc
Conversation 0 Commits 1 Files Changed 11 +59 -58
dannygroenewegen commented 2026-03-12 11:41:29 +00:00
First-time contributor
Copy Link

This PR solves #12 by shortening all secret and config names to max 14 characters.
Note that this PR is based on #6, which hasn't been merged yet.

I've briefly tested by deploying the current recipe version and upgrading to this PR:

  • When deploying the upgrade, all config files are created with the new shortened name. docker config ls still shows the old config files with longer names, they are not automatically cleaned up.
  • Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.
This PR solves #12 by shortening all secret and config names to max 14 characters. Note that this PR is based on #6, which hasn't been merged yet. I've briefly tested by deploying the current recipe version and upgrading to this PR: - When deploying the upgrade, all config files are created with the new shortened name. `docker config ls` still shows the old config files with longer names, they are not automatically cleaned up. - Secrets have to be reinserted with the new, shorter name. This breaks automatic upgrading, but it shouldn't break a running instance because deployment fails if the new shorter secret isn't inserted.
❤️ 2
dannygroenewegen added 1 commit 2026-03-12 11:41:30 +00:00
Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it. 0f4033aa97
dannygroenewegen changed title from Shortened all the secret and config names to max 14 characters to prevent running into Docker's 64 character limit when STACK_NAME is appended to it. to fix: Shorten all secret and config names to max 14 characters 2026-03-12 11:42:23 +00:00
decentral1se requested review from iexos 2026-03-12 12:06:11 +00:00
decentral1se requested review from p4u1 2026-03-12 12:06:11 +00:00
decentral1se requested review from moritz 2026-03-12 12:06:18 +00:00
iexos refused to review 2026-03-12 20:04:56 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u shorter-names:eCommons-shorter-names
git checkout eCommons-shorter-names
Sign in to join this conversation.
Reviewers
No Reviewers
p4u1
moritz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se devydave fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val vaznasty virtualboys wolcen wykwit xynosis yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#13
No description provided.
Delete Branch "eCommons/monitoring-ng:shorter-names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?